Re: [PATCH v2 0/8] Cleanup rootfs creation

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

Hi Claudius,

On 4/24/19 8:53 AM, Claudius Heine wrote:
> Hi Maxim,
> 
> On 22/04/2019 15.48, Maxim Yu. Osipov wrote:
>> The same problem with SDK creation discovered in v1 series persists 
>> also in v2 series.
>>
>> Just recognized that "quick" CI build fails too. See for details:
>> http://isar-build.org:8080/job/isar_mosipov_develop/91/console
>>
>> Please run CI scripts before submitting patches to the mailing list - 
> 
> I did:
> 
> http://isar-build.org:8080/job/isar_claudius_ilbers-ci/46/consoleText
> 
> That build just fails because of the qemu boot where loading of modules 
> fails for some reason, but you said that could be ignored.

Well, I said that one may ignore problems with checking login prompt (CI 
tests need to be improved at this point), but I don't remember that I 
said that one may ignore problems with modules loading.

Actually, the problem with loading modules persists in the current 
'next' starting from the build #291 (when I applied your patch set 
Implement ROOTFS postprocess commands)
http://isar-build.org:8080/job/isar_next/291/console

I'm investigating the reason now - from the first glance the ARM stretch 
kernel version has been changed from 4.9.0-8 to 4.19.0.4.

> 
>> this will save maintainer's time.
> 
> Well if you are short on time, then I would suggest looking into better 
> tooling.
> 
> There are solutions that could automate most of the job you do as a 
> maintainer, meaning loading patchset from mailinglist, processing it in 
> CI and reporting results back to the mailinglist.
> 
> Probably something like this:
> https://that.guru/blog/patchwork-and-ci-in-a-tree/
> 
> As I suggested months ago that patchwork can help safe time and avoid 
> leaving any patches behind. If you don't look into solutions like that 
> or write your own scripting, then I don't see much reason for you to 
> complain.


> By doing that, you might even have enough time to start doing code 
> reviews and taking part in design discussions etc. where it is much 
> better invested that just pushing the "Run CI build" button and waiting 
> for that to finish.


> To be fair I might do you injustice and you are performing thorough 
> review of every ones patches and every ones code is just that excellent 
> that only grammar and spelling mistakes in commit messages are left to 
> critic, but then it might just be a matter of improving communication.

Thanks for the link/your opinion.

Maxim.

> Claudius
> 
>>
>> Maxim.
>>
>> On 4/17/19 1:11 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> Hi,
>>>
>>> this is the fixed up version.
>>>
>>> regards,
>>> Claudius
>>>
>>> changes from v1:
>>>   - fixed typo in commit message
>>>
>>> Claudius Heine (8):
>>>    isar-boostrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to
>>>      base.bbclass
>>>    move 'HOST_DISTRO_APT_SOURCES' from bootstrap-helper to 
>>> isar-bootstrap
>>>    buildchroot.bbclass: only cross build if HOST_ARCH != DISTRO_ARCH
>>>    isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR
>>>    bitbake.conf: remove unneeded and differently used variables
>>>    image.bbclass: make IMAGE_ROOTFS overwritable
>>>    bitbake.conf: set default QEMU_ARCH variables
>>>    buildchroot/configscript: make creation of builder uid/gid idempotent
>>>
>>>   meta/classes/base.bbclass                          |  9 +++++++++
>>>   meta/classes/buildchroot.bbclass                   |  2 +-
>>>   meta/classes/image-sdk-extension.bbclass           |  2 +-
>>>   meta/classes/image.bbclass                         |  2 +-
>>>   meta/classes/isar-bootstrap-helper.bbclass         | 14 --------------
>>>   meta/conf/bitbake.conf                             | 13 ++++++++-----
>>>   .../isar-bootstrap/isar-bootstrap-host.bb          | 11 +++--------
>>>   .../isar-bootstrap/isar-bootstrap-target.bb        |  6 +-----
>>>   .../recipes-core/isar-bootstrap/isar-bootstrap.inc |  1 +
>>>   .../buildchroot/buildchroot-host.bb                |  1 +
>>>   meta/recipes-devtools/buildchroot/buildchroot.inc  |  3 +--
>>>   .../buildchroot/files/configscript.sh              |  4 ++--
>>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb       |  3 +--
>>>   13 files changed, 30 insertions(+), 41 deletions(-)
>>>
>>
>>
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov