From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6680483261914808320 X-Received: by 2002:a50:aa76:: with SMTP id p51mr12810198edc.62.1556092844170; Wed, 24 Apr 2019 01:00:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:8d0:: with SMTP id o16ls2559645eje.16.gmail; Wed, 24 Apr 2019 01:00:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOTSiUas7kxSamxApeZgOPyq9/YPX8r5IP4BYayRSdFZ++UYPsNChL55/tmS4iOTfU4HHM X-Received: by 2002:a17:906:4586:: with SMTP id t6mr15470821ejq.52.1556092843697; Wed, 24 Apr 2019 01:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556092843; cv=none; d=google.com; s=arc-20160816; b=ZjLEzubKTLiwWLKwFKXF7O4F2K79DAUdxS1WHhC24GibLx60VCcFZUPlmFRBD+OGTh f0CpQ6jC2F68wIl7/Lb0NmdbTQUbXr6HlviU7ewXmRb8BgNfdSSuGzfybjbEShmHfcVa GjvAXY9mOpDaLG6iRgHXS27efelBx4t7BqpekeCqLSvOml7lg6hyHtdXy8AsV4P+Zi4R BbcTkLO80/MacR3he2ELHiMPTvTWd3vx+3I1xJk7b4f7xVkCgzKkBrpPAaZxReLQQfbf 2TXzsdzT7q6ngM4FP4K8a3Yn6fgE91W2HyKTwOeQhYVrUBXPbVUK2FYW7iIj+eE9ZUZ8 TyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=3e10rToQYjNq4netwwTK7jorjWp1ZroeBRdE+7DnV1k=; b=H4dk+Fe4g5wsQ61JiyRh81pGel31i8PUN8dT7X/EOQ65sV28E8mQtSbfdche6SkG6l 0fHQM+VVPBFvV78V4bKlEfl3Cx5meumvnEKrd5JjxaN7a5QC2eLkcyIHReeQa8YUuIqY 4WK6x/yJ+HYodHArD+aD2RAeTLxgEmkMkz6FL03s6w2CO6dQK1pviEjnlUx9EA878sdg CnGLaPWbPxlFmbMmokCpbtfA62rJwzZ8FYMu4cnHeBzXHJERw5uUmFb4iiC+Gu5JyRAY qF+G/paCRpSyFsDd7Z0Hbaeu0xtGy3jfERxm0onM8hZxgsGoMskoI1RctJ2da1hHedi/ EHgQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id j5si772000ejm.1.2019.04.24.01.00.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 01:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x3O80cIT003917 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2019 10:00:40 +0200 Subject: Re: [PATCH v2 0/8] Cleanup rootfs creation To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190417111159.2184-1-claudius.heine.ext@siemens.com> <24e19870-6d4c-3258-e568-b8e77d7158e2@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <617a0721-0612-e1eb-fcd6-1b3465976e35@ilbers.de> Date: Wed, 24 Apr 2019 11:00:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <24e19870-6d4c-3258-e568-b8e77d7158e2@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: QM7X5CFamN2k Hi Claudius, On 4/24/19 8:53 AM, Claudius Heine wrote: > Hi Maxim, > > On 22/04/2019 15.48, Maxim Yu. Osipov wrote: >> The same problem with SDK creation discovered in v1 series persists >> also in v2 series. >> >> Just recognized that "quick" CI build fails too. See for details: >> http://isar-build.org:8080/job/isar_mosipov_develop/91/console >> >> Please run CI scripts before submitting patches to the mailing list - > > I did: > > http://isar-build.org:8080/job/isar_claudius_ilbers-ci/46/consoleText > > That build just fails because of the qemu boot where loading of modules > fails for some reason, but you said that could be ignored. Well, I said that one may ignore problems with checking login prompt (CI tests need to be improved at this point), but I don't remember that I said that one may ignore problems with modules loading. Actually, the problem with loading modules persists in the current 'next' starting from the build #291 (when I applied your patch set Implement ROOTFS postprocess commands) http://isar-build.org:8080/job/isar_next/291/console I'm investigating the reason now - from the first glance the ARM stretch kernel version has been changed from 4.9.0-8 to 4.19.0.4. > >> this will save maintainer's time. > > Well if you are short on time, then I would suggest looking into better > tooling. > > There are solutions that could automate most of the job you do as a > maintainer, meaning loading patchset from mailinglist, processing it in > CI and reporting results back to the mailinglist. > > Probably something like this: > https://that.guru/blog/patchwork-and-ci-in-a-tree/ > > As I suggested months ago that patchwork can help safe time and avoid > leaving any patches behind. If you don't look into solutions like that > or write your own scripting, then I don't see much reason for you to > complain. > By doing that, you might even have enough time to start doing code > reviews and taking part in design discussions etc. where it is much > better invested that just pushing the "Run CI build" button and waiting > for that to finish. > To be fair I might do you injustice and you are performing thorough > review of every ones patches and every ones code is just that excellent > that only grammar and spelling mistakes in commit messages are left to > critic, but then it might just be a matter of improving communication. Thanks for the link/your opinion. Maxim. > Claudius > >> >> Maxim. >> >> On 4/17/19 1:11 PM, claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> Hi, >>> >>> this is the fixed up version. >>> >>> regards, >>> Claudius >>> >>> changes from v1: >>>   - fixed typo in commit message >>> >>> Claudius Heine (8): >>>    isar-boostrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to >>>      base.bbclass >>>    move 'HOST_DISTRO_APT_SOURCES' from bootstrap-helper to >>> isar-bootstrap >>>    buildchroot.bbclass: only cross build if HOST_ARCH != DISTRO_ARCH >>>    isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR >>>    bitbake.conf: remove unneeded and differently used variables >>>    image.bbclass: make IMAGE_ROOTFS overwritable >>>    bitbake.conf: set default QEMU_ARCH variables >>>    buildchroot/configscript: make creation of builder uid/gid idempotent >>> >>>   meta/classes/base.bbclass                          |  9 +++++++++ >>>   meta/classes/buildchroot.bbclass                   |  2 +- >>>   meta/classes/image-sdk-extension.bbclass           |  2 +- >>>   meta/classes/image.bbclass                         |  2 +- >>>   meta/classes/isar-bootstrap-helper.bbclass         | 14 -------------- >>>   meta/conf/bitbake.conf                             | 13 ++++++++----- >>>   .../isar-bootstrap/isar-bootstrap-host.bb          | 11 +++-------- >>>   .../isar-bootstrap/isar-bootstrap-target.bb        |  6 +----- >>>   .../recipes-core/isar-bootstrap/isar-bootstrap.inc |  1 + >>>   .../buildchroot/buildchroot-host.bb                |  1 + >>>   meta/recipes-devtools/buildchroot/buildchroot.inc  |  3 +-- >>>   .../buildchroot/files/configscript.sh              |  4 ++-- >>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb       |  3 +-- >>>   13 files changed, 30 insertions(+), 41 deletions(-) >>> >> >> > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov