Re: [PATCH 05/13] kas: Add packages selection

[Jan Kiszka <jan.kiszka@siemens.com>]

On 15.09.23 12:14, Uladzimir Bely wrote:
> This part of configuration allows to choose which additional packages
> (both from Isar and Debian) to include to the target image.
> 
> Isar packages are added to IMAGE_INSTALL since Debian packages go
> to IMAGE_PREINSTALL.
> 
> The features are implemented as "string" parameter in the menu since
> it reduces a number of required YAML fragments.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  kas/opt/Kconfig             | 41 +++++++++++++++++++++++++++++++++++++
>  kas/opt/packages-distro.yml |  6 ++++++
>  kas/opt/packages-isar.yml   |  6 ++++++
>  3 files changed, 53 insertions(+)
>  create mode 100644 kas/opt/packages-distro.yml
>  create mode 100644 kas/opt/packages-isar.yml
> 
> diff --git a/kas/opt/Kconfig b/kas/opt/Kconfig
> index c6e60583..1aa319dc 100644
> --- a/kas/opt/Kconfig
> +++ b/kas/opt/Kconfig
> @@ -32,3 +32,44 @@ config KAS_INCLUDE_MIRROR_UBUNTU
>  	depends on MIRROR_UBUNTU
>  
>  endmenu
> +
> +menu "Packages selection"
> +
> +config KAS_IMAGE_INSTALL
> +	string "Isar packages"
> +	default ""

The default we have in the local.conf.sample is different. Is this list
here much shorter on purpose? I'm not necessarily asking for the full
list, just reflecting on this.

> +	help
> +	  Space-separated list of packages that are build by Isar, usually from
> +	  the sources. Isar provides build-in recipes for these packages.
> +	  The list includes (but not limited by) the following packages:
> +	    cowsay
> +	    enable-fsck
> +	    example-raw
> +	    example-module-${KERNEL_NAME}
> +	    example-prebuilt
> +	    expand-on-first-boot
> +	    hello
> +	    hello-isar
> +	    isar-exclude-docs
> +	    isar-disable-apt-cache
> +	    kselftest
> +	    samefile
> +	    sshd-regen-keys

A string is a bit unhandy, at least for the known internal packages.
OTOH, it may then need a kas yaml snippet for each package the user
could select.

> +
> +config KAS_INCLUDE_PACKAGES_ISAR
> +	string
> +	default "kas/opt/packages-isar.yml"
> +
> +config KAS_IMAGE_PREINSTALL
> +	string "Distro packages"
> +	default ""

A nice default would be adding networking packages.

> +	help
> +	  Space-separated list of packages that are provided by the selected distro.
> +	  These packages are downloaded from distro mirrors and just unpacked
> +	  and configured by Isar.
> +
> +config KAS_INCLUDE_PACKAGES_DISTRO
> +	string
> +	default "kas/opt/packages-distro.yml"
> +
> +endmenu
> diff --git a/kas/opt/packages-distro.yml b/kas/opt/packages-distro.yml
> new file mode 100644
> index 00000000..d2fca914
> --- /dev/null
> +++ b/kas/opt/packages-distro.yml
> @@ -0,0 +1,6 @@
> +header:
> +  version: 14
> +
> +local_conf_header:
> +  packages-distro: |
> +    IMAGE_PREINSTALL:append = " ${KAS_IMAGE_PREINSTALL}"
> diff --git a/kas/opt/packages-isar.yml b/kas/opt/packages-isar.yml
> new file mode 100644
> index 00000000..c8da258d
> --- /dev/null
> +++ b/kas/opt/packages-isar.yml
> @@ -0,0 +1,6 @@
> +header:
> +  version: 14
> +
> +local_conf_header:
> +  packages-isar: |
> +    IMAGE_INSTALL:append = " ${KAS_IMAGE_INSTALL}"

Jan

-- 
Siemens AG, Technology
Linux Expert Center