From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:a1c:2d15:: with SMTP id t21mr367794wmt.1.1548676475392; Mon, 28 Jan 2019 03:54:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:3581:: with SMTP id c123ls1906651wma.9.gmail; Mon, 28 Jan 2019 03:54:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN4fG0QnLxFUl4Av9BXUFhhQBibtNpcqjmVi0k1SLWGaFi2cd72OP02X/IaQbQjk4dOBHjt5 X-Received: by 2002:a1c:2d15:: with SMTP id t21mr367792wmt.1.1548676474879; Mon, 28 Jan 2019 03:54:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548676474; cv=none; d=google.com; s=arc-20160816; b=rfMANFp6CzebcLJQQLmd8IKw55IYQYH8BISwQYxYaFFbQA5lWtFDBHs12sD1zkgFMu d1PhY7BbiD7Lr2Tbi0joBV1E7MZarosmBqrrRIRwZXvaK5e36Ac/5K7xDuNyc+3gRROa hDBlDcgHkbZtBulr4xUo/WrQj1awC/BKBOqbLoYwYVFqTelxOKqI1GeFd4EyYj4vNcMQ 8wkAOLbi0zf+JVPqDK2JIPg+vO04fpqTJr/76MJ+GKfbaHCos6ZupAp8vSpziHTg0G0G XG0xNuy9Mra5MwnCIO+oO4gTQfGCCmSsuSWYccHymgfgFgLgrChBRrrCA+BsNVJpt7/r CeGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=ZaV9F64/SAkBAC6XUkILcl2681aoS8PfFUVZUbtnn9Q=; b=WTZch/Thda6WLMvDBCvgIMpKVMInVQUWqA2uvhHhUDXAc4s0W3tGFmYOv6RXSG8+k+ 8KggF4ESQBZJdjHQtyinf7Qr2jCUwa4KFDgCC3/JoXRXQbmIr4AHvhU+OTokwVpj1Z+3 EF1oDLEg8BdWqM35yW4k45d7KWqg63svdUa/pPGVZlVCyjsXkFa5NAZXYRKPBI3rbxDD W+ZbfStpNhSqBdBs1iX/j786zBPO+MBeTCTFv2+oKo6Hu0Hw3hiGR4YpRvOPXZ9CaG6I xXzh1E0DlA1aY4SHOa/eiwggpgEPwl/L1hXP/4J0LHGzWPsl3BulUCo4gdlRpTwoZhhV YT8A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id 69si3754410wrb.1.2019.01.28.03.54.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 03:54:34 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x0SBsYTf029050 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 28 Jan 2019 12:54:34 +0100 Received: from [167.87.35.18] ([167.87.35.18]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0SBsXs8026076; Mon, 28 Jan 2019 12:54:34 +0100 Subject: Re: [PATCHv2] linux-custom: skip linux-libc-dev deployment on downgrade To: "[ext] Henning Schild" , isar-users@googlegroups.com References: <20190117130342.15743-1-henning.schild@siemens.com> <20190128115108.2386-1-henning.schild@siemens.com> From: Jan Kiszka Message-ID: <619db60f-e21c-2796-242f-38ef76c9b744@siemens.com> Date: Mon, 28 Jan 2019 12:54:33 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190128115108.2386-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: nCnon8WKuXQB On 28.01.19 12:51, [ext] Henning Schild wrote: > From: Henning Schild > > A custom kernel usually deploys linux-libc-dev in the kernels version. > But some packages in the distribution depend on >= expected upstream > version of that package. If we deploy a linux-libc-dev in a lower > version, installing packages like build-essential will not be possible > anymore. > That is especially problematic since incremental builds will pull that > into our buildchroot and break package installation in there. > > If detecting a downgrade, do not deploy the package and issue a warning. > > Signed-off-by: Henning Schild > --- > meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++ > meta/recipes-kernel/linux/linux-custom.inc | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh > index dbd6162..745c89a 100644 > --- a/meta/recipes-kernel/linux/files/build-kernel.sh > +++ b/meta/recipes-kernel/linux/files/build-kernel.sh > @@ -122,3 +122,10 @@ rm -f linux-image-${PV}_${PV}-1_*.deb > fakeroot dpkg-deb -b ${REPACK_LINUX_HEADERS_DIR} \ > linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb > rm -f linux-headers-${PV}_${PV}-1_*.deb > + > +# linux-libc-dev causes dependency problems if we downgrade > +# remove it after the build so the downgraded version does not get deployed > +LINUX_LIBC_DEV_V=$( dpkg-query --show --showformat '${Version}' linux-libc-dev ) > +if dpkg --compare-versions $LINUX_LIBC_DEV_V gt $PV; then > + rm -f linux-libc-dev_${PV}*.deb > +fi > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index f33bb9d..ac37412 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -62,4 +62,7 @@ dpkg_runbuild() { > export KERNEL_HEADERS_DEBIAN_DEPENDS="${KERNEL_HEADERS_DEBIAN_DEPENDS}" > > sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} ${DISTRO_ARCH} > + if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then > + bbwarn "Kernel downgrade detected, not deploying linux-libc-dev" > + fi > } > Thanks, looks good. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux