public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Harald Seiler <hws@denx.de>, isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>, Henning Schild <henning.schild@siemens.com>
Subject: Re: [PATCH] image: Run copy_boot_files after rootfs postprocessing
Date: Tue, 13 Oct 2020 12:19:10 +0200	[thread overview]
Message-ID: <61a681ed-f982-30a4-12f6-5b1b1d49b780@siemens.com> (raw)
In-Reply-To: <20200625153351.3402179-1-hws@denx.de>

On 25.06.20 17:33, Harald Seiler wrote:
> In some cases, postprocessing might trigger an update of the initramfs
> which would not appear in the deployed version.  Fix this by running
> copy_boot_files only after all postprocessing completed.
> 
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
>  meta/classes/image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 0150f2718573..21d634a8f34f 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -153,7 +153,7 @@ do_copy_boot_files() {
>          cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/"
>      done
>  }
> -addtask copy_boot_files before do_rootfs_postprocess after do_rootfs_install
> +addtask copy_boot_files before do_rootfs after do_rootfs_postprocess
>  
>  python do_image_tools() {
>      """Virtual task"""
> 

There was a lengthy discussion after this, but I don't think the
conclusion was to hold back this patch, right? We are using it at least
in one case internally, so this should likely go in now.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

  parent reply	other threads:[~2020-10-13 10:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 15:33 Harald Seiler
2020-06-25 16:48 ` Henning Schild
2020-06-25 17:02   ` Jan Kiszka
2020-06-25 17:24     ` Harald Seiler
2020-06-25 18:43       ` Henning Schild
2020-06-25 19:23         ` Henning Schild
2020-06-25 19:27           ` Henning Schild
2020-06-26  8:13             ` Harald Seiler
2020-06-26  8:19               ` Jan Kiszka
2020-06-26  8:26               ` Henning Schild
2020-06-26  8:44                 ` Jan Kiszka
2020-06-26  9:15                   ` Henning Schild
2020-06-26  7:17       ` Claudius Heine
2020-06-26  8:02         ` Harald Seiler
2020-06-26  9:12         ` Jan Kiszka
2020-06-29  9:04           ` Claudius Heine
2020-06-29  9:13             ` Jan Kiszka
2020-06-29 12:22           ` Harald Seiler
2020-06-29 12:41             ` Jan Kiszka
2020-06-29 12:55               ` Henning Schild
2020-06-29 13:25                 ` Jan Kiszka
2020-07-01  8:29               ` Claudius Heine
2020-10-13 10:19 ` Jan Kiszka [this message]
2020-10-13 10:26   ` Harald Seiler
2020-10-13 10:35     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a681ed-f982-30a4-12f6-5b1b1d49b780@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=ch@denx.de \
    --cc=henning.schild@siemens.com \
    --cc=hws@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox