public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Cc: henning.schild@siemens.com
Subject: Re: [PATCH] unify ubuntu-focal.conf with debian config files
Date: Wed, 28 Sep 2022 12:52:14 +0300	[thread overview]
Message-ID: <61ac0f83-bbf7-b636-3de6-773c65f3bf76@ilbers.de> (raw)
In-Reply-To: <20220927040319.278761-1-felix.moessbauer@siemens.com>

27.09.2022 07:03, Felix Moessbauer wrote:
> This patch reworks the ubuntu-focal.conf distro config file.
> It unifies the pattern used for DISTRO_APT_SOURCES with the
> pattern used in debian-common.conf.
>
> By that, the BASE_DISTRO variable is used to select the corresponding
> apt sources.
> This makes it possible to derive custom distros based on ubuntu as well.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta-isar/conf/distro/ubuntu-focal.conf | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/meta-isar/conf/distro/ubuntu-focal.conf b/meta-isar/conf/distro/ubuntu-focal.conf
> index c0d12967..9e2ff27a 100644
> --- a/meta-isar/conf/distro/ubuntu-focal.conf
> +++ b/meta-isar/conf/distro/ubuntu-focal.conf
> @@ -6,13 +6,11 @@
>   require conf/distro/debian-common.conf
>   
>   BASE_DISTRO = "ubuntu"
> -
> -DISTRO_APT_SOURCES ?= "conf/distro/${DISTRO}.list"
> -DISTRO_APT_SOURCES_arm64 ?= "conf/distro/${DISTRO}-ports.list"
> -HOST_DISTRO_APT_SOURCES_append_arm64 = " ${DISTRO_APT_SOURCES}"
> -
>   BASE_DISTRO_CODENAME = "focal"
>   
> +DISTRO_APT_SOURCES_arm64 ?= "conf/distro/${BASE_DISTRO}-${BASE_DISTRO_CODENAME}-ports.list"
> +HOST_DISTRO_APT_SOURCES_arm64 ?= "conf/distro/${HOST_DISTRO}-ports.list"
> +
>   # that is what debootstrap_1.0.118ubuntu1 does anyways
>   DISTRO_DEBOOTSTRAP_SCRIPT = "/usr/share/debootstrap/scripts/gutsy"
>   

Hello Felix,

Changing HOST_DISTRO_APT_SOURCES for arm64 was done incorrectly here.
It should be set to ubuntu-focal.list+ubuntu-focal-ports.list while you 
set it
just to ubuntu-focal-ports.list


  reply	other threads:[~2022-09-28  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27  4:03 Felix Moessbauer
2022-09-28  9:52 ` Anton Mikanovich [this message]
2022-09-28 10:01   ` Moessbauer, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61ac0f83-bbf7-b636-3de6-773c65f3bf76@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox