Re: [PATCH v1 1/2] dpkg: Adjust symlinks for mirrors

[Jan Kiszka <jan.kiszka@siemens.com>]

On 23.03.21 12:50, Anton Mikanovich wrote:
> When bitbake fetch git repository from mirror it creates symlink from
> original repository name. This symlink use absolute path, which is not
> exist inside chroot when building the package. So we need to adjust this
> path just like we do for git alternates path.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/dpkg-base.bbclass | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
> index 5c7bddc..23dc191 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -26,6 +26,13 @@ python do_adjust_git() {
>              if ud.type != 'git':
>                  continue
>  
> +            if os.path.islink(ud.localpath):
> +                realpath = os.path.realpath(ud.localpath)
> +                if realpath.startswith(d.getVar("DL_DIR")):
> +                    link = realpath.replace(d.getVar("DL_DIR"), '/downloads', 1)
> +                    os.unlink(ud.localpath)
> +                    os.symlink(link, ud.localpath)
> +
>              subdir = ud.parm.get("subpath", "")
>              if subdir != "":
>                  def_destsuffix = "%s/" % os.path.basename(subdir.rstrip('/'))
> 

This is racy and can generate random build breakages if a git repo
should be used by multiple recipes. I'll fix this up by locking all
adjust_git tasks, which I need for making it compatible it compatible
with git-patching anyway.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux