[PATCH 0/1] Don't run update-initramfs with enable-fsck

[PATCH 0/1] Don't run update-initramfs with enable-fsck

[Uladzimir Bely]

The enable-fsck recipe installs into the system the script that sets
'fs_passno' fields for the partitions in fstab. After that, it calls
'update-initramfs -u' that takes several minutes to run.

In CI this sometimes causes fails with 'run_vm' tests while there is
no proper command prompt after expected timeout, especially if CI
server is highly loaded.

Actually, there were several targets checked. All of them had empty
fstab in their generated initramfs images. So, 'update-initramfs -u'
just takes much time but doesn't really change anything and may be
omitted.

Anyway, something could be overlooked during investigations, so if we
really need initramfs update at first run, it would be nice to know
exactly why.

Uladzimir Bely (1):
  enable-fsck: don't run update-initramfs after fstab modification

 meta/recipes-support/enable-fsck/files/enable-fsck.sh | 2 --
 1 file changed, 2 deletions(-)

-- 
2.20.1

[PATCH 1/1] enable-fsck: don't run update-initramfs after fstab modification

[Uladzimir Bely]

On first machine run, if enable-fsck recipe was enabled, it takes
much time to start because of spending too much time on
the 'update-initramfs -u' call.

Removing it while it really does nothing useful.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/recipes-support/enable-fsck/files/enable-fsck.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-support/enable-fsck/files/enable-fsck.sh b/meta/recipes-support/enable-fsck/files/enable-fsck.sh
index d09e35df..72d6bd78 100644
--- a/meta/recipes-support/enable-fsck/files/enable-fsck.sh
+++ b/meta/recipes-support/enable-fsck/files/enable-fsck.sh
@@ -12,5 +12,3 @@ set -e
 ROOT_DEV="$(/bin/findmnt -n -o SOURCE /)"
 sed -i -e 's|^/dev/root\([ 	]\+.*[ 	]\+\)0[ 	]\+0|'"$ROOT_DEV"'\10	1|' \
        -e 's|^\(/dev/.*[ 	]\+\)0[ 	]\+0|\10	2|' /etc/fstab
-
-update-initramfs -u
-- 
2.20.1

Re: [PATCH 0/1] Don't run update-initramfs with enable-fsck

[Jan Kiszka]

On 21.01.22 08:42, Uladzimir Bely wrote:
> The enable-fsck recipe installs into the system the script that sets
> 'fs_passno' fields for the partitions in fstab. After that, it calls
> 'update-initramfs -u' that takes several minutes to run.
> 
> In CI this sometimes causes fails with 'run_vm' tests while there is
> no proper command prompt after expected timeout, especially if CI
> server is highly loaded.
> 
> Actually, there were several targets checked. All of them had empty
> fstab in their generated initramfs images. So, 'update-initramfs -u'
> just takes much time but doesn't really change anything and may be
> omitted.
> 
> Anyway, something could be overlooked during investigations, so if we
> really need initramfs update at first run, it would be nice to know
> exactly why.
> 

I don't recall details about this anymore. I would just recommend to 
check if there are any differences in buster vs. newer versions. Stretch 
is no longer supported, but I think it was the target back then, and 
maybe that did something different /wrt the initramfs.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH 0/1] Don't run update-initramfs with enable-fsck

[Anton Mikanovich]

21.01.2022 10:42, Uladzimir Bely wrote:
> The enable-fsck recipe installs into the system the script that sets
> 'fs_passno' fields for the partitions in fstab. After that, it calls
> 'update-initramfs -u' that takes several minutes to run.
>
> In CI this sometimes causes fails with 'run_vm' tests while there is
> no proper command prompt after expected timeout, especially if CI
> server is highly loaded.
>
> Actually, there were several targets checked. All of them had empty
> fstab in their generated initramfs images. So, 'update-initramfs -u'
> just takes much time but doesn't really change anything and may be
> omitted.
>
> Anyway, something could be overlooked during investigations, so if we
> really need initramfs update at first run, it would be nice to know
> exactly why.
>
> Uladzimir Bely (1):
>    enable-fsck: don't run update-initramfs after fstab modification
>
>   meta/recipes-support/enable-fsck/files/enable-fsck.sh | 2 --
>   1 file changed, 2 deletions(-)
>
Applied to next, thanks.