public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Q. Gylstorff" <Quirin.Gylstorff@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH] linux-custom: add path to image for arm* kernels < 4.12
Date: Fri, 10 Jan 2020 19:49:45 +0100	[thread overview]
Message-ID: <61f46f4a-0100-0ae1-f855-f3fdbffaf112@siemens.com> (raw)
In-Reply-To: <20200108135706.25834-1-Quirin.Gylstorff@siemens.com>

On 08.01.20 14:57, [ext] Q. Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> ARM/ARM64 Kernel with a version < 4.12 do not contain the path to
> the kernel image in image_name. This was added with commits:
> 152e6744ebfc8fa6cc9fff4ba36271f5f1ba2821 for arm and
> 06995804b5762f016c7a80503406da853a8f3785 for arm64.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>   meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> index 67b7ce3..ac347aa 100644
> --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> @@ -56,7 +56,12 @@ EOF
>   
>   install_image() {
>       install -m 755 -d ${deb_img_dir}/$(dirname ${kimage_path})
> -    cp ${O}/${kimage} ${deb_img_dir}/${kimage_path}
> +    # ARM/ARM64 kernels < 4.12 do not include the path to the kernel
> +    if [ -e ${O}/${kimage} ]; then
> +        cp ${O}/${kimage} ${deb_img_dir}/${kimage_path}
> +    else
> +        cp ${O}/arch/$ARCH/boot/${kimage} ${deb_img_dir}/${kimage_path}
> +    fi

Maybe better expand (i.e. redefine) kimage when ${O}/${kimage} doesn't 
exist, rather than duplicating the copy operation.

Jan

>   
>       # Make sure arm64 kernels are decompressed
>       if [ "${ARCH}" = "arm64" ]; then
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2020-01-10 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 13:57 Q. Gylstorff
2020-01-10 18:49 ` Jan Kiszka [this message]
2020-01-13  9:01   ` Gylstorff Quirin
2020-01-14 15:29   ` [PATCH v2] " Q. Gylstorff
2020-02-07 16:28     ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61f46f4a-0100-0ae1-f855-f3fdbffaf112@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Quirin.Gylstorff@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox