From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6779570958446362624 X-Received: by 2002:a19:e011:: with SMTP id x17mr3107101lfg.59.1578682187285; Fri, 10 Jan 2020 10:49:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:988d:: with SMTP id b13ls869221ljj.6.gmail; Fri, 10 Jan 2020 10:49:46 -0800 (PST) X-Google-Smtp-Source: APXvYqyWqc4alXVvVv9FOSn+MN1EuO534QSj9/ub7zl0Tx+ZsacCL2KcLNZWocHYrZxFvUcw0bPF X-Received: by 2002:a2e:a0d5:: with SMTP id f21mr3628409ljm.106.1578682186390; Fri, 10 Jan 2020 10:49:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578682186; cv=none; d=google.com; s=arc-20160816; b=dsQ36HmsnB2A/rEgx6X+dS7IDdMNRSafiwpw8kFlqGg891AdOJm82d05ufFNBrW/dO 9+Jtyq+QAjZ1RF89dLF6PFJjxQgUlXNbG0FrJ6o0OZx26FyUThAE/Xzh8H8NeSqIVry7 9pqKGzW0iLNNz2gD0G1CMQW8swfAm/DYa/yxVbAoikqRMNZjZoER03TpiL7XU+coFPyR UiHNh1m6fizEEE9OHgKXcfUCMOFv5FXIH5peimUtAu4rkuL6++2S+CsdsFFi064Er+En B0d1gzUv+ONWY/xOiLCC7p6cia7bkGQiFdLNv1IY+XD38gHzb3nfrGewKilY4LjcpWAW hstQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=zSisdYCynSC00/+7tGXg3k2enZAQwhl8GgbZqnqtD6c=; b=sKwkF0NoVbDroO+iiXwNCVrhlBkApCVk6EcKAWqBwERpmb9PR29QrgDBCPWjoIWKOJ QBl+rU98XGBlcaZwidD3l+bHNjI/OJ336UFOE4FnEB4W3VhgWeYzStd92DMR4y1eExBt Onmw0HLAW0m3g5I9QSOmq3SMnWAIMnuHnJkbfQArvtjK2CVg8LoK7kfeXBxRI6svt+I8 LjLtVTXRdAzrADex9bxxKiH53VFuoHw1EEy0LS6m3YoApKq6fWLLX9O36QmXCFZYfFDi z3cX2evogCPDUCWzwVXYh56LINdUsnsGeVjKXkjTI7JVatdRMbas4Qzi20AYOnQ7sfzR NFDQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id o24si163797lji.4.2020.01.10.10.49.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jan 2020 10:49:46 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 00AInjtf000727 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 10 Jan 2020 19:49:45 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 00AInjll031440; Fri, 10 Jan 2020 19:49:45 +0100 Subject: Re: [PATCH] linux-custom: add path to image for arm* kernels < 4.12 To: "[ext] Q. Gylstorff" , isar-users@googlegroups.com References: <20200108135706.25834-1-Quirin.Gylstorff@siemens.com> From: Jan Kiszka Message-ID: <61f46f4a-0100-0ae1-f855-f3fdbffaf112@siemens.com> Date: Fri, 10 Jan 2020 19:49:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20200108135706.25834-1-Quirin.Gylstorff@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: p4BB3n0AWDnb On 08.01.20 14:57, [ext] Q. Gylstorff wrote: > From: Quirin Gylstorff > > ARM/ARM64 Kernel with a version < 4.12 do not contain the path to > the kernel image in image_name. This was added with commits: > 152e6744ebfc8fa6cc9fff4ba36271f5f1ba2821 for arm and > 06995804b5762f016c7a80503406da853a8f3785 for arm64. > > Signed-off-by: Quirin Gylstorff > --- > meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > index 67b7ce3..ac347aa 100644 > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > @@ -56,7 +56,12 @@ EOF > > install_image() { > install -m 755 -d ${deb_img_dir}/$(dirname ${kimage_path}) > - cp ${O}/${kimage} ${deb_img_dir}/${kimage_path} > + # ARM/ARM64 kernels < 4.12 do not include the path to the kernel > + if [ -e ${O}/${kimage} ]; then > + cp ${O}/${kimage} ${deb_img_dir}/${kimage_path} > + else > + cp ${O}/arch/$ARCH/boot/${kimage} ${deb_img_dir}/${kimage_path} > + fi Maybe better expand (i.e. redefine) kimage when ${O}/${kimage} doesn't exist, rather than duplicating the copy operation. Jan > > # Make sure arm64 kernels are decompressed > if [ "${ARCH}" = "arm64" ]; then > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux