public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Kowalsky, Clara" <clara.kowalsky@siemens.com>
Cc: "Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH] dpkg: Remove all dummy packages after sbuild package build
Date: Wed, 4 Feb 2026 14:11:43 +0000	[thread overview]
Message-ID: <62494eca7425551be66ff898268e064264c2ca67.camel@siemens.com> (raw)
In-Reply-To: <20260204124933.456235-1-clara.kowalsky@siemens.com>

On Wed, 2026-02-04 at 13:49 +0100, 'Clara Kowalsky' via isar-users
wrote:
> Since sbuild commit c8fad160b366 ("Use dpkg-buildtree to figure out if
> fakeroot is required")[1], the fakeroot installation is done in a
> separate build step after the build dependencies installation. For
> fakeroot, sbuild creates now a separate dummy package called
> sbuild-build-depends-fakeroot-dummy next to
> sbuild-build-depends-main-dummy.
> This sbuild commit was introduced with sbuild version 0.88.2. While
> Debian bookworm uses 0.85.0, trixie updated to 0.89.3.
> 
> When building packages with Isar on a trixie host (e.g., by using
> kas-isar:5.1) that have Rules-Requires!=no set (so fakeroot is used),
> the fakeroot dummy package was left in the downloads directory, which
> caused an issue when running an offline build afterwards, as the
> do_cache task parses all packages in the downloads directory and
> issued:
> "No section given for 'sbuild-build-depends-fakeroot-dummy', skipping.
> There have been errors!"
> 
> With this change, all dummy packages created by sbuild for the build
> dependencies installation are removed afterwards.

Good catch!

Reviewed-by: Felix Moessbauer <felix.moessbauer@siemens.com>

Felix

> 
> [1] https://salsa.debian.org/debian/sbuild/-/commit/c8fad160b3669967bdd2714f34589ace6b37b4b6
> 
> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
> ---
>  meta/classes-recipe/dpkg.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/dpkg.bbclass b/meta/classes-recipe/dpkg.bbclass
> index 4a3deec2..8bb5adeb 100644
> --- a/meta/classes-recipe/dpkg.bbclass
> +++ b/meta/classes-recipe/dpkg.bbclass
> @@ -120,7 +120,7 @@ dpkg_runbuild() {
>          --chroot-setup-commands="mkdir -p ${deb_dir}" \
>          --chroot-setup-commands="find ${ext_deb_dir} -maxdepth 1 -name '*.deb' -exec ln -t ${deb_dir}/ -sf {} +" \
>          --chroot-setup-commands="apt-get update -o Dir::Etc::SourceList=\"sources.list.d/isar-apt.list\" -o Dir::Etc::SourceParts=\"-\" -o APT::Get::List-Cleanup=\"0\"" \
> -        --finished-build-commands="rm -f ${deb_dir}/sbuild-build-depends-main-dummy_*.deb" \
> +        --finished-build-commands="rm -f ${deb_dir}/sbuild-build-depends-*-dummy_*.deb" \
>          --finished-build-commands="find ${deb_dir} -maxdepth 1 -type f -name '*.deb' -print -exec cp ${CP_FLAGS} -t ${ext_deb_dir}/ {} +" \
>          --finished-build-commands="cp /var/log/dpkg.log ${ext_root}/dpkg_partial.log" \
>          --build-path="" --build-dir=${WORKDIR} --dist="${DEBDISTRONAME}" ${DSC_FILE}
> -- 
> 2.52.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260204124933.456235-1-clara.kowalsky%40siemens.com.

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/62494eca7425551be66ff898268e064264c2ca67.camel%40siemens.com.

      reply	other threads:[~2026-02-04 14:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 12:49 'Clara Kowalsky' via isar-users
2026-02-04 14:11 ` 'MOESSBAUER, Felix' via isar-users [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62494eca7425551be66ff898268e064264c2ca67.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=clara.kowalsky@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox