Re: [PATCH 1/2] rootfs.bbclass: clean blkid cache files from rootfs

[vijai kumar <vijaikumar.kanagarajan@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1370 bytes --]



On Monday, August 7, 2023 at 10:05:21 PM UTC+5:30 
venkat...@toshiba-tsip.com wrote:

From: venkata pyla <venkat...@toshiba-tsip.com> 

Sometimes `blkid` generates cached files `/run/blkid/blkdid.tab*`, these 
cache files are not reproducible and not necessary in the final image, 
so remove them to achieve reproducible builds. 

Signed-off-by: venkata pyla <venkat...@toshiba-tsip.com> 
--- 
meta/classes/rootfs.bbclass | 6 ++++++ 
1 file changed, 6 insertions(+) 

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass 
index 22449d71..5d493ea2 100644 
--- a/meta/classes/rootfs.bbclass 
+++ b/meta/classes/rootfs.bbclass 
@@ -293,6 +293,12 @@ rootfs_export_dpkg_status() { 
'${ROOTFS_DPKGSTATUS_DEPLOY_DIR}'/'${ROOTFS_PACKAGE_SUFFIX}'.dpkg_status 
} 

+ROOTFS_POSTPROCESS_COMMAND += "rootfs_postprocess_clean_blkid_cache" 
+rootfs_postprocess_clean_blkid_cache() { 
+ # blkid generates cache file which are not reproducible 
+ sudo rm -rf "${ROOTFSDIR}/run/blkid/blkid.tab"* 
+} 


If this is a necessary clean up function, can we not move to 
rootfs_finalize? Or maybe adding it to ROOTFS_CLEAN_FILES?

Thanks,
Vijai Kumar K
 

+ 
do_rootfs_postprocess[vardeps] = "${ROOTFS_POSTPROCESS_COMMAND}" 
do_rootfs_postprocess[network] = "${TASK_USE_SUDO}" 
python do_rootfs_postprocess() { 
-- 
2.20.1 



[-- Attachment #1.2: Type: text/html, Size: 1982 bytes --]