From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6664521764891000832 X-Received: by 2002:adf:fb0c:: with SMTP id c12mr2028739wrr.28.1552430207500; Tue, 12 Mar 2019 15:36:47 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:48c:: with SMTP id 134ls547597wme.5.gmail; Tue, 12 Mar 2019 15:36:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1KxBRmH3MN8ecz1RgrJ7qm3wYATIaK4OoOC3VBQZWkLuc6PGCIGo9GmLA5+jqRCOcNQPZ X-Received: by 2002:a1c:c00d:: with SMTP id q13mr5779wmf.5.1552430207062; Tue, 12 Mar 2019 15:36:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552430207; cv=none; d=google.com; s=arc-20160816; b=em0TAmb37Q8WS1rSz+vm3ETQVpSaoVnL6oJSePY6VYyFvD+4KahMORI6z4d7y7PJfp zshPAd9+IsdHF5L5h2079huux9ccCNK6l9nwknsAiJorVTJRL63U1aLoVinYuP2DJXNv xVHiy8eNP1o2Q83Ia55sDP8WMgyrCeABSqOxj0fxAPLf4Z3O8fqIkpIYjQCoL5GkxBiZ xOkzvAtyr2GQQqy04lbU9cJ42ppHRtf44+uPzKVEZbnXd9VJn/O5+DFRQDuvci8qwNCh WeJ79IIiT2TkMqIG/k825GEXj27kWO+xJ+vaXJgZVoI1CuvQIHdaEFF/XJM/qxOwwKjE Bmbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=MOKp43YXTwlf3Jmm7aGcI4jnwdAaNxapWXW+S04kK3I=; b=MWyMPy7YRrPDHwnEv0/vxmyt4/xmf9VYq2qRcXhfz7MLJmUREMt2NjZcGA7NHnHIUZ MnM0bQDGco8+TZlC7eZoHHPKCd+xgYuEGhjXHRPMBzkgX1df21zmWgRP69UfcuybMP5E rtLiaTWDTFS8k7qgrABQGNeMp0ojvUox9HIqAuHxLDL/Cf9CKXilAav1Pc7wnZbh+GnY stY2WVFiDx8FJ1gObAi6AbF4cONNqbAouvB5qVqwEMGijIXqUwfAn7tOyg2YpJ30gLeK QUvT0mVI/NLkpj+Niy3JCSPFgXSlQ1n/7wrfmuKKEqZXOC95sI9jKgGZ09rUWQhq7OPs qL7w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id m1si521240wrj.4.2019.03.12.15.36.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 15:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51a48a80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2CMagh0018679 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2019 23:36:43 +0100 Subject: Re: [PATCH v4 0/6] Python refactoring To: claudius.heine.ext@siemens.com, isar-users@googlegroups.com Cc: Claudius Heine References: <20190304130801.20628-1-claudius.heine.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <634fa0cc-66a0-30b2-8a10-b6b77e15e4fe@ilbers.de> Date: Tue, 12 Mar 2019 23:36:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190304130801.20628-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: wQDkCMv7uuVp On 3/4/19 2:07 PM, claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Hi, > > I just took Haralds patchset + Maxims rebase and fixed it up. > > There was just a tiny change necessary, I added that in an additional patch. > It builds on my machine (qemuamd64) and I am currently testing it on isar-ci. > > If that is successful and review is ok, my patch can be merged into the > 'Remove all uses of subprocess.call(shell=True)' or left separately. Applied to the 'next'. Thanks, Maxim. > regards, > Claudius > > Claudius Heine (1): > isar-bootstrap-helper: get_deb_host_arch: fix decoding > > Harald Seiler (5): > Remove all uses of subprocess.call(shell=True) > Use modern python formatting > image: Remove recursion in get_image_name > wic: Refactor fakeroot script > Fix python style > > .../example-module/example-module.bb | 8 ++- > meta/classes/base.bbclass | 70 ++++++++++++------- > meta/classes/image.bbclass | 22 ++++-- > meta/classes/isar-bootstrap-helper.bbclass | 8 +-- > meta/classes/isar-events.bbclass | 14 ++-- > meta/classes/patch.bbclass | 13 ++-- > meta/classes/wic-img.bbclass | 21 ++++-- > .../isar-bootstrap/isar-bootstrap-host.bb | 9 ++- > .../isar-bootstrap/isar-bootstrap-target.bb | 5 +- > .../isar-bootstrap/isar-bootstrap.inc | 12 ++-- > scripts/wic_fakeroot | 9 +-- > 11 files changed, 120 insertions(+), 71 deletions(-) > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov