Re: [PATCH] isar-bootstrap: debootstrap --include flag to support https:// sources

[Jan Kiszka <jan.kiszka@siemens.com>]

On 05.12.18 13:55, Claudius Heine wrote:
> On 05/12/2018 13.27, [ext] Claudius Heine wrote:
>>>
>>> Now I am completely lost. I suppose there is no need to create the
>>> logic to to differentiate HTTP and HTTPS in ISAR if distro conf will
>>> set the packages. Distro configuration knows whether if it is using
>>> HTTP or HTTPS (or in theory something else) and it should be enough to
>>> define/extend _one_ variable accordingly.
>>
>> I would suggest calling those variables like this:
>>
>> DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales"
>> DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https 
>> ca-certificates"
>>
>> # OVERRIDE = "...:https-support:..." # when you detect that https is needed.
>>
>> or similar. And then use those variables in isar-bootstrap with your logic.
> 
> Maybe I should be a bit more explicit here.
> 
> The distro config does *not* know if somewhere else (some other configuration, 
> file potentially from another layer) adds an additional repository that uses 
> https. Since isar-bootstrap already does some parsing of the source lists and 
> calls debootstrap, it would be the right point to handle that.

Do we really need to model that with overrides? It brings some complexity of its 
own when changing that dynamically.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux