From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631131420328722432 X-Received: by 2002:a1c:dc82:: with SMTP id t124mr2570281wmg.0.1544014727292; Wed, 05 Dec 2018 04:58:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:d9c8:: with SMTP id q191ls3913732wmg.9.canary-gmail; Wed, 05 Dec 2018 04:58:46 -0800 (PST) X-Google-Smtp-Source: AFSGD/WNZLnGvBkCFMqB/B9xxVe8M+c+gkumt/0f8DCnG5v3m/NPBUKw0tzwVYtxih9SAxssB/s5 X-Received: by 2002:a1c:aa47:: with SMTP id t68mr660240wme.6.1544014726794; Wed, 05 Dec 2018 04:58:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544014726; cv=none; d=google.com; s=arc-20160816; b=fRcgh8LEpl277NnOuP9TKMOfVl1LxTCzczGlD95nlYn0rR0JAaZO6DYx3e5YhXnCMg xtv/8w5Cnk3ODlA7QtoVgWAgeTAUJRvJq1uleEoX2l5UgA3wki5o8vKIUpXcuv5/yTMB svvOj5lxpDtRfbjYFD5Nejs8oQ3Ejenf1s9EVmV2OR1RzsIn3/Fw7wBC0OgX1pHVANfE gDDHyOW5zTHz5l26r/6JCnggdg5fEUtJlEsjEUtdr6fmWvUB+GqPx+MGJ0naZuI3q9Wj sjic/oevBPgH2tNml0ukb/WqNQHaJaohyKp9RBVMyQAJPNl7HaxdlOJPIB7OFZnRJe8q U6Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=uP6pPth2+DUJ3GK3+z5qILBDYV+8JAu4LxJGCUN2HDk=; b=dP4iGnFr+ikSLPUVimO0gG6WiOVwwUfqKTC0CW17thA5gLUL4TSUE6NCxuu3UOWnrM cb/uNRquIlDzuECdS9NN1Od2jDPsQrC6/zFWkRfvWfmfvcKKysQv73kLbKIAncaElgQS d1d1YqieGj8dTJfSomGglEIHGg5DapUqhoTnEtAcvyaqLPib52xXd3iFKICIOBtTZO+u O5HW7gExX52FsrMaIL3ofwtZ7yKvp7PX3zWQKI9IRim3eiY7rpk1XiqGjQTbWT3wq2+2 bMXHh0YKkusCarE6+aV/Kb8SzXosOxxOWbzR/mFzaQamxJBRYvCA18iYuyD/UNe2QdeF 25cA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id d6si815196wro.4.2018.12.05.04.58.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 04:58:46 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wB5CwkmX007590 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Dec 2018 13:58:46 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wB5CwjHD030890; Wed, 5 Dec 2018 13:58:45 +0100 Subject: Re: [PATCH] isar-bootstrap: debootstrap --include flag to support https:// sources To: Claudius Heine , =?UTF-8?B?VG9sZ2EgSG/Fn2fDtnI=?= Cc: isar-users@googlegroups.com References: <20181204133544.50621-1-tolga.hosgor@siemens.com> <45323f2d-7dac-9b9d-6382-013b9ae1242c@siemens.com> <66336a00-2604-0915-c341-464aad285715@siemens.com> From: Jan Kiszka Message-ID: <636386f3-7eca-10bd-1ea1-1d5286ce15a9@siemens.com> Date: Wed, 5 Dec 2018 13:58:45 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <66336a00-2604-0915-c341-464aad285715@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 8G28u+ZdMHqG On 05.12.18 13:55, Claudius Heine wrote: > On 05/12/2018 13.27, [ext] Claudius Heine wrote: >>> >>> Now I am completely lost. I suppose there is no need to create the >>> logic to to differentiate HTTP and HTTPS in ISAR if distro conf will >>> set the packages. Distro configuration knows whether if it is using >>> HTTP or HTTPS (or in theory something else) and it should be enough to >>> define/extend _one_ variable accordingly. >> >> I would suggest calling those variables like this: >> >> DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales" >> DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https >> ca-certificates" >> >> # OVERRIDE = "...:https-support:..." # when you detect that https is needed. >> >> or similar. And then use those variables in isar-bootstrap with your logic. > > Maybe I should be a bit more explicit here. > > The distro config does *not* know if somewhere else (some other configuration, > file potentially from another layer) adds an additional repository that uses > https. Since isar-bootstrap already does some parsing of the source lists and > calls debootstrap, it would be the right point to handle that. Do we really need to model that with overrides? It brings some complexity of its own when changing that dynamically. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux