From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 27 Aug 2024 17:48:38 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f64.google.com (mail-wm1-f64.google.com [209.85.128.64]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 47RFmcQC023962 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Aug 2024 17:48:38 +0200 Received: by mail-wm1-f64.google.com with SMTP id 5b1f17b1804b1-428207daff2sf51853645e9.0 for ; Tue, 27 Aug 2024 08:48:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1724773713; cv=pass; d=google.com; s=arc-20240605; b=W5uUYcZDWQ+ir9EJvfLRAfsUxkmKRRhCh9oD1M2eKnS/phOfjLsfSBhx4oOx/esP83 h0Y5iNPkD6ZpBdauR6G6FfsjVpHD0qnWpkZDFDb44iTG2yv/bAfJO/71kcEC2sC1qk1/ YNIFatPDqFIQJjDc+77MSZFK9LVAkTdgGbyWmpXHZ2N36S1qv+5buPcL4eCOF5azxP5B rKoMgWzveLKyQsjESWbUgZGDBTC5i5mcqwKuCoqDAtB6J806lEbhpGalpN0zJJM8ioes kYoxcare3uRH4SFKkaeFjEV0iuPTvNsbeeBERbiwIJYQP+Ljnz1janDW0QBKPJzP6lQV qqfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:to :from:subject:message-id:sender:dkim-signature; bh=MtW+92AhIvLZiPwRc/UYWdpyVgdEbuG3SIuoaIhAKY0=; fh=eVGJoRswouvFRKGlm8Eg3Np2gsSkdfyX4AOvffOQyd4=; b=d40sWZqc95+7QbKCIESWYZz2lbH707zUJENWJIPOFEsw5cKb7/PzTi9sVSROlK4FpM zkWUHJ9Pf8VdIApEdIqMCxamd9lKkvw2w9JOgPUNbycdMJRjitFOJ4ovh35BETwypQu1 5TgFZskxKuuQKR3lZ4y8iJCf9r8Bit94dpJnBYl9pVZiOlcXk0R7e+CF0LVoDSU41iF7 4eup3g7UgOLT+/AXiHUHYZbxHSuWKEqiHZi4EIkjy2WFSFutC29ckl6RuSgmmEp7+JC6 v+tbxJkxDLvWGyKZmgfitc20FsoP6gMFnVBqElLh3NSjwP4aAsc3dclKj3Lcsx7/1byJ AsCg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1724773713; x=1725378513; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=MtW+92AhIvLZiPwRc/UYWdpyVgdEbuG3SIuoaIhAKY0=; b=kQVK9k/a4mbJxpSdWOODr8MStmLbqtmEW7Vdx1uJDT42fdV0iHz44zbtDpcsdu3pqf VJAHMVteB3vPQuK1LC3AOd7o3je0PJ5MXS5R6vkATf2KNZIoh/ejk180Hry9IAGsF11Z +eA2qv3LZqEnhBQPInt05urx/RiSG0YvLUBKMIpOe1J9OomqbEfIy5ArttjOjA7xWXw9 6KELFsARqbbfNgf5UEDFfnaXaWjG6hqbraSLfjvirhH1g9CX9Ptd9cu1ZQRHX3x7XvoA ygqHutj/aruba66S9ThMOX0U/YItPvITiR6wdUdvtqqGoxipMXaRCrQ1Kt0H2xG5Gfiw 4MOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724773713; x=1725378513; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=MtW+92AhIvLZiPwRc/UYWdpyVgdEbuG3SIuoaIhAKY0=; b=NBWPWBLmRKhIvpRuB+VVgQvg4RWMrsuc+MKJGHNNX24hlvk0GEaEQ3+HhC9N7Ty+eu 0R51gJcfNylcoy+u5mINtad5Z6yk2nLIDSS6gYG90/UJpwrc0/o9TVVr8YjCkBv/j/wM AVvUNriG/ltLkBVaofYADJ2bI1faE4Wuzg5fZmxTqdEgKuuL2B8RVYO3OfR8c2VtUILO Cu4ONk0tTMLNHQmByFQEXkSLU6SScOxWAvfBzwRarP1/6SjafbTMMLwjiI5BInlMvsLe mWDRRXNL3PNzXM9d8vwyzwQwUWlJWCUfbdhaRvlvtXFkyjGtHJkOpAujzNaGssxidFIr dGOA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVAjegMUp9ZybDVuOIhGbK5PkwpAH3Btpp8UKphXjhRBd8YQKqwufN+QAjWlRCV+sIVJpi5@ilbers.de X-Gm-Message-State: AOJu0Yyk6qiznVXd+QWJlPCG4kyf4lbEV8nNHirAEILjnLpdf2eKFQbF RLufenQE39lrqEvnIbewNCmupHxGRlo+VfSGbvwqkatahw+K5aw+ X-Google-Smtp-Source: AGHT+IGH7E6QBZga5MMnvOaFd9OYg8sxy1gbHioGmQrnDse//ICLYHZSZ7SBFoKBVfGvGOg8UBM4MQ== X-Received: by 2002:a05:600c:1908:b0:429:994:41ae with SMTP id 5b1f17b1804b1-42acd6164e6mr89512665e9.2.1724773712158; Tue, 27 Aug 2024 08:48:32 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1385:b0:426:6c3e:18fc with SMTP id 5b1f17b1804b1-42ac3df9580ls10815855e9.2.-pod-prod-04-eu; Tue, 27 Aug 2024 08:48:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWaJQ6KGsvt7terHgtyERfi666VLwTmyF7KRTBEGnrroQCwD9PiT5QNTYfW+JLoxLCeTTYLlXfMu+fx@googlegroups.com X-Received: by 2002:a05:600c:1d0b:b0:426:593c:9351 with SMTP id 5b1f17b1804b1-42acd542a3cmr89295915e9.6.1724773709856; Tue, 27 Aug 2024 08:48:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724773709; cv=none; d=google.com; s=arc-20160816; b=Dw9VWefl+J3dbWwL65VI9ziw5Xdch57FyWSenMjyaT0khLJ3Y67T60bjwk8PSflFJM /grrb4Lx+h7ULkbhQEGDZcPyutWKGGwhh5cKuOlDsWJ/f0exg/RjKSZdRZlPApK2oaKq JxfqjPiahsmz86a0oEf9CJSQcDHWTLyPbH+j3azMKXCwFnIjPm1ansJlnNVlGJ19kxbi 7MtDDCsCOA9lSdIMPIl71/8Aklx1Ehprn0qZ4LDy1jacGtyN2ufDQT7umOm7+Lwkb3Z1 88CI6EYX8juMY9sAP55/Ynfbs2r19rIjPF7tueF5CnxWRLQJqRi1uGPUo7o+oHpFozmR A/Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id; bh=k8GyiY12X0stngAJDv9gymiSSn5qBaWV40BSieTFnJg=; fh=1x/T85rXr8yhgzXWAa7zssXnuyt2jGlhJYPIGFWr6UE=; b=w3RghgXolMqYxSD2vK/MZK+BPKObDFIO7XWEQGOlzMe965wMGa5X2laeDbBlATNie7 b1HOBEFNB4hYKuHOdJFpSjzrfc+4hkS66PEo8qhYs8prjw/mhSen2fU9/640FY7FzYqR F3EhRhEzxlLV2MGtMLQfFo8MFqoXRG507nxkZe+wM5vlV4XdD+knG9EOGeYQdi45SKHV etNJidwekEsg3KsI1ddLUjL+oyAuzxfyKPdXh119dbEeIqMb+M8lq5eyfcC3vmXw4Zej 3Khtmf+UFziReLSSValkArCOlgjsybXfjG1Thc4qb8zdWEqRj4p6siNrKxE4wOTLbpfy ED3g==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id ffacd0b85a97d-37307c08871si273393f8f.0.2024.08.27.08.48.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Aug 2024 08:48:29 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 47RFmRhl023954 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2024 17:48:28 +0200 Message-ID: <639bbafa9073996114e4deb16ac59926b314df28.camel@ilbers.de> Subject: Re: [PATCH] linux-custom: support vendor directories via HEADERS_INSTALL_EXTRA From: Uladzimir Bely To: Cedric Hombourger , isar-users@googlegroups.com Date: Tue, 27 Aug 2024 18:48:26 +0300 In-Reply-To: <20240810215838.2098472-1-cedric.hombourger@siemens.com> References: <20240810215838.2098472-1-cedric.hombourger@siemens.com> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: xYX73DlrSNF/ On Sat, 2024-08-10 at 23:58 +0200, 'Cedric Hombourger' via isar-users wrote: > Some vendor kernels come with additional directories to be included > in the > linux-headers package in order to support building of their out-of- > tree > drivers. HEADERS_INSTALL_EXTRA may be set to a list of directories > relative > to ${S} in any kernel recipes that includes linux-custom.inc >=20 > Signed-off-by: Cedric Hombourger > --- > =C2=A0RECIPE-API-CHANGELOG.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 12 > ++++++++++++ > =C2=A0.../linux/files/debian/isar/install.tmpl=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 ++++++ > =C2=A0meta/recipes-kernel/linux/linux-custom.inc=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 12 > ++++++++++++ > =C2=A03 files changed, 30 insertions(+) >=20 > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 65cd98b3..21c558d2 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -634,3 +634,15 @@ into kernel kbuild package. > =C2=A0 > =C2=A0When downloading from debian snapshot mirrors, rate limits might > apply. > =C2=A0To limit the amount of parallel fetching to n kB / s, you can set > `ISAR_APT_DL_LIMIT=3D"`. > + > +### Custom directories in vendor kernels > + > +Some vendor kernels come with additional directories to be included > in the > +linux-headers package in order to support building of their out-of- > tree > +drivers. `HEADERS_INSTALL_EXTRA` may be set to a list of directories > relative > +to ${S} in any kernel recipes that includes `linux-custom.inc`. A > l4t kernel > +recipe would use the following setting: > + > +``` > +HEADERS_INSTALL_EXTRA +=3D "nvidia" > +``` > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > index 00011517..0a7bdd66 100644 > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > @@ -193,6 +193,12 @@ kernel_headers() { > =C2=A0=C2=A0=C2=A0=C2=A0 (cd ${S}; find arch/${ARCH} -name module.lds -o = -name > Kbuild.platforms -o -name Platform) >>${src_hdr_files} > =C2=A0=C2=A0=C2=A0=C2=A0 (cd ${S}; find $(find arch/${ARCH} -name include= -o -name > scripts -type d) -type f) >>${src_hdr_files} > =C2=A0 > +=C2=A0=C2=A0=C2=A0 if [ -n "${HEADERS_INSTALL_EXTRA}" ]; then > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for d in ${HEADERS_INSTALL_EX= TRA}; do > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (cd $= {S}; find ${d} -type f) >>${src_hdr_files} > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 done > +=C2=A0=C2=A0=C2=A0 fi > + > =C2=A0=C2=A0=C2=A0=C2=A0 if [ -n "${CONFIG_MODULES}" ]; then > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 echo Module.symvers >> $= {obj_hdr_files} > =C2=A0=C2=A0=C2=A0=C2=A0 fi > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > b/meta/recipes-kernel/linux/linux-custom.inc > index 6aa70fd3..7e312b75 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -48,6 +48,8 @@ LINUX_VERSION_EXTENSION ?=3D "" > =C2=A0 > =C2=A0KERNEL_DEFCONFIG ??=3D "" > =C2=A0 > +HEADERS_INSTALL_EXTRA ??=3D "" > + > =C2=A0# Add our template meta-data to the sources > =C2=A0FILESPATH:append :=3D ":${FILE_DIRNAME}/files" > =C2=A0SRC_URI +=3D "file://debian" > @@ -84,6 +86,7 @@ TEMPLATE_VARS +=3D "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > =C2=A0=C2=A0=C2=A0=C2=A0 KAFLAGS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 \ > =C2=A0=C2=A0=C2=A0=C2=A0 DISTRIBUTOR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > =C2=A0=C2=A0=C2=A0=C2=A0 KERNEL_EXTRA_BUILDARGS=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 \ > +=C2=A0=C2=A0=C2=A0 HEADERS_INSTALL_EXTRA=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 \ > =C2=A0" > =C2=A0 > =C2=A0inherit dpkg > @@ -224,6 +227,15 @@ do_prepare_build:prepend() { > =C2=A0 > =C2=A0 # produce a changelog for our kernel build > =C2=A0 deb_add_changelog > + > + # make sure user-specified directories do exist in ${S} > + if [ -n "${HEADERS_INSTALL_EXTRA}" ]; then > + for d in ${HEADERS_INSTALL_EXTRA}; do > + [ -d ${S}/${d} ] || { > + bbfatal "HEADERS_INSTALL_EXTRA: > '${d}' not found in \${S}!" > + } > + done > + fi > =C2=A0} > =C2=A0 > =C2=A0# build directory for our "full" kernel build > --=20 > 2.39.2 >=20 Hello all. The patch is checked in CI and it passes OK, but it's still not clear from a discussion if it's worth applying. Or should this new feature leave on a downstrem side? --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/639bbafa9073996114e4deb16ac59926b314df28.camel%40ilbers.de.