public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 3/3] configscript: remove duplicates of 'dpkg --configure'
Date: Mon,  9 Oct 2017 16:59:42 +0200	[thread overview]
Message-ID: <63f76bb31afe1909da28020e6f258302546afd84.1507561035.git.henning.schild@siemens.com> (raw)
In-Reply-To: <cover.1507561035.git.henning.schild@siemens.com>
In-Reply-To: <cover.1507561035.git.henning.schild@siemens.com>

The command was always run twice, once without a mounted /proc. Now that
/proc is always mounted, once is enough.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 meta-isar/recipes-core/images/files/debian-configscript.sh   | 1 -
 meta-isar/recipes-core/images/files/raspbian-configscript.sh | 1 -
 meta/recipes-devtools/buildchroot/files/configscript.sh      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/meta-isar/recipes-core/images/files/debian-configscript.sh b/meta-isar/recipes-core/images/files/debian-configscript.sh
index 974ad44..7303598 100644
--- a/meta-isar/recipes-core/images/files/debian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/debian-configscript.sh
@@ -45,7 +45,6 @@ export LC_ALL=C LANGUAGE=C LANG=C
 
 # Configuring packages
 dpkg --configure -a
-dpkg --configure -a
 
 # set the root password if that has not been done before
 grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
diff --git a/meta-isar/recipes-core/images/files/raspbian-configscript.sh b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
index 2f5ad40..4cb004b 100644
--- a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
@@ -49,7 +49,6 @@ rm /var/lib/dpkg/info/raspberrypi-bootloader-nokernel.postinst
 
 # Configuring packages
 dpkg --configure -a
-dpkg --configure -a
 
 # set the root password if that has not been done before
 grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
diff --git a/meta/recipes-devtools/buildchroot/files/configscript.sh b/meta/recipes-devtools/buildchroot/files/configscript.sh
index 96166e0..9813c9a 100644
--- a/meta/recipes-devtools/buildchroot/files/configscript.sh
+++ b/meta/recipes-devtools/buildchroot/files/configscript.sh
@@ -44,6 +44,5 @@ mount -t devtmpfs -o mode=0755,nosuid devtmpfs /dev
 
 #configuring packages
 dpkg --configure -a
-dpkg --configure -a
 apt-get update
 umount /dev
-- 
2.13.6


  parent reply	other threads:[~2017-10-09 14:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 14:59 [PATCH 0/3] a few changes small changes Henning Schild
2017-10-09 14:59 ` [PATCH 1/3] image: set the root password conditionally Henning Schild
2017-10-18  9:58   ` [PATCHv2] " Henning Schild
2017-10-19 12:18     ` [PATCHv3] " Henning Schild
2017-10-19 19:36       ` Alexander Smirnov
2017-10-09 14:59 ` [PATCH 2/3] meta-isar: images: mount /proc around multistrap and configscript Henning Schild
2017-10-09 14:59 ` Henning Schild [this message]
2017-10-16 18:47 ` [PATCH 0/3] a few changes small changes Alexander Smirnov
2017-10-18 11:11 ` Alexander Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63f76bb31afe1909da28020e6f258302546afd84.1507561035.git.henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox