From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:a05:600c:4ec8:: with SMTP id g8mr7487004wmq.34.1629303889068; Wed, 18 Aug 2021 09:24:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:5383:: with SMTP id d3ls875112wrv.2.gmail; Wed, 18 Aug 2021 09:24:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWPOJ6demeB93f+WLF85yyAZIW0dSyJJrtFY8gB40Z/9QpfR8UR7lGa67CEYldk6ZbWMMH X-Received: by 2002:adf:ded1:: with SMTP id i17mr11439438wrn.303.1629303888030; Wed, 18 Aug 2021 09:24:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629303888; cv=none; d=google.com; s=arc-20160816; b=BqMsI8RcUQNEZDmz/Ap7hACDg7/5MHTB9AOCB519zsB+iKiSOppkFh53aWOcujrBCM mkayopZhTKGTkDqYjkwLk+OqDcIt6Ac4/piBu3nGxuQwWoqsFSH4ggofzchxS5RewQPA n2rh80wYdYYp91HrNlzJvCUQPUJczrYDcQHjYoMXn7KdptbPgYFxAQVAa6D2CxXQ95XB XzFJqhH3rtsFKx/K0MEr2Yr6VdsaQL3SByL9FInWbBrTDSQhuLRpFIeqJZ2N47QMldjL g7dOzVBh6Odf5FcR4DxKnabhJ9TJSPSaub9slokBkMaB4u9vG6Gkj32h5+Av3HYZfi5U SbIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=V3Pn+xiZz2cvncbk3nAa48Y0/Qo9hKQqmYCsKoGU56w=; b=lzkazPfMVf7k6dHzYVTef+6OGETzixTcMmAB1WabKXasd1HwFM/h/TEhtXjEDchIx5 79J6eqDrUWLANBARNqxImAzvE7RCTP0dUVCh9xtHoVwKsgyQl5x/pIkBs+btHTYLzMTG +hdqQNVDWQKqI3ISM09qDo/T8ZtEk3BcdJXEnc11B4kVqTxwX/exqqjiUMrrrzpgGEJl jFTifE1PHpSM0sGDum0TBbHl1kyqXK/MhT4FDXPwv9dDwVEm3BTAIvICSHyHe2/58wJg i8RyQWJ4/iPhjDiW/snSxWJnJ2s6Gglz6rd8O6PM5sQo6nj7GzzPjy4FGXxhzJHiqKpm 8RcQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id s130si311002wme.0.2021.08.18.09.24.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Aug 2021 09:24:48 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 17IGOlkb008606 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Aug 2021 18:24:47 +0200 Received: from [167.87.0.29] ([167.87.0.29]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 17IGOkjc027994; Wed, 18 Aug 2021 18:24:47 +0200 Subject: Re: [PATCH v5 0/5] Restore downstream mounts compatibility To: Anton Mikanovich , isar-users@googlegroups.com References: <20210817123808.3563834-1-amikan@ilbers.de> From: Jan Kiszka Message-ID: <641cb94c-e2f2-0beb-9c94-7b8073313aef@siemens.com> Date: Wed, 18 Aug 2021 18:24:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210817123808.3563834-1-amikan@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 5a+WDvw+yUc0 On 17.08.21 14:38, Anton Mikanovich wrote: > Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has broken > compatibility with downstream projects. Move try-finally from > dpkg_runbuild(), etc. to the caller, do_dpkg_build(). > > Also enable reference counting for image mounts for several image tasks > running in parallel (like e.g. ubi-ubifs-img). > > Tested with kas-iot2050-example project from: > https://github.com/siemens/meta-iot2050 > > --- > Changes sinse v4: > - Fix while loop counts. > - Move unmount warnings under debug. > Changes since v3: > - Warn on first entering in umount while loop. > - Do not warn on left mounts by default. > - Remote incorrect dpkg unmount usage protection. > - Rebase on next. > - Improve commit messages. > Changes since v2: > - Remove incorrect buildchroot/rootfs mount/unmount usage protection. > - Remove task fail handler. > - Implement double mount protection by try-finally. > Changes since v1: > - Get back while loop in dpkg_undo_mounts. > - Exit dpkg_undo_mounts if already mounted. > - Do not ignore exceptions in safe_exec. > > Anton Mikanovich (5): > Revert "dpkg: Make mount buildroot reliable" > dpkg: Limit unmount loop > image: Add reference counter > dpkg-base: Clean up unmounting in do_dpkg_build() > events: Do not warn on left mounts by default > > meta/classes/dpkg-base.bbclass | 125 +++++++++++++------------------ > meta/classes/dpkg-gbp.bbclass | 8 +- > meta/classes/dpkg.bbclass | 14 +--- > meta/classes/image.bbclass | 39 +++++++++- > meta/classes/isar-events.bbclass | 2 +- > 5 files changed, 97 insertions(+), 91 deletions(-) > I've pushed that to our CI as well, and if that runs fine, I can give a try in one or two downstream layers (which are not on any mount change so far). But from reading things, it looks good and fairly consistent now. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux