From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6499458059831607296 X-Received: by 10.28.15.145 with SMTP id 139mr3195549wmp.27.1517410597854; Wed, 31 Jan 2018 06:56:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.165.85 with SMTP id j21ls1677648wrb.12.gmail; Wed, 31 Jan 2018 06:56:37 -0800 (PST) X-Google-Smtp-Source: AH8x224iR2uurxzpK2dbOpAnee+pNL5Uq5g4EQeK437S/9UTxXhFkZEIeJ6WuWZRblOlKzEIV+sx X-Received: by 10.28.22.207 with SMTP id 198mr197565wmw.20.1517410597311; Wed, 31 Jan 2018 06:56:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517410597; cv=none; d=google.com; s=arc-20160816; b=VRbvl20JpTiFoSAd0qv3gLCOUqj3AdH/DzTfkzFMtEBcwn9xa2VJh5UgThDe0mFE0Y TaKHPqcmhFkryGaRkqJpfg1I1wvYZx36ljA3hbaL8mhaEHpk33tltTHgDgTIol40DGKs rujtchAXQmYVZB9lYlNT31a4sS7T1eMthAQxeryah/xz23DBcxoEuo0nILg+671/EBuS gsPGpZze+FVhgfNuec4nEBOGGOAbcaKA1QACKTGIgiA5cshop10lgpmnqt3Am8VMHsDX yivWwKzwV3vdJy7KaMHjJdQdXN61HUtMO/aLxnZfZF8NmdltRIuiHWb5Eux6+m4BEWJE 0kcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=NUjk6Mz2YduW8brUqIHRfdHnTvKPIQ/2jI/udA5qP+g=; b=NKuBeLLl5/SLHaKHuPo782+uj1UKNXHzQCwrIHoT7VY7HwUnwQfrXKyhdE0k3SpvNq PqA9a2Ti5G7/Nfsugfi4hgi2sIwvg2fxFzfPpc66KGIT7mNai3Xgbwovukn+/PBTkDim bfIVjU+brZBpRBdGhaexooO9dgvDMkbf8CvZ0wOcvuZ2N1YMXh4uH61uddv/NTmlgJ94 FoLc04MBkS8Fj4K+XQpygZbKUOa5VOar8FTKY/4lwKjUajnXGrUjDpXdh6HMhRZ/8xwB DBV1H5NmAQLYGt4N8lP/cOqIUIcu9wnszfdAytZLECJcumdUECdAqF0hv04T/oQXJUj/ YiTg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id s5si1189984wra.3.2018.01.31.06.56.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 06:56:37 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w0VEuaha010411 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jan 2018 15:56:37 +0100 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w0VEuaji024485; Wed, 31 Jan 2018 15:56:36 +0100 Subject: Re: [PATCH] dpkg-raw: take unmodified DEBIAN_DEPENDS for the package To: Alexander Smirnov , Henning Schild , isar-users@googlegroups.com Cc: Christian Storm References: <20171214173634.29877-1-henning.schild@siemens.com> <4991ec01-e369-f30f-14bd-ba14807881e1@ilbers.de> From: Claudius Heine Message-ID: <65ac4abd-eef1-bd6a-1cab-63bd1476e50a@siemens.com> Date: Wed, 31 Jan 2018 15:56:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4991ec01-e369-f30f-14bd-ba14807881e1@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 9+HbxxF+ZLrQ Hi, On 01/11/2018 12:42 PM, Alexander Smirnov wrote: > On 12/14/2017 08:36 PM, Henning Schild wrote: >> To express advanced debian dependencies version numbers in brackets and >> other constructs are allowed. In such cases you would also have spaces >> in DEBIAN_DEPENDS which can not just get replaced with commas. Doing >> that will create invalid "Depends:"-lines. >> >> This patch just takes the string as found in the recipe. This way users >> can express whatever they need and Isar does not need to know anything >> about the semantics or syntax of that string. >> >> This change means that anyone using dpkg-raw will have to comma-separate >> their DEBIAN_DEPENDS. The change breaks backwards compatibility but >> simplifies things and hopefully prevents further problems in that space. >> > > Applied to next, thanks! > I am now trying to convert my 'DEBIAN_DEPENDS' to the new format and I found some issues doing it that way. For instance if you are adding DEBAIN_DEPENDS inside a bbclass like this: DEBIAN_DEPENDS += " \ jq, \ iptables, \ " This results to the following entry in control file: Depends: jq, iptables, dpkg-deb does not seems to be happy with this. That means that this patch in comparison the the one I submitted has also the disadvantage of enforcing a less readable format in the recipe file and expects special handling of the last ','. So in the end, the complexity that we save here has to be spend somewhere else. Cheers, Claudius P.S.: My proposed patch needs a small change to handle tab characters additional to spaces though. -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de