public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Zhihang Wei <wzh@ilbers.de>
To: Clara Kowalsky <clara.kowalsky@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH] isar-events: close /proc/mounts after cleanup
Date: Thu, 19 Nov 2026 18:02:53 +0100	[thread overview]
Message-ID: <65d3c5c0-2975-43a8-b145-dc16f6bcc12b@ilbers.de> (raw)
In-Reply-To: <20261111144025.2516053-1-clara.kowalsky@siemens.com>

Applied to next, thanks.

Zhihang

On 11/11/26 15:40, 'Clara Kowalsky' via isar-users wrote:
> When running a Python unittest that exercises the BuildCompleted
> handler, a warning is emitted:
>
> /isar/meta/classes-global/isar-events.bbclass:65:
>    ResourceWarning: unclosed file <_io.TextIOWrapper name='/proc/mounts'
>    mode='r' encoding='UTF-8'>
>
> The BuildCompleted handler reads /proc/mounts using open() without
> closing the file. Fix this by reading the mount entries within a
> context manager for deterministic file closure.
>
> Fixes: e596cdf97198 ("isar-events: Unhide mounts left behind")
> Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
> ---
>   meta/classes-global/isar-events.bbclass | 37 +++++++++++++------------
>   1 file changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/meta/classes-global/isar-events.bbclass b/meta/classes-global/isar-events.bbclass
> index 15bfdb99..1427bf64 100644
> --- a/meta/classes-global/isar-events.bbclass
> +++ b/meta/classes-global/isar-events.bbclass
> @@ -65,24 +65,25 @@ python build_completed() {
>   
>       basepath = tmpdir + '/work/'
>   
> -    for line in reversed(list(open('/proc/mounts'))):
> -        if basepath not in line:
> -            continue
> -        msg_line = f"{line.split()[1]} left mounted"
> -        # If bitbake is started manually, bb.warn and bb.error go to stdout;
> -        # with bb.error, bitbake additionally fails the build. Under CI,
> -        # bb.warn and bb.error currently go to a file.
> -        if fail_on_cleanup:
> -            bb.error(msg_line)
> -        else:
> -            msg_line += ', unmounting...'
> -            bb.warn(msg_line)
> -            try:
> -                subprocess.run(
> -                    f"sudo umount {line.split()[1]}", shell=True, check=True
> -                )
> -            except subprocess.CalledProcessError as e:
> -                bb.error(str(e))
> +    with open('/proc/mounts') as mounts:
> +        for line in reversed(mounts.readlines()):
> +            if basepath not in line:
> +                continue
> +            msg_line = f"{line.split()[1]} left mounted"
> +            # If bitbake is started manually, bb.warn and bb.error go to stdout;
> +            # with bb.error, bitbake additionally fails the build. Under CI,
> +            # bb.warn and bb.error currently go to a file.
> +            if fail_on_cleanup:
> +                bb.error(msg_line)
> +            else:
> +                msg_line += ', unmounting...'
> +                bb.warn(msg_line)
> +                try:
> +                    subprocess.run(
> +                        f"sudo umount {line.split()[1]}", shell=True, check=True
> +                    )
> +                except subprocess.CalledProcessError as e:
> +                    bb.error(str(e))
>   
>       # Cleanup build UUID, the next bitbake run will generate new one
>       bb.persist_data.persist('BB_ISAR_UUID_DATA', d).clear()

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/65d3c5c0-2975-43a8-b145-dc16f6bcc12b%40ilbers.de.

      reply	other threads:[~2026-11-19 17:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 14:40 'Clara Kowalsky' via isar-users
2026-11-19 17:02 ` Zhihang Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65d3c5c0-2975-43a8-b145-dc16f6bcc12b@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=clara.kowalsky@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox