From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 04 Oct 2024 11:44:11 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pj1-f57.google.com (mail-pj1-f57.google.com [209.85.216.57]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 4949i9Tu030275 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 4 Oct 2024 11:44:10 +0200 Received: by mail-pj1-f57.google.com with SMTP id 98e67ed59e1d1-2e18d5b9a25sf2515867a91.2 for ; Fri, 04 Oct 2024 02:44:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1728035043; cv=pass; d=google.com; s=arc-20240605; b=JpQh6dK+uLHk+/IXRAZaXraF9D98fYWZPFt8Zd+HVUlEg0ODsGQMccHH/dk3rCEOsC dyQSmvufJt9kPbYmIrAFvndb00kGSPs3B0YiQClewkmit35z8xX4V1gdBWDlvK7PyvaQ MAY1sQuoKJB4yPFk97hs+EKw+AuZRMm9tMLD/zmD1Jaf5CJxbdP+0Acuvjp8wdzXf9AT TzgSN6yAJ59axXpYTP4E+A9MAprGh5eAfsGZ2hEDiDrwT5gM578SgZf0SydZlI3uZ5sP D+nUHqeGnfPv8t1qCk121K3XuqpuTkXDSB9rKCt4yJBqtKNyxi8+sDQZJEAyyYyKfL1L D3gA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:to :from:subject:message-id:sender:dkim-signature; bh=XzYuesS/E2OK3QcN7xGOv+43jiV8NFzMfLlC36GO758=; fh=fCc8VB4gZipRSJ87jHqA+R279mCnAHMqnDtgYqCAbhE=; b=AiAFSP2ZP5DKNjm3/5KEUF3OfpPAa27sdkjMSpV9m6c4ihEmg7m4tvXSRgsW5r7U78 gSmqpkeauS1AxGJ6NYk/rqgSMQF8rITRacYhQfNgYWbQcfGwlc+e5NhzOA2dxF5+jMH2 QiLra7Yqid8KhA3SduFs4U16axRHOaGFgsPfoTZGBfO5E6iwTao5dK7A2MY7adchwUqO bU3ZTwZDqPsuyeekFkiqlHmHW4F3lo9H+xLHNuyFvWGm31X0/Ogeq4dOPdQhZlvhqnyC WO9wyUtLGmw65T1bfHtunL4KqOn2pHd9oawBC7eQYdWMCnPQ5Hrx43QkZpNN2GRxHCJ9 mG+w==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1728035043; x=1728639843; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=XzYuesS/E2OK3QcN7xGOv+43jiV8NFzMfLlC36GO758=; b=GGr45TR4JImNBNaRoj+ASAcXOFkIMqICQIXLJwHAI05kw6fwmFYLM9D/yxuT3JQVSb LvVrgXUK5e6bIbrkz1JXydESdJ0hDiRDOsW9JrBlW3JK+hQkay49jn6HtkiNjIVnbXKX icd/g6q0MJblzA/P6OTpBHocdSsc9vyDLINuCZS2z1QfG2jg2L0sGhKlhmquIsfYSRmd jEnghjHwNXgAVoPkUUmeiQ47C9rXiRvqKAzEU8dE1Y7cX3QcJyiI1PDxOUI5laSuMwOf uSNf1fbaUkqp5f7OOj6CAy/JFhFiH3bP9CpSgMzcSFqV26XYU9zX2s5fQiUkBMv+U4pI tnWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728035043; x=1728639843; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=XzYuesS/E2OK3QcN7xGOv+43jiV8NFzMfLlC36GO758=; b=O7TNVsMP784UUDfRBZyfEWnTd8OgskSolVkPQbqoukI2URY2CFUefjcNd7iyxJeubG kNSEVBMSv118KNqxljrp9lSW8paQCzsDHlPPuCICWu2gTMrX+kJ86/lLZmvAAzgm+c31 VXU6opLMGPoMRqXo/0ntcnVCPuueVHiWvkg6D+VHf+U1aqIAsb86pYFs7o6Y/NFqCAq/ GThuEHleVyh83Wo9+/qZMyAPKB+F77iMFox2vC814OjWBc5wkoi8aDDcbCuJa9xFSpnh bIntnGxlKu8KpyRd4xF4WayEBOl2Pov64y1PkQY2AJi4MhYZN6+D2luMoiXbD+QWN5/T Axmg== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVyTtIveRsfzfWD8ihuexR8+0qFFsWCblkQG8yZ7Uew6dgedjn7wKWReAjS0Z8rddbiAMaT@ilbers.de X-Gm-Message-State: AOJu0YytkWr1GMMWFyzZ25Ut5PlIwsCzWP30YUHbu6oZquA/4OteCLqz 2gDjAxrnFL83t8hbLDqDEUM0rH9WwT7M8Pbtq5UhnQCHZO9AQTDT X-Google-Smtp-Source: AGHT+IE9U9tJip0BQ8dqkzhVcpY6qoxMD6b6OfWain2IH4lEwrjf9xpdmJMgPXWTJFUP5X7cs6u96g== X-Received: by 2002:a17:903:2445:b0:20b:ab4b:544a with SMTP id d9443c01a7336-20bfe49471amr32929965ad.43.1728035043388; Fri, 04 Oct 2024 02:44:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:e812:b0:1f2:eff5:fd69 with SMTP id d9443c01a7336-20be1989e1fls12701905ad.0.-pod-prod-08-us; Fri, 04 Oct 2024 02:44:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVb+NM2bU3kUUOjyrmz6q9myLs2f7Egsdxp9TcFIuJD1FR0wzivSLk1DjNOPdMdIBuOVVE1MQFcyIrH@googlegroups.com X-Received: by 2002:a17:902:ce88:b0:20b:ab74:f567 with SMTP id d9443c01a7336-20bfe01dd1emr35330325ad.27.1728035040339; Fri, 04 Oct 2024 02:44:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728035040; cv=none; d=google.com; s=arc-20240605; b=Ek3kVggLKPXpJLwdExVnrX+TsW2zN60DPSVHps6f+dvEeqsOoKpGdQ52CCT0XRgHbv f9RLihs2pbEN17yZHuzmKMB7vVTjKVsxbQXV90hyuC0k9KynGCpRxtmdO5f/vshzWJA9 23bbQSiPN0yRUA3LHOC5dkfVQaD8PobWbZhXhEvcbsHeOQRN0rxvuE3QnAl/gp4nH3wW CpUyox9XQBIdH1nEyeDYfTpleR+fweXjb3FVOoOEqDNOuRKX9RGmtbCXb3UYHEMRpTqX f3fgykHXTEEgoCWyUoAc3NnZcNI7a45+KxkoSyRZR3KsLAaFkx5g8wGwTDtkXjXbVdqW PIKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id; bh=jUXL3tsZQ12ONJOPhYibKafXqgWukwidfDhxrR2Gm9U=; fh=O+ZMFUiiuyZKsfz7Fw8hsdknZlxcSFSsLsCydBEGD0o=; b=X65G2MLbhQ2gEAZIbARhzd3V46VprnyY0tvNCkIzQl4NeJtgBlC3H+eAZCVOlEc/bB n08BIASwsjss43vxu5Wwi4kdhI334wSpAYr2Fi4Li+wjdvuGIZnJEVFLSDGS1g9Yx0CV A0eKSZKlVLtJg4LlX76X4rImqifpXkqTj1aIw/89zUIbzHKKf/VqMx+r/bNZf5exYnpv gWslWCY50ggAxRKSwO95ZUezxju8aAMu2w5lkygYTRIkArh/D2FlrI8h5ZyAvAeeggl/ UJ8dx3+i0lR51dbAln2unLG7smqZLz/VF3aNrV/tKKk/rEmQezKe8wWOzTqcMZsimgvz MDdw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id d9443c01a7336-20be97d0b5esi1113175ad.6.2024.10.04.02.43.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Oct 2024 02:44:00 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 4949htnQ030268 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 4 Oct 2024 11:43:56 +0200 Message-ID: <65edc6fed0558a7de81638e1d0dec5d1297839e9.camel@ilbers.de> Subject: Re: [PATCH v2] Fix linux-starfive build under sid From: Uladzimir Bely To: Jan Kiszka , isar-users@googlegroups.com Date: Fri, 04 Oct 2024 12:43:55 +0300 In-Reply-To: <475f51bd-d227-405b-a9da-0d2b41a98319@siemens.com> References: <20241004082906.29224-1-ubely@ilbers.de> <475f51bd-d227-405b-a9da-0d2b41a98319@siemens.com> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: mW8MMp46uyBO On Fri, 2024-10-04 at 10:38 +0200, Jan Kiszka wrote: > On 04.10.24 10:17, Uladzimir Bely wrote: > > The patch is taken from the linux kernel upstream >=3D 6.8. > >=20 > > Signed-off-by: Uladzimir Bely > > --- > > =C2=A0...oc-arguments-order-in-btrfs_ioctl_se.patch | 43 > > +++++++++++++++++++ > > =C2=A0.../linux/linux-starfive_6.6-visionfive2.bb=C2=A0=C2=A0 |=C2=A0 1= + > > =C2=A02 files changed, 44 insertions(+) > > =C2=A0create mode 100644 meta-isar/recipes-kernel/linux/files/0001- > > btrfs-fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > >=20 > > Changes since v1 (Fix linux build under sid and trixie): > >=20 > > - Since we don't build linux-mainline/linux-phy kernels for > > trixie/sid > > apply kernel patch only for linux-starfive_6.6-visionfive2 target. > >=20 > > I additionally checked [1] for existing branches and can conclude: > > =C2=A0- recent 6.6-based branch "JH7110_VisionFive2_upstream" is still > > affected and requires the patch > > =C2=A0- recent "starfive-tech/visionfive" is 6.10-based already include= s > > the fix, but using it leads to different build errors. Also, I'm > > not > > sure if it properly supports "VisionFive2" board. > >=20 > > So, for now, the simplest way to fix build error we have in CI is > > to > > just apply upstream patch. > >=20 > > [1] https://github.com/starfive-tech/linux > >=20 > > diff --git a/meta-isar/recipes-kernel/linux/files/0001-btrfs-fix- > > kvcalloc-arguments-order-in-btrfs_ioctl_se.patch b/meta- > > isar/recipes-kernel/linux/files/0001-btrfs-fix-kvcalloc-arguments- > > order-in-btrfs_ioctl_se.patch > > new file mode 100644 > > index 00000000..afe09eab > > --- /dev/null > > +++ b/meta-isar/recipes-kernel/linux/files/0001-btrfs-fix-kvcalloc- > > arguments-order-in-btrfs_ioctl_se.patch > > @@ -0,0 +1,43 @@ > > +From 6ff09b6b8c2fb6b3edda4ffaa173153a40653067 Mon Sep 17 00:00:00 > > 2001 > > +From: Dmitry Antipov > > +Date: Thu, 21 Dec 2023 11:47:45 +0300 > > +Subject: [PATCH] btrfs: fix kvcalloc() arguments order in > > btrfs_ioctl_send() > > + > > +When compiling with gcc version 14.0.0 20231220 (experimental) > > +and W=3D1, I've noticed the following warning: > > + > > +fs/btrfs/send.c: In function 'btrfs_ioctl_send': > > +fs/btrfs/send.c:8208:44: warning: 'kvcalloc' sizes specified with > > 'sizeof' > > +in the earlier argument and not in the later argument [-Wcalloc- > > transposed-args] > > + 8208 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sctx->clone_ro= ots =3D kvcalloc(sizeof(*sctx- > > >clone_roots), > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > > + > > +Since 'n' and 'size' arguments of 'kvcalloc()' are multiplied to > > +calculate the final size, their actual order doesn't affect the > > result > > +and so this is not a bug. But it's still worth to fix it. > > + > > +Signed-off-by: Dmitry Antipov > > +Reviewed-by: David Sterba > > +Signed-off-by: David Sterba > > +--- > > + fs/btrfs/send.c | 4 ++-- > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > + > > +diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > > +index 4e36550618e5..2d7519a6ce72 100644 > > +--- a/fs/btrfs/send.c > > ++++ b/fs/btrfs/send.c > > +@@ -8205,8 +8205,8 @@ long btrfs_ioctl_send(struct inode *inode, > > struct btrfs_ioctl_send_args *arg) > > +=C2=A0 goto out; > > +=C2=A0 } > > +=20 > > +- sctx->clone_roots =3D kvcalloc(sizeof(*sctx->clone_roots), > > +- =C2=A0=C2=A0=C2=A0=C2=A0 arg->clone_sources_count + 1, > > ++ sctx->clone_roots =3D kvcalloc(arg->clone_sources_count + 1, > > ++ =C2=A0=C2=A0=C2=A0=C2=A0 sizeof(*sctx->clone_roots), > > +=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 GFP_KERNEL); > > +=C2=A0 if (!sctx->clone_roots) { > > +=C2=A0 ret =3D -ENOMEM; > > +--=20 > > +2.45.2 > > + > > diff --git a/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb b/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb > > index f4dd5c9a..a267241f 100644 > > --- a/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb > > +++ b/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb > > @@ -8,6 +8,7 @@ require recipes-kernel/linux/linux-custom.inc > > =C2=A0SRC_URI +=3D " \ > > =C2=A0=C2=A0=C2=A0=C2=A0 > > https://github.com/starfive-tech/linux/archive/${SRCREV}.tar.gz;downloa= dfilename=3Dlinux-starfive-${SRCREV}.tar.gz > > =C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 > > file://0001-riscv-efistub-Ensure-GP-relative-addressing-is-not-u.patch > > =C2=A0\ > > +=C2=A0=C2=A0=C2=A0 > > file://0001-btrfs-fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > > =C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 file://starfive2_extra.cfg" > > =C2=A0SRCREV =3D "9fe004eaf1aa5b23bd5d03b4cfe9c3858bd884c4" > > =C2=A0SRC_URI[sha256sum] =3D > > "9eaf7659aa57e2c5b399b7b33076f1376ec43ef343680e0a57e0a2a9bef6c0ae" >=20 > NACK, update the kernel. I think I already told you. May even > obsolete > the other patch. Yes, I tried this (see the text above the diff starts). Updated 6.6- based branch still requires both patches. >=20 > Jan >=20 --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/65edc6fed0558a7de81638e1d0dec5d1297839e9.camel%40ilbers.de.