public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: "Maxim Yu. Osipov" <mosipov@ilbers.de>,
	isar-users <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: Re: [PATCH] dpkg: Beautify runbuild
Date: Mon, 25 Mar 2019 14:40:42 +0100	[thread overview]
Message-ID: <662125e4-f136-45c6-db81-c93638e58578@web.de> (raw)
In-Reply-To: <f454e94b-e9e0-50a7-f3ca-28ea4927fa57@ilbers.de>

On 25.03.19 14:19, Maxim Yu. Osipov wrote:
> On 3/24/19 4:07 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Properly indent so that it becomes clearer that chroot runs under a
>> lock. Also avoid overlong lines.
>
> I've tried to apply the patch against the current 'next' and git am failed:
>
> git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml
> Applying: dpkg: Beautify runbuild
> error: corrupt patch at line 18
> Patch failed at 0001 dpkg: Beautify runbuild
>

Sorry, forgot to disable line wrapping:

---8<---

From: Jan Kiszka <jan.kiszka@siemens.com>

dpkg: Beautify runbuild

Properly indent so that it becomes clearer that chroot runs under a
lock. Also avoid overlong lines.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/dpkg.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index f4e3d7a..997f2f3 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 dpkg_runbuild() {
     E="${@ bb.utils.export_proxies(d)}"
     flock -s "${REPO_ISAR_DIR}/isar.lock" \
-    sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
+        sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
+             /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
 }
--
2.16.4

  reply	other threads:[~2019-03-25 13:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-24 15:07 Jan Kiszka
2019-03-25 13:19 ` Maxim Yu. Osipov
2019-03-25 13:40   ` Jan Kiszka [this message]
2019-03-25 19:07     ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=662125e4-f136-45c6-db81-c93638e58578@web.de \
    --to=jan.kiszka@web.de \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    --cc=mosipov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox