From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6671974161673355264 X-Received: by 2002:a17:906:a291:: with SMTP id i17mr14188483ejz.180.1553521244380; Mon, 25 Mar 2019 06:40:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:8ebb:: with SMTP id w56ls1924709edw.2.gmail; Mon, 25 Mar 2019 06:40:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLzH80wYERKBPpHjeg+h5EZR6fRs8yIZGO5YvUQbpJJH4ZavgJ0lBNPiQpfSupHNIGhQi/ X-Received: by 2002:a50:f9c1:: with SMTP id a1mr15726367edq.278.1553521243912; Mon, 25 Mar 2019 06:40:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553521243; cv=none; d=google.com; s=arc-20160816; b=MZQnj3nFKVeapxiA6w5m+IPkuy+TNCHu0/CEK4unpLsQZNT+WeRiopNuq7J+euCPUr JmDtEE9YIJZWpA1XN2+80+/pIu8FcKrX8+b3LLKxEMehOjFa4PP2MAEBIDGMcTY0MwuJ 7sXQh/8u53WZOdCAaGL6WyFNz8oYx2RwTIJ2FgVMHAhP9R0Ch0sSJ51n12tkkv9xo8Tf 5aQ9MQRi/7RSMZfX+eYfJaCwFG9ZNbQ7kDziF1tESHhK94Wk6poPU6J78nV4THDP6ZLC lXWPpq7dRqe8vbGbN35WB9eVPrqn57vluWeMcpkh97kEvGL8DgtqvdAhDvkm/ZD0+we4 OUxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=Yp8ocAeQkFbejKmkc53MjeJNB32lAu+MlvSmqgRYXCc=; b=hK+tPbkrOKUV6f1IGKR3PU5mkyJWYJ3LSbTep+CGJiHBA9AGbLn0wq+E6TystsxbJl Pp8+UYB9wPfrtzr+bxdqn8BD5z9ZiaW/jDdgl17F6CMR4srrmB5lSGnKtkeEHsrWf6JE 2CAcLi6kqKaI3h9cEQ1MP6cmd6hiXexextm0Nw2FHSGuB1qpJptIQlcQGcmwDIFRh3Nx I0dGFC99G08lpsWUlcbFCVy+D27vOZ5brTI1UCG8JMiNpBeqLH0HqRrshqVWr/pjT9Cg W6XdEtselbh1EiZ4QyyPlAbEedwK8tmtcuyPiHiYkhUsc7qlHlSyRlxftORwUHrQ8rLq NhVA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=XASBTKOX; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.17.11]) by gmr-mx.google.com with ESMTPS id r10si1006910eda.4.2019.03.25.06.40.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 06:40:43 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.17.11 as permitted sender) client-ip=212.227.17.11; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=XASBTKOX; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553521243; bh=5/VslWgnty40FfTPrT1WtfQ/O0P15MFtBqmxCCrB9NI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=XASBTKOXhitrVt5D6HgNRX0yaMCQ1I5VavsQ1SSif8xcjPspDdBUQM2CFEyuzkQql Q8H/HlvErM6HeiQtobBhyrEMRPj8JQB5Cc1NJNw4TjwWChsY5fDjW2cPqPsWbBppcM xAzfzW0Po5Zb26wwh7FbGm85XrMvbPF39zEYqLJo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V5b-1gkoF616mh-00yOq4; Mon, 25 Mar 2019 14:40:43 +0100 Subject: Re: [PATCH] dpkg: Beautify runbuild To: "Maxim Yu. Osipov" , isar-users Cc: Cedric Hombourger References: <75befabe-76f0-7750-a1bf-3c2c3dbd2b22@web.de> From: Jan Kiszka Message-ID: <662125e4-f136-45c6-db81-c93638e58578@web.de> Date: Mon, 25 Mar 2019 14:40:42 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:gmVtFXpk9+XtVJvOz2LH3x78gjq4IfYUZqEjtHQr4zMNXkGVexD 4gR9nPpWbErdiNA02wDw3O9sshgXKdQyDACsoqrsc4hNiJH480vD0Sk+Q64SjaG20iuFZj4 sV8NCy7TwFOreYe0esMC4AUNRLyJvRTcTE1TUc62rGIqCy4sJmS2OlNYe7PHNyXWr8FMsVq YEJaeZe3C9ScuWATgxUdw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FOAAcmhsKBw=:NUuadySe4kwFXit8fqqbrQ hnxA4eSkmqS9LI3Cz0QAyLkUWkcPqvU59W8KkQUDwpBTojDu9qMBaVlwjpQMbdcJ99RPKynZ3 gRSYxMePy9AkigGti289zK9cdmuT2PAcrNLfp3WMqNl+WZ4NLcgXMnGLS7AnBwQo2NIL8gMNH jnt27XZvNZ7fi5iHEG2+OTedlDk9V2SQTct3ytapQkhj9EeBF4ZkLLjOvq5Yw6ZJ+6XfhZ0dW ovm1pEziCeIBFUiZbOdaeZiOvHq3iF+MJPMGyV1kB8dzXhGS+6lTcxbM0BEaSoiBi2ODVDv+P humSGr57yTc7LW5OhI4IMZTNEfntIGHdEKntyq18eO1Z3a4FeNEwRur3qXj4yYAe5mIt32G6o WcNMawC8C5Z4FA5iqo2Z1YuTilmFkOXs4s2NN6kb2XnkWcDDfMRtmT3jqCpfF2Nrqaz0yq4TP o6omrNLbFGf+fKQd5CHTgvIKG9po0/c5NnW+7LeTwYFrMkRFoBbwawm3xLNJ6u2sNATU2Afom 7xY0QlGWAZRCpC1aCnUhoXFePdKbOOpAFaOdq6aneyqOh3/+1FRWb8B1zMNWvQuHAczYzCVdy Ni59zB4d7vW/2RYtadJa8kezr8u3qa04KZGTifoTEE6ZJTaf3O0kCasVaWNZ6oSIrkWfvkqJO OsBsVpRDUFPaDFQJfzUy5sBsDYl7nQKr68Hr6rTk0pdRggZ5VmqdsHiiOl2akWQ4hceb0N2zO Ar3QTd2NVnmIWsbr8vpBkVHEOjVJL14ea/W8saTkltWEs7IYoAGU3hlURH3gEfiC1+XuVAQwm 1nRx2FvvDOH/TvB+Q+7QxONgcc8jsQKNgXAUo8qXHhVIu/gZfqIWJ140cvM3KknZk2DijNp5u grgI6EVkqXjZn61Z3y5UET5Rau+VxLkFn7pcBtG73ZML4TcZcCYbF31SCysu+9INj0MFxTsUT Nt17gKybfHA== X-TUID: 3HovAaQgudzV On 25.03.19 14:19, Maxim Yu. Osipov wrote: > On 3/24/19 4:07 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Properly indent so that it becomes clearer that chroot runs under a >> lock. Also avoid overlong lines. > > I've tried to apply the patch against the current 'next' and git am fail= ed: > > git am ../patches/\[PATCH\]\ dpkg\:\ Beautify\ runbuild.eml > Applying: dpkg: Beautify runbuild > error: corrupt patch at line 18 > Patch failed at 0001 dpkg: Beautify runbuild > Sorry, forgot to disable line wrapping: =2D--8<--- From: Jan Kiszka dpkg: Beautify runbuild Properly indent so that it becomes clearer that chroot runs under a lock. Also avoid overlong lines. Signed-off-by: Jan Kiszka =2D-- meta/classes/dpkg.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index f4e3d7a..997f2f3 100644 =2D-- a/meta/classes/dpkg.bbclass +++ b/meta/classes/dpkg.bbclass @@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] =3D "${DISTRO}-${= DISTRO_ARCH}" dpkg_runbuild() { E=3D"${@ bb.utils.export_proxies(d)}" flock -s "${REPO_ISAR_DIR}/isar.lock" \ - sudo -E chroot --userspec=3D$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} = /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} + sudo -E chroot --userspec=3D$( id -u ):$( id -g ) ${BUILDCHROOT_D= IR} \ + /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} } =2D- 2.16.4