From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631131420328722432 X-Received: by 2002:a5d:4501:: with SMTP id s1mr2873793wrq.3.1544014545857; Wed, 05 Dec 2018 04:55:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:ce03:: with SMTP id m3ls3958466wmc.10.canary-gmail; Wed, 05 Dec 2018 04:55:45 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wlsm1WEFLH6N8B7uCg9fTirfi3dYhGCvH2eGtcL3O65oL2NZx10+Tzfaj9skHsybedk3VI X-Received: by 2002:a1c:8046:: with SMTP id b67mr2629096wmd.22.1544014545474; Wed, 05 Dec 2018 04:55:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544014545; cv=none; d=google.com; s=arc-20160816; b=R0Rnn1Z9uOVepNiBnz+PxuuldSXfvEoiI0mrzfVRqwXp3UAl6xuZvpqLrzzWnYzvgX abL/mzZbA0BUk5mV2kZlf4MCrJNx/awRe3CvcN4+ujWBgzg1vwaqK5Wj2BovkBw/8RPp cvXqqEbVoJtWsw1szIYYSkYZYLfIt11bmPXRXFooLQys+gSIuAx3zO9jIxmb995iO7sY bx8o9Fgg9QGHj081FfN27YwytPUK6dIrBnf52RZfr+pLC5C1JAkQut2ASBg3PPSrIkF+ 8nwEZmNA2J1o6p+QgZpKBNpAChel0gITl3RBAoFW/6kxaPe7vU3guZX7GeTf8/yB7j2Y OPKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject; bh=+Oak5mBpnFtmX/MCE6i+6q/uuCadeTAfJzdZW6KNQ8A=; b=bFOfWY1hcLAPFWMfgVrMIU+neejtxOZD2GSwOouGDpUT806rfECCgkPuwdsMAKzlgc pj0pNWHS9N6qDLnqTCfFnlPEUOQ5roWVvPz/qzaQjab3KnJezklkH32bZE7uaUVkbkXZ Wjq6OP7JbNUnBCKKlH2VcxcUlduZcOzUjYI6TTJhZRBUU4FhndnkSCyCARMxqDAvtA7J ZIvhk3GqZ54/udv6vE6UmOBhvafG3D2h54bDPNsEbYly/j1SPTrCo2PfarMKbaB2coas 3/oltztHCFkVOQe5zKklSVAClyDqxFmMDUyss8HYSpaKGrnXHsk9MOQ2CXakp7MkTsw7 IefA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id h6si499960wmc.2.2018.12.05.04.55.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 04:55:45 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wB5CtiF1000394 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Dec 2018 13:55:44 +0100 Received: from [139.25.69.181] (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wB5CtiY1022986; Wed, 5 Dec 2018 13:55:44 +0100 Subject: Re: [PATCH] isar-bootstrap: debootstrap --include flag to support https:// sources From: Claudius Heine To: =?UTF-8?B?VG9sZ2EgSG/Fn2fDtnI=?= Cc: jan.kiszka@siemens.com, isar-users@googlegroups.com References: <20181204133544.50621-1-tolga.hosgor@siemens.com> <45323f2d-7dac-9b9d-6382-013b9ae1242c@siemens.com> Message-ID: <66336a00-2604-0915-c341-464aad285715@siemens.com> Date: Wed, 5 Dec 2018 13:55:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: bzDztfXjP5Pb On 05/12/2018 13.27, [ext] Claudius Heine wrote: >> >> Now I am completely lost. I suppose there is no need to create the >> logic to to differentiate HTTP and HTTPS in ISAR if distro conf will >> set the packages. Distro configuration knows whether if it is using >> HTTP or HTTPS (or in theory something else) and it should be enough to >> define/extend _one_ variable accordingly. > > I would suggest calling those variables like this: > > DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales" > DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " > apt-transport-https ca-certificates" > > # OVERRIDE = "...:https-support:..." # when you detect that https is > needed. > > or similar. And then use those variables in isar-bootstrap with your logic. Maybe I should be a bit more explicit here. The distro config does *not* know if somewhere else (some other configuration, file potentially from another layer) adds an additional repository that uses https. Since isar-bootstrap already does some parsing of the source lists and calls debootstrap, it would be the right point to handle that. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de