public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Maxim Yu. Osipov" <mosipov@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH v2 2/2] cross-compilation: Fixes build broken with host-distro != target-distro
Date: Wed, 5 Sep 2018 14:48:30 +0200	[thread overview]
Message-ID: <66483d08-1f04-7a39-c88c-7b8e71d61c6f@siemens.com> (raw)
In-Reply-To: <d6955453-67c2-5276-0ef0-e2dbb5ac150d@siemens.com>

On 2018-09-05 10:29, [ext] Jan Kiszka wrote:
> On 2018-09-05 10:16, Maxim Yu. Osipov wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> It's good the see that my workaround is apparently also a solution. But 
> this still lacks the explanation, and I'm still unable to provide that. 
> So please help, specifically by answering the questions I raised in the 
> original bug report.
> 

[...]

>> --- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb
>> +++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb
>> @@ -30,5 +30,5 @@ BUILDCHROOT_PREINSTALL_append_arm64 += 
>> "binutils-aarch64-linux-gnu \
>>                                           crossbuild-essential-arm64"
>> -PARAMS = "--host-arch"
>> +PARAMS = "--host-arch --host-distro"
>>   do_build[depends] = "isar-apt:do_cache_config 
>> isar-bootstrap-host:do_bootstrap"
>>

For this part of the commit, I originally had the following written in 
my queue:

"Because we were not passing --host-distro to setup_root_file_system,
that helper defaulted to the target distro. And that broke the
crossbuild if the target distro differed from the host one."

If you can provide a reasoning for the first half, either in this patch 
or in form of a separate one (I suspect that this will look nicer), I 
would be happy.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

      reply	other threads:[~2018-09-05 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  8:16 [PATCH v2 0/2] Various fixes Maxim Yu. Osipov
2018-09-05  8:16 ` [PATCH v2 1/2] sdk: Move deployment to populate_sdk Maxim Yu. Osipov
2018-09-05  8:16 ` [PATCH v2 2/2] cross-compilation: Fixes build broken with host-distro != target-distro Maxim Yu. Osipov
2018-09-05  8:29   ` Jan Kiszka
2018-09-05 12:48     ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66483d08-1f04-7a39-c88c-7b8e71d61c6f@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=mosipov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox