From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6519842775260725248 X-Received: by 10.80.184.23 with SMTP id j23mr46424ede.3.1518074858108; Wed, 07 Feb 2018 23:27:38 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.185.67 with SMTP id m61ls1921634ede.4.gmail; Wed, 07 Feb 2018 23:27:37 -0800 (PST) X-Google-Smtp-Source: AH8x226ifq/vUm1UNW4ktY/RFW1+t/JHM3ZkyVpQNeSTVvu2WJlxA2Qwa/yixfddlJJ5pWFDnXXI X-Received: by 10.80.141.204 with SMTP id s12mr50080edh.10.1518074857383; Wed, 07 Feb 2018 23:27:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518074857; cv=none; d=google.com; s=arc-20160816; b=JY5BCtwieosZb4aIrDVfivV7p14s+732RSIOalIi1nKMt6TV0iethbtnIP2+CSatmT 6VCUOzzryiWjXUcBubHfSZdZWENBHomf5dvHtNc2dwJEnEkvNezgRiC+545Ko2hqJhjP laIaWDRt0ndYvD/y6pOLilRe1j6za8NEEscOT7dtVOCGex7ukjvKAPyfYd2tJ70ydGla LdcDTNSsX4187EYz5vFdBJVRhCtzT6lDnuro4lWgW1kClV+Ur24wq8Ss2QAObQcW+R8N pCXaAp7WAKuoqC1SdE/51+YNTKXuj2Ua4t6BtLpwPqMGERS1jRyIhQPiJ/IVC4xL3tbi vhDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=G6BLz5aRXyp2SSWVEJ/fg5HRhYOLGGE2nL2cnUhYFR8=; b=dL9LY1+r78fl4lGi4TJCkZkUuH/QT453NvIXyEZXGfwMyzTsaAD1f/Jeilhnmg28/u atU3QUXDMMsom04wttz8LXYZezdl+y86yLcqDNVe+IZ2mHhW78NtCOWv3YTLe+UxnwUQ Jbqy6th+OZr56q/hDMpmOn5k7OKJqrUCmbhVmnUU30FAzz/FilIefZI5GHrpRWI+/h8z +WIs1iF2C4YnL+md7Nlh20Cdzqos7/vpghZmNd0pYMmxljEZrD3nfN7GK1WSVzsPDUOd US/DsYbO5sfO8EhwLXoyYXfBBW/RRzGQDaj9Vde9z2My7Im1ldpX7wItOo/DbzwTNhGx 3RBQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id g45si242646eda.0.2018.02.07.23.27.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2018 23:27:37 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w187RaSE021303 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Feb 2018 08:27:36 +0100 Received: from [167.87.8.40] ([167.87.8.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w187RZHg023142; Thu, 8 Feb 2018 08:27:36 +0100 Subject: Re: [PATCH] Skip over event handler calls with incomplete environment To: Alexander Smirnov , isar-users References: From: Jan Kiszka Message-ID: <6668d588-8a78-d440-35ae-6e5b7ede836d@siemens.com> Date: Thu, 8 Feb 2018 08:27:35 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: lwW5FhEcFp8N On 2018-02-07 17:12, Alexander Smirnov wrote: > On 02/07/2018 06:59 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> The cleanup handler is called a couple of times per shutdown and, >> depending on the setup, some may not have a complete config. Avoid that >> we stumble and fall over any of the environment variables being >> undefined. >> >> Signed-off-by: Jan Kiszka > > Should I apply me previous one? You mean "isar: Clean mount point on bitbake exit"? Besides this issue, I didn't find other problems so far. Jan > > Alex > >> --- >>   meta/classes/isar-events.bbclass | 17 +++++++++-------- >>   1 file changed, 9 insertions(+), 8 deletions(-) >> >> diff --git a/meta/classes/isar-events.bbclass >> b/meta/classes/isar-events.bbclass >> index ae0f791..4b5e97e 100644 >> --- a/meta/classes/isar-events.bbclass >> +++ b/meta/classes/isar-events.bbclass >> @@ -15,15 +15,16 @@ python isar_handler () { >>           distro = d.getVar('DISTRO', True) >>           arch = d.getVar('DISTRO_ARCH', True) >>   -        w = tmpdir + '/work/' + distro + '-' + arch >> +        if tmpdir and distro and arch: >> +            w = tmpdir + '/work/' + distro + '-' + arch >>   -        # '/proc/mounts' contains all the active mounts, so knowing >> 'w' we >> -        # could get the list of mounts for the specific multiconfig and >> -        # clean them. >> -        with open('/proc/mounts', 'rU') as f: >> -            for line in f: >> -                if w in line: >> -                    subprocess.call('sudo umount -f ' + >> line.split()[1], stdout=devnull, stderr=devnull, shell=True) >> +            # '/proc/mounts' contains all the active mounts, so >> knowing 'w' we >> +            # could get the list of mounts for the specific >> multiconfig and >> +            # clean them. >> +            with open('/proc/mounts', 'rU') as f: >> +                for line in f: >> +                    if w in line: >> +                        subprocess.call('sudo umount -f ' + >> line.split()[1], stdout=devnull, stderr=devnull, shell=True) >>         devnull.close() >>   } >> -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux