Re: [PATCH v5 00/12] Sbuild/Schroot migration

[Jan Kiszka <jan.kiszka@siemens.com>]

On 01.02.22 18:00, Uladzimir Bely wrote:
> This is a patchset showing how sbuild/schroot tools can be integrated
> into Isar build system.
> 
> This patchset should be applied on top of "preparation" patchset
> named "Avoid using shell environment during the build".
> 
> Base schroot image is created with sbuild-chroot-target (or
> sbuild-chroot-host in case of cross-build) recipe. These images are based
> on isar-bootstrap ones, but include some build-related stuff preinstalled.
> 
> To use this changes you need to have sbuild and schroot installed and
> configured. Current user should be added to sbuild group.
> 
> If 'kas-container' is used, it should be modified to support sbuild:
> - /var/lib/schroot/union/overlay should be externally mounted (-v option)
> 
> Currently, sbuild-related stuff is supported in kas-isar:next image
> 
> To use the patchset with KAS:
> - export KAS_IMAGE_VERSION=next
> 
> If 'gitlab' is used, the similar changes are required:
> - `next` tag for kas image should be set
> - external dir for schroot overlay should also be specified in
> /etc/gitlab-runner/config.toml:
> volumes = ["/path/to/overlay:/var/lib/schroot/union/overlay"]
> 
> The patchset was tested with 'meta-iot2050' and 'xenomai-images'
> downstreams in combination with kas image mentioned above.
> 
> Current limitations:
> - parallel building of several packages requires more free space in
> comparison with buildchroot-based architecture. This happens due
> the sbuild architecture which uses some basic layer (common for all
> packages) and per-package separate layer (where builddeps are downloaded
> and installed).
> 
> Changes since v4:
> - consider shell exports done in dpkg_runbuild_prepend and pass them
> to sbuild environment;
> - fixed ccache work.
> 
> Changes since v3:
> - dpkg_do_mounts() and dpkg_undo_mounts() are not removed for downstreams
> compatibility;
> - dpkg_build_export is used for adjusting sbuild environment;
> - DEB_BUILD_PROFILES support for sbuild is fixed in case of cross-build.
> Changes since v2:
> - patches reworked/squashed for easier reading and understanding;
> - fixed building foreigh architectures with kas-docker;
> - implemented support of ccache;
> - fixed devshell and devshell_nodeps,
> Changes since v1:
> - parallel builds with different BUILD_DIR are supported;
> - parallel multiconfig targets in one build are supported;
> - per-task schroot configuration in /etc/schroot/ is now used;
> - patchset now passes Jenkins CI (so patches changes RFC => PATCH).
> 
> Anton Mikanovich (1):
>   dpkg: Build packages with sbuild
> 
> Uladzimir Bely (11):
>   dpkg-gbp: Use separate command to export tarball
>   dpkg-gbp: Use host tools for dsc preparation
>   sbuild: Add recipes for host and target rootfs to run sbuild
>   sbuild: Introduce a class for another build method
>   sbuild: support of DEB_BUILD_PROFILES
>   sbuild: support of shell exports from dpkg_runbuild_prepend
>   dpkg: Remove builddeps install task.
>   sbuild: add ccache support
>   dpkg-base: Switch devshell to use schroot
>   dpkg-base: Switch apt_fetch and apt_unpack to use schroot
>   doc: Add sbuild-related documentation
> 
>  doc/user_manual.md                            |  22 ++-
>  meta/classes/dpkg-base.bbclass                |  79 ++++----
>  meta/classes/dpkg-gbp.bbclass                 |  26 +--
>  meta/classes/dpkg.bbclass                     |  80 +++++---
>  meta/classes/sbuild.bbclass                   | 184 ++++++++++++++++++
>  meta/conf/bitbake.conf                        |   2 +
>  .../sbuild-chroot/sbuild-chroot-host.bb       |  13 ++
>  .../sbuild-chroot/sbuild-chroot-target.bb     |  10 +
>  .../sbuild-chroot/sbuild-chroot.inc           |  39 ++++
>  9 files changed, 375 insertions(+), 80 deletions(-)
>  create mode 100644 meta/classes/sbuild.bbclass
>  create mode 100644 meta/recipes-devtools/sbuild-chroot/sbuild-chroot-host.bb
>  create mode 100644 meta/recipes-devtools/sbuild-chroot/sbuild-chroot-target.bb
>  create mode 100644 meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
> 

Does this functionally obsoletes buildchroot completely? I see that the
recipes are still there. If they aren't used anymore by core Isar, only
kept to make some special, not-yet-converted downstream layers happy,
they may still quickly regress.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux