public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "gcvidyasagar@gmail.com" <gcvidyasagar@gmail.com>,
	"ubely@ilbers.de" <ubely@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "shrikant.bobade@siemens.com" <shrikant.bobade@siemens.com>,
	"cedric.hombourger@siemens.com" <cedric.hombourger@siemens.com>,
	"vidyasagar.gc@siemens.com" <vidyasagar.gc@siemens.com>
Subject: Re: [PATCH v2 1/3] rootfs: fix base-apt.list cleanup
Date: Mon, 3 Mar 2025 15:31:01 +0000	[thread overview]
Message-ID: <6727bb3f34f22932d8da3a45091643d9935c796d.camel@siemens.com> (raw)
In-Reply-To: <20250303114217.11551-1-vidyasagar.gc@siemens.com>

On Mon, 2025-03-03 at 17:12 +0530, Vidyasagar G C wrote:
> From: Vidyasagar G C <gcvidyasagar@gmail.com>
> 
> Ensure proper removal of all files matching *base-apt.list by
> removing incorrect quoting, which prevented wildcard expansion.
> 
> Also remove the leftover 0000bootstrap.list from
> /etc/apt/sources.list.d/

Hi, thanks!

I just manually added your patch as it does not apply on next. Please
rebase and send again.

Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>

Felix

> 
> Signed-off-by: Vidyasagar G C <vidyasagar.gc@siemens.com>
> ---
>  meta/classes/rootfs.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/rootfs.bbclass
> b/meta/classes/rootfs.bbclass
> index 205da640..a25ec87b 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -358,6 +358,7 @@ rootfs_cleanup_isar_apt() {
>      sudo -s <<'EOSUDO'
>          set -e
>          rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/isar-apt.list"
> +        rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/"*bootstrap.list
>          rm -f "${ROOTFSDIR}/etc/apt/preferences.d/isar-apt"
>          rm -f "${ROOTFSDIR}/etc/apt/apt.conf.d/50isar"
>  EOSUDO
> @@ -368,7 +369,7 @@ rootfs_cleanup_base_apt[weight] = "2"
>  rootfs_cleanup_base_apt() {
>      sudo -s <<'EOSUDO'
>          set -e
> -        rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/*base-apt.list"
> +        rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/"*base-apt.list
>  EOSUDO
>  }
>  
> -- 
> 2.39.5
> 

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/6727bb3f34f22932d8da3a45091643d9935c796d.camel%40siemens.com.

  reply	other threads:[~2025-03-03 15:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 19:50 [PATCH] " Vidyasagar G C
2025-02-27  7:49 ` Uladzimir Bely
2025-02-27 16:10 ` 'MOESSBAUER, Felix' via isar-users
2025-03-03 11:42 ` [PATCH v2 1/3] " Vidyasagar G C
2025-03-03 15:31   ` 'MOESSBAUER, Felix' via isar-users [this message]
2025-03-04  6:59 ` [PATCH v2 3/3] fix(rootfs): cleanup leftover 0000bootstrap.list Vidyasagar G C
2025-03-13  4:38   ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6727bb3f34f22932d8da3a45091643d9935c796d.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=gcvidyasagar@gmail.com \
    --cc=shrikant.bobade@siemens.com \
    --cc=ubely@ilbers.de \
    --cc=vidyasagar.gc@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox