Re: [PATCH L-C v4 0/5] linux-custom recipe rework

[Jan Kiszka <jan.kiszka@siemens.com>]

On 05.12.19 18:01, Baurzhan Ismagulov wrote:
> Hello Cedric,
> 
> On Mon, Nov 25, 2019 at 05:04:49PM +0100, Cedric Hombourger wrote:
>> The Linux kernel is packaged a bit differently between Debian variants
>> and in particular for the perf package(s) in Debian vs Ubuntu. Since
>> there is no way the kernel build scripts would ever get distro specific
>> support for building more than the kernel and headers, we need our own
>> build/packaging scripts.
>>
>> Version 4 of this changeset was tested against ci_build.sh and some images were
>> booted on hardware available (including the de0-nano-soc). No regressions were
>> detected (to date). 
>>
>> This version is still relying on qemu-user-static being in the buildchroot-host
>> I am unfortunetely getting little time to work on removing this dependency (for
>> the avoidance of doubt, I understand the views of the maintainers). The purpose
>> of this submission is to share progress.
> 
> In general, looks good to me. A couple of thoughts:
> 
> * Could you provide simple test cases for the "apply" parameter and dts in this
>   or some later series?
> 
> * Echoing Jan: Why did you drop config fragment patches?

Looking at this again, I suspect you just wanted to avoid adding that
features first for the old recipe and then implementing it again for the
new one. I can see it in the new recipe, but the example got lost.

> 
> * The current usage of copying qemu-*-static in the mainline is racy (a recipe
>   may delete it before chroot needs it). It should be centralized in the
>   future.

Another reason to skip that for now.

Cedric, I can take over if you lack the time, just let me know.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux