From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 07 Nov 2025 14:26:12 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f62.google.com (mail-wm1-f62.google.com [209.85.128.62]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5A7DQCCJ000714 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 7 Nov 2025 14:26:12 +0100 Received: by mail-wm1-f62.google.com with SMTP id 5b1f17b1804b1-477632ce314sf4591185e9.3 for ; Fri, 07 Nov 2025 05:26:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1762521967; cv=pass; d=google.com; s=arc-20240605; b=X5DlPbpxa46OiJDEbg1s9QPr+r57kWfgDN+A4OlXmCuDywK4x0SHnGwRLtj65k9Pim GJFjdJS2dnITOTWBv8t8JYyOaNiQamipjsxm3gj4kAsies6+yzd9HC32t1iW6l8lECCe FWHaw9TUrNuy/iWXpUWsbyeOh5ybPHOkolWicEN7uce/HL4VpoFKwK6qxkY+Dz7BEObI HQCdBGmKuqs9l+T+a4tvUS7dFqL4T8Q9z/jKfH6mjFSFdiV9RsOJ6d5QAomKo5bY4Mod LqXnQUIxNrl0EqDJfi7TEgng3kR//Z/pCPcbvOvto8wGTmhI0CVx3hwtqftKflRToSE+ wQ2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=es6uM8a7AtVqNNKtfl35rZ4h52ra5dNpC9uCLI6o8CI=; fh=nANQkV8PoDh53oXIeKqfMjwJzhNauW+Q3YlplmYZo/A=; b=OhSw6DBX2pPwPDtNAo5UaUCYtqzRImMq2to2bR7/hocF1UDJTzSOD8tmZtgzwLmwSh STu6YXJgIZasfVgQOv4PhyY9iEFUXlF+ntmOWvv5e715HWuzR3AOBAX/0neeED8/i2jy A/XCxhSKI32n0vCFmC9V133W+x12gRzeaKPJdp7QTll43ET7Oe/Zkue9ddazinaM3+AK ZUPiI/wkVUf7m4eqNqe1P9YiUfDzn38nRDB8e2oRbQwuTzh2qBq5T8eYeYuUyc7zr/ly ZNIsfgg0jW9BQxUaUnYLJF2oisQKMgBUaNbxGoJQZx/VgPo2LGZs8mrkjLQASp75mIIE zXHA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1762521967; x=1763126767; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:cc :to:subject:user-agent:mime-version:date:message-id:sender:from:to :cc:subject:date:message-id:reply-to; bh=es6uM8a7AtVqNNKtfl35rZ4h52ra5dNpC9uCLI6o8CI=; b=H7YTX8CZ4Naf6Bl1uQ1vuzML9qTRcC3KTlqCLG8xXoL4sRDEk+8fTKK9Wd+JyoHpeq uIxV+N0eFEP9g3U2qcXK6qtzCYC+qrx7vDfvJIGPJOUHrkcJqHNOvf3DNm0j/KJFmT24 U6V3+4KYMVQ0x7nkRhUwMvzwr2Clzg8R4fD45+tBBHf9hN9nnTs0ESVkAl+XyfnWCyCZ mvnOZQHHKJS8l/Aw0Y4v54fvCA2lgi4mRI0edhmpwVvnWUwfWh6zRzg3yGXkU7mmDkRQ CUsyejCPRBk8wEmU73kr8fxHG8lvKOIuUN0V/V+yl+X8Yxum42tA/Dc2HbyEsZunDxnz BQIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762521967; x=1763126767; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:sender :from:to:cc:subject:date:message-id:reply-to; bh=es6uM8a7AtVqNNKtfl35rZ4h52ra5dNpC9uCLI6o8CI=; b=IJQ5q9guefKKLSjq4BLpDDILcGfUP5PFydF11XDS/tdmngjWFH30YL7fa/Z8PwiIdC fj6u3EGcfYq1aJyDx4nfzUkQG/ftzvPHJLAz3i3vaWpRK1DwUHZsVECmgs212YaJYyKW Y8FZXbmE53i+2hQ0Dcf6MzjozZQk4kATTaC+XCdG6tXKte3g7/6wkx9Fo+AMVx+GJwot /cbcMBX6/VtELePIWEryY19jO7A6Gbsd95U/GRi3D0W32AsiBcqA0Kh0AIk06uNp+Uiu 7GPGVNJdjKw1/xZPHwkIzGbd/RARkpFy4I0J9UKLyc9igQ2J1HU34sWeSgy+XyDoYrk5 h1hA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWfH+6328qEk34wnZdan5Rp9Z9owUd3fdeXNEAiOADD8opi20Em92bnVoCT0lwp4oTYrmVl@ilbers.de X-Gm-Message-State: AOJu0YyWbhlVqmVc6DyIG3K57wGqyrlPq5eraf+1mGv8sAzCZ3xt/Xk5 LsMZKrIQKUPL4eeVLDPRpVfajLk66/nDMoQXJTJ1LZ59NHfc08DhSS+7 X-Google-Smtp-Source: AGHT+IHo00KnBsGhbEqqyNHjm2GJ3cG+X2FNASokfxqOTDv9AQm8cIaER5rRJFkvpYocX1k6BnQz7A== X-Received: by 2002:a05:600c:1c07:b0:477:6d96:b3dd with SMTP id 5b1f17b1804b1-4776d96b66dmr17966635e9.1.1762521966572; Fri, 07 Nov 2025 05:26:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+aL8PEVxiX5MsHVOeCOwzVbBpQnmky6Q5p7hPzH9c5hNg==" Received: by 2002:a05:600c:46c6:b0:471:1492:474f with SMTP id 5b1f17b1804b1-47762513e43ls11725325e9.1.-pod-prod-06-eu; Fri, 07 Nov 2025 05:26:04 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVYCpF98QDVgfLsb6aZqT7LlRM3MkKvLpuChqPv+dVK4qGNMhtkhMFSGQJv7+svkSIpCMf89LxD7ya1@googlegroups.com X-Received: by 2002:a05:600c:8b4c:b0:45b:47e1:ef6d with SMTP id 5b1f17b1804b1-4776bcc9762mr29958605e9.36.1762521963829; Fri, 07 Nov 2025 05:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762521963; cv=none; d=google.com; s=arc-20240605; b=NPH1E9BfmAys+ODdr6kZG6Ef2nSF8nFlhdKeNMOouhgmCRTNGyJTY2uO1RKdlwO5s4 RFhwQe3YtnB99c2avjgod9piEr2clzSz5j93oinP0U8FwR6nU9xJoXQdzuGfM8uEr2HD aEPQ+Z2+lAF6dX0IyFsQ45PZfSdxmtge1oIjE27dL7PZ4gxj8pLiVq8UKB+Is1PECi8N tqH1iTTdvjqNnSclAYO91R83IF9Qgb/XXb605ywtdo1pOBN9rgl4ojeRy/gjoXzMmUD0 bxA21HmwfNYXOFPJtl2T9QgRFjGeM3KtaS+nChZIHsWfIBhLVV1V8iEvhNHhrQn8msAO pgFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=xtJB2yBTXYFaOWVtbpUpRmSvS9uF9d9TMg1qPe8KH8Y=; fh=LNaw2Wg4ItPv844VeBf75uuGV20HmWFCI4hg4NJi8ok=; b=iMFICYMI6c4ny/tYk6Y3gh8gn/clvT/2XoPtFOSmOcJJCfFG47JovRS1SmflD1TSWU pGcfIKySmpjMPHHvT9obKaYFTo3YeIUkrrHJjT+ny8IQ6RXQFCeNvzJwoLTfU8jz6osN FdRYzsylkobRaVjkSm8FDR3aFJFatDhGbtXEpCxLqQPvoWmO8FXTYB2ebdhwcxD9ecrH 5wya1TOjsgmTTx0UgCLtctgkfcpuWpvlYCfDxXhnY3C6cm1Kn5IYgBhQ8Yj5EPENE7BW ANpIvo3yis2grlBcZdcPxe70Q4uc0K4CuoFJzlqgTBPJzeWffYBaEslTGsEu08Q0BOCv vClQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id ffacd0b85a97d-42ac6792c1asi65279f8f.4.2025.11.07.05.26.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Nov 2025 05:26:03 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5A7DQ2tt000706 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 7 Nov 2025 14:26:03 +0100 Message-ID: <68039a95-5962-4129-9e29-0980697df46c@ilbers.de> Date: Fri, 7 Nov 2025 14:26:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] rootfs: rework no-generate-initrd rootfs feature To: Christoph Steiger , isar-users@googlegroups.com Cc: felix.moessbauer@siemens.com, jan.kiszka@siemens.com References: <20251105072630.37142-1-christoph.steiger@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <20251105072630.37142-1-christoph.steiger@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: IHnOqmx6nyCW Applied to next, thanks. Best regards, Zhihang On 11/5/25 08:26, 'Christoph Steiger' via isar-users wrote: > Instead of using a negative feature replace it with a positive one: > generate-initrd. It can be confusing for the user why a initrd is > generated even though no additional rootfs features are enabled. > > To keep default behavior the same add generate-initrd to the default > rootfs features, unless INITRD_IMAGE is provided. > > Signed-off-by: Christoph Steiger > --- > > Changes in v3: > - enable generate-initrd also when there are already other rootfs > features > > Changes in v2: > - move initialisation of INITRD_IMAGE to rootfs > > RECIPE-API-CHANGELOG.md | 14 ++++++++++++++ > meta/classes/image.bbclass | 3 --- > meta/classes/rootfs.bbclass | 10 ++++++---- > .../sbuild-chroot/sbuild-chroot.inc | 2 +- > 4 files changed, 21 insertions(+), 8 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 1826667a..1a5eba31 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -797,3 +797,17 @@ root file modifications) are required. > A new class called `opensbi` has been introduced that shall help writing > shorter recipes for custom OpenSBI builds. Usage examples can be found in > `meta-isar/recipes/bsp/opensbi`. > + > +### Rework `no-generate-initrd` rootfs feature > + > +This negative feature is being replaced with a positive one: > +`generate-initrd`. The default behavior remains unchanged, as `generate-initrd` > +is now a default rootfs feature. Disabling initrd creation can be done in the > +following way: > +``` > +ROOTFS_FEATURE:remove = "generate-initrd" > +``` > +instead of > +``` > +ROOTFS_FEATURE += "no-generate-initrd" > +``` > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 441ea936..b58711d0 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -23,7 +23,6 @@ IMAGE_FULLNAME = "${PN}-${DISTRO}-${MACHINE}" > > # These variables are used by wic and start_vm > KERNEL_IMAGE ?= "${IMAGE_FULLNAME}-${KERNEL_FILE}" > -INITRD_IMAGE ?= "" > INITRD_DEPLOY_FILE = "${@ d.getVar('INITRD_IMAGE') or '${IMAGE_FULLNAME}-initrd.img'}" > > # This defines the deployed dtbs for reuse by imagers > @@ -67,8 +66,6 @@ inherit essential > > ROOTFSDIR = "${IMAGE_ROOTFS}" > ROOTFS_FEATURES += "clean-package-cache clean-pycache generate-manifest export-dpkg-status clean-log-files clean-debconf-cache" > -# when using a custom initrd, do not generate one as part of the image rootfs > -ROOTFS_FEATURES += "${@ '' if d.getVar('INITRD_IMAGE') == '' else 'no-generate-initrd'}" > ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${@isar_multiarch_packages('IMAGE_INSTALL', d)}" > ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 2fef3120..32d49146 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -8,14 +8,16 @@ ROOTFS_DISTRO ?= "${DISTRO}" > ROOTFS_PACKAGES ?= "" > ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}" > > +INITRD_IMAGE ?= "" > + > # Features of the rootfs creation: > # available features are: > # 'clean-package-cache' - delete package cache from rootfs > # 'generate-manifest' - generate a package manifest of the rootfs into ${ROOTFS_MANIFEST_DEPLOY_DIR} > # 'export-dpkg-status' - exports /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} > # 'clean-log-files' - delete log files that are not owned by packages > -# 'no-generate-initrd' - do not generate debian default initrd > -ROOTFS_FEATURES ?= "" > +# 'generate-initrd' - generate debian default initrd > +ROOTFS_FEATURES += "${@ 'generate-initrd' if d.getVar('INITRD_IMAGE') == '' else ''}" > > ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" > > @@ -349,7 +351,7 @@ rootfs_restore_initrd_tooling() { > EOSUDO > } > > -ROOTFS_INSTALL_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'no-generate-initrd', 'rootfs_clear_initrd_symlinks', '', d)}" > +ROOTFS_INSTALL_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-initrd', '', 'rootfs_clear_initrd_symlinks', d)}" > rootfs_clear_initrd_symlinks() { > sudo rm -f ${ROOTFSDIR}/initrd.img > sudo rm -f ${ROOTFSDIR}/initrd.img.old > @@ -594,7 +596,7 @@ rootfs_generate_initramfs() { > } > > python() { > - if 'no-generate-initrd' not in d.getVar('ROOTFS_FEATURES', True).split(): > + if 'generate-initrd' in d.getVar('ROOTFS_FEATURES', True).split(): > bb.build.addtask('do_generate_initramfs', 'do_rootfs', 'do_rootfs_postprocess', d) > bb.build.addtask('do_generate_initramfs_setscene', None, None, d) > } > diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc > index 479aa91d..61d37760 100644 > --- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc > +++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc > @@ -55,7 +55,7 @@ SBUILD_CHROOT_PREINSTALL_COMMON = " \ > SBUILD_CHROOT_DIR = "${WORKDIR}/rootfs" > ROOTFSDIR = "${SBUILD_CHROOT_DIR}" > ROOTFS_PACKAGES = "${SBUILD_CHROOT_PREINSTALL}" > -ROOTFS_FEATURES += "no-generate-initrd" > +ROOTFS_FEATURES:remove = "generate-initrd" > > ROOTFS_INSTALL_COMMAND:remove = "rootfs_restore_initrd_tooling" > -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/68039a95-5962-4129-9e29-0980697df46c%40ilbers.de.