public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com,
	"Roberto A. Foglietta" <roberto.foglietta@gmail.com>
Subject: Re: [PATCH 1/1] newer kernels (e.g. v5.19) do not include objtool anymore in linux-header fixed
Date: Thu, 03 Nov 2022 09:47:14 +0300	[thread overview]
Message-ID: <6813218.9J7NaK4W3v@home> (raw)
In-Reply-To: <CAJGKYO4ef6O=0tkjwfYb7FELD5_KTYkoUcJFQE7177op_yq0cA@mail.gmail.com>

In the email from Saturday, 29 October 2022 22:09:10 +03 user Roberto A. 
Foglietta wrote:
> Hi all,
> 
>  I discovered that newer kernels (e.g. v5.19) when compiled and
> packaged by an ISAR project do not include the objectool anymore. This
> obviously breaks any activity which expects to use that binary
> executable. In this a patch below a suggestion for fixing this issue
> (tested ok).
> 
> From 48c6e9b409eb9d00e04a20f69df71ae88f51e178 Mon Sep 17 00:00:00 2001
> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> Date: Sat, 29 Oct 2022 18:59:10 +0200
> Subject: [PATCH] linux install.tmpl: added OR with CONFIG_HAVE_OBJTOOL for
>  objtools
> 
> linux install.tmpl: added OR with CONFIG_HAVE_OBJTOOL for objtools
> a fix for newer kernels (since 5.19 for sure) to include objtool
> 
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> index 0a8645d..de57d82 100644
> --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> @@ -177,7 +177,7 @@ kernel_headers() {
>          echo Module.symvers >> ${obj_hdr_files}
>      fi
>      (cd ${O}; find arch/${ARCH}/include include scripts -type f)
> 
> >>${obj_hdr_files}
> 

The patch is mailformed here. Looks like it was sent not via "git send-email", 
but just copy-pasted to the mail body.

Could you please send v2?

> -    if [ -n "${CONFIG_STACK_VALIDATION}" ]; then
> +    if [ -n "${CONFIG_STACK_VALIDATION}" -o -n "${CONFIG_HAVE_OBJTOOL}" ];
> then (cd ${O}; find tools/objtool -type f -executable) >>${obj_hdr_files}
> fi
>      if [ -n "${CONFIG_GCC_PLUGINS}" ]; then


-- 
Uladzimir Bely




  reply	other threads:[~2022-11-03  6:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29 19:09 Roberto A. Foglietta
2022-11-03  6:47 ` Uladzimir Bely [this message]
2022-11-03  8:08   ` Bezdeka, Florian
2022-11-03 12:07   ` Roberto A. Foglietta
2022-11-03 12:19     ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6813218.9J7NaK4W3v@home \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox