From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750962531146137600 X-Received: by 2002:a17:902:7e45:: with SMTP id a5mr1250186pln.315.1573762286349; Thu, 14 Nov 2019 12:11:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:8085:: with SMTP id c5ls120915pjn.0.experimental-gmail; Thu, 14 Nov 2019 12:11:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxwvMXAOLJMH4j4ccbXkcvvlh2vLFaqQOcZ/KPl4i4XvN0T1jgT/k5/4maRGq8nevt5R4eL X-Received: by 2002:adf:ed4e:: with SMTP id u14mr10731218wro.132.1573762284500; Thu, 14 Nov 2019 12:11:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573762284; cv=none; d=google.com; s=arc-20160816; b=gXW9G/uL2IWPX1ts48VRBFn/MlS2futcJW9EtfKO+0hGHAx39hk3FzFRro2FXxnn1K eE/FUiOoHEWZgx9S38HBbWR6ozUlqfcCKYG2YmIVSfWfw4qfEHeQE6svG22eHeMNbUKQ dpPKf6PlQ0IxZCYs+cWd8G/FaAzDzmYVAcrumknUdpdjEnlo2zvAoGQuMy/kiAVYjW5I XnKBQ1+TNK8zkKvTWmPrpkgoOmhj/3Y5zrS4hyxLjHuPsCgKdF3fR9OTTyBeU21EbG2K zvQjTfm5tX0EGTzuae4YsZzW8Rr/Dhs0fX5/JFXZfIA6cxhexFCJTz1LLNiAXL8EbsOK ydkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=ivKDDHdeCz1Rd3IZ0ENSJMg0PyRuanEoyXngOU67i4s=; b=bhvq7JU+0ggM7oRoMYQL/+ChLtqZQgi6tL+6TW3IKkqzJZYlAfOwLDEVeeaXYW/HS2 N0p/9fiNz8EFpdqR++EmfSlhZ8rji80vhKg7aivZ/0PF5JFVw05MTBvcGnfb6UyuKvGv v9DR5wy6ap16sH2/jxzdOppJkRYkMImf4JW0m5ce6ziZeve7FFDvZSQLf8qYq1rqEeum 3+r0ATMsH4wdxUItor7Dv0qXVFeZ9btrf8AeXjBEuTBXq77blOwEi1d4U7r41VJc6eaC ToM0t65VVE47+1Ud4PcALGl+/SUyuRCfSZjMKrv91lT9skU3icpnAu/YUfZyCxGjaRLS QdSw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id i13si414249wru.2.2019.11.14.12.11.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 12:11:24 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id xAEKBNPC029931 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2019 21:11:23 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xAEKBNvJ032003; Thu, 14 Nov 2019 21:11:23 +0100 Subject: Re: [PATCHv3 8/9] bootstrap: fix debootstrap gpg issue when base-apt is not signed To: Henning Schild , isar-users@googlegroups.com Cc: Baurzhan Ismagulov , chombourger@gmail.com References: <20191107185603.9077-1-henning.schild@siemens.com> <20191107185603.9077-9-henning.schild@siemens.com> From: Jan Kiszka Message-ID: <6825fdd8-f85f-e71c-6f63-ad3ddf1ffc8e@siemens.com> Date: Thu, 14 Nov 2019 21:11:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191107185603.9077-9-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 6l7DZz3J7KsH On 07.11.19 19:56, Henning Schild wrote: > From: Henning Schild > > DISTRO_BOOTSTRAP_KEYRING will not exist if DISTRO_BOOTSTRAP_KEYFILES is empty. > So the debootstrap argument will not work. > Simplify the logic to depend on the existance of the keyring-file. > > Signed-off-by: Henning Schild > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > index 203a557..b506f30 100644 > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > @@ -231,14 +231,10 @@ isar_bootstrap() { > shift > done > debootstrap_args="--verbose --variant=minbase --include=${DISTRO_BOOTSTRAP_BASE_PACKAGES}" > - if [ ! "x${DISTRO_BOOTSTRAP_KEYS}" = "x" ] || \ > - [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then > + if [ -f "${DISTRO_BOOTSTRAP_KEYRING}" ]; then > debootstrap_args="$debootstrap_args --keyring=${DISTRO_BOOTSTRAP_KEYRING}" > - fi > - if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then > - if [ -z "${BASE_REPO_KEY}" ] ; then > - debootstrap_args="$debootstrap_args --no-check-gpg" > - fi > + else > + debootstrap_args="$debootstrap_args --no-check-gpg" > fi > E="${@ isar_export_proxies(d)}" > export IS_HOST debootstrap_args E > Breaks with non-empty DISTRO_BOOTSTRAP_KEYS and a non-signed base-apt. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux