public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH v2] fix broken fsck type in initramfs-fsck-hook-ext4
@ 2023-01-09  8:32 T. Schaffner
  2023-01-24  7:35 ` Uladzimir Bely
  0 siblings, 1 reply; 2+ messages in thread
From: T. Schaffner @ 2023-01-09  8:32 UTC (permalink / raw)
  To: isar-users; +Cc: quirin.gylstorff, henning.schild, Tobias Schaffner

From: Tobias Schaffner <tobias.schaffner@siemens.com>

The initramfs-fsck-hook-ext4 script did not copy the fsck binary as the
wrong type variable was used to identify the needed filesystem type.

Set the type to ext4 as the script is ext4 only anyways.

Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
---
 .../initramfs-fsck-hook/files/initramfs.fsck.ext4.hook      | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook b/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
index 23f7c28..1bccc81 100644
--- a/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
+++ b/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
@@ -26,13 +26,11 @@ if [ ! -x /sbin/fsck ]; then
 	exit 0
 fi
 
-fsck_types="ext4"
-
 copy_exec /sbin/fsck
 copy_exec /sbin/logsave
 
-if prog="$(command -v fsck.${type})"; then
+if prog="$(command -v fsck.ext4)"; then
   copy_exec "$prog"
 else
-  echo "Warning: /sbin/fsck.${type} doesn't exist, can't install to initramfs, ignoring."
+  echo "Warning: /sbin/fsck.ext4 doesn't exist, can't install to initramfs, ignoring."
 fi
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] fix broken fsck type in initramfs-fsck-hook-ext4
  2023-01-09  8:32 [PATCH v2] fix broken fsck type in initramfs-fsck-hook-ext4 T. Schaffner
@ 2023-01-24  7:35 ` Uladzimir Bely
  0 siblings, 0 replies; 2+ messages in thread
From: Uladzimir Bely @ 2023-01-24  7:35 UTC (permalink / raw)
  To: isar-users

In mail from понедельник, 9 января 2023 г. 11:32:20 +03 user T. Schaffner 
wrote:
> From: Tobias Schaffner <tobias.schaffner@siemens.com>
> 
> The initramfs-fsck-hook-ext4 script did not copy the fsck binary as the
> wrong type variable was used to identify the needed filesystem type.
> 
> Set the type to ext4 as the script is ext4 only anyways.
> 
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>  .../initramfs-fsck-hook/files/initramfs.fsck.ext4.hook      | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git
> a/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
> b/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
> index 23f7c28..1bccc81 100644
> ---
> a/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
> +++
> b/meta/recipes-support/initramfs-fsck-hook/files/initramfs.fsck.ext4.hook
> @@ -26,13 +26,11 @@ if [ ! -x /sbin/fsck ]; then
>  	exit 0
>  fi
> 
> -fsck_types="ext4"
> -
>  copy_exec /sbin/fsck
>  copy_exec /sbin/logsave
> 
> -if prog="$(command -v fsck.${type})"; then
> +if prog="$(command -v fsck.ext4)"; then
>    copy_exec "$prog"
>  else
> -  echo "Warning: /sbin/fsck.${type} doesn't exist, can't install to
> initramfs, ignoring." +  echo "Warning: /sbin/fsck.ext4 doesn't exist,
> can't install to initramfs, ignoring." fi

Applied to next, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-24  7:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09  8:32 [PATCH v2] fix broken fsck type in initramfs-fsck-hook-ext4 T. Schaffner
2023-01-24  7:35 ` Uladzimir Bely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox