public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com
Cc: roberto.foglietta@gmail.com
Subject: Re: [PATCH] bootstrap.inc install sources-list then wrongly remove it, bugfix
Date: Tue, 10 Jan 2023 13:41:55 +0100	[thread overview]
Message-ID: <6876899c-232a-6cbe-57da-0c25b69a1e40@siemens.com> (raw)
In-Reply-To: <20230110115020.1234724-1-roberto.foglietta@linuxteam.org>

On 10.01.23 12:50, roberto.foglietta@linuxteam.org wrote:
> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> 
> bootstrap.inc, bugfix: two lines were in reverse order between them
> 
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index faba73f..3aa11a4 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -296,6 +296,7 @@ do_bootstrap() {
>          if [ "${BOOTSTRAP_FOR_HOST}" = "0" ]; then
>              arch_param="--arch=${DISTRO_ARCH}"
>          fi
> +
>          ${DEBOOTSTRAP} $debootstrap_args \
>                         $arch_param \
>                         ${@get_distro_components_argument(d)} \
> @@ -327,9 +328,9 @@ do_bootstrap() {
>              install -v -m644 "${APTSRCS}" \
>                               "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list"
>          fi
> -        install -v -m644 "${APTSRCS_INIT}" "${ROOTFSDIR}/etc/apt/sources-list"
>          rm -f "${ROOTFSDIR}/etc/apt/sources.list"

sources-list != sources.list, if that was your concern. So the order is
not critical here. If it were, things should have exploded already in
all colors.

Jan

> -        rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"*
> +        install -v -m644 "${APTSRCS_INIT}" "${ROOTFSDIR}/etc/apt/sources-list"
> +
>          find ${APT_KEYS_DIR}/ -type f | while read keyfile
>          do
>              MY_GPGHOME="$(chroot "${ROOTFSDIR}" mktemp -d /tmp/gpghomeXXXXXXXXXX)"

-- 
Siemens AG, Technology
Competence Center Embedded Linux


  parent reply	other threads:[~2023-01-10 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 11:50 roberto.foglietta
2023-01-10 12:05 ` Roberto A. Foglietta
2023-01-10 12:41 ` Jan Kiszka [this message]
2023-01-10 19:22   ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6876899c-232a-6cbe-57da-0c25b69a1e40@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    --cc=roberto.foglietta@linuxteam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox