public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] example-app: Fix a compile warning in patched example
@ 2018-08-14 16:24 Henning Schild
  2018-08-16 12:25 ` Maxim Yu. Osipov
  0 siblings, 1 reply; 2+ messages in thread
From: Henning Schild @ 2018-08-14 16:24 UTC (permalink / raw)
  To: isar-users; +Cc: Jan Kiszka, Henning Schild

One of the patches introduced in a8ecb2bd3367 triggers a compiler
warning because of a missing prototype for "strcmp". Include string.h to
solve that problem.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .../example-hello/files/0001-Add-some-help.patch            | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch b/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch
index 3c68a93..f134077 100644
--- a/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch
+++ b/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch
@@ -1,4 +1,4 @@
-From 4615f473881aaff12a52aa3bb625bfb38753b4f2 Mon Sep 17 00:00:00 2001
+From 2bf0be78037bb3140a4af5ec3755960a278e84cf Mon Sep 17 00:00:00 2001
 From: Jan Kiszka <jan.kiszka@siemens.com>
 Date: Sun, 18 Feb 2018 09:02:11 +0100
 Subject: [PATCH] Add some help
@@ -7,18 +7,19 @@ This just provides a commit to demonstrate patching in Isar recipes.
 
 Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
 ---
- hello.c | 11 ++++++++++-
- 1 file changed, 10 insertions(+), 1 deletion(-)
+ hello.c | 12 +++++++++++-
+ 1 file changed, 11 insertions(+), 1 deletion(-)
 
 diff --git a/hello.c b/hello.c
-index 269c24b..329a0c5 100644
+index 269c24b..941babc 100644
 --- a/hello.c
 +++ b/hello.c
-@@ -5,10 +5,19 @@
+@@ -5,10 +5,20 @@
   * version 2.
   */
  
 +#include <stdio.h>
++#include <string.h>
  #include <hello.h>
  
 -int main(void)
@@ -36,5 +37,5 @@ index 269c24b..329a0c5 100644
  	return 0;
  }
 -- 
-2.13.6
+2.16.4
 
-- 
2.16.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] example-app: Fix a compile warning in patched example
  2018-08-14 16:24 [PATCH] example-app: Fix a compile warning in patched example Henning Schild
@ 2018-08-16 12:25 ` Maxim Yu. Osipov
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Yu. Osipov @ 2018-08-16 12:25 UTC (permalink / raw)
  To: Henning Schild, isar-users

On 08/14/2018 07:24 PM, Henning Schild wrote:
> One of the patches introduced in a8ecb2bd3367 triggers a compiler
> warning because of a missing prototype for "strcmp". Include string.h to
> solve that problem.

Applied to the 'next'.

Thanks,
Maxim.

> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   .../example-hello/files/0001-Add-some-help.patch            | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch b/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch
> index 3c68a93..f134077 100644
> --- a/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch
> +++ b/meta-isar/recipes-app/example-hello/files/0001-Add-some-help.patch
> @@ -1,4 +1,4 @@
> -From 4615f473881aaff12a52aa3bb625bfb38753b4f2 Mon Sep 17 00:00:00 2001
> +From 2bf0be78037bb3140a4af5ec3755960a278e84cf Mon Sep 17 00:00:00 2001
>   From: Jan Kiszka <jan.kiszka@siemens.com>
>   Date: Sun, 18 Feb 2018 09:02:11 +0100
>   Subject: [PATCH] Add some help
> @@ -7,18 +7,19 @@ This just provides a commit to demonstrate patching in Isar recipes.
>   
>   Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>   ---
> - hello.c | 11 ++++++++++-
> - 1 file changed, 10 insertions(+), 1 deletion(-)
> + hello.c | 12 +++++++++++-
> + 1 file changed, 11 insertions(+), 1 deletion(-)
>   
>   diff --git a/hello.c b/hello.c
> -index 269c24b..329a0c5 100644
> +index 269c24b..941babc 100644
>   --- a/hello.c
>   +++ b/hello.c
> -@@ -5,10 +5,19 @@
> +@@ -5,10 +5,20 @@
>     * version 2.
>     */
>    
>   +#include <stdio.h>
> ++#include <string.h>
>    #include <hello.h>
>    
>   -int main(void)
> @@ -36,5 +37,5 @@ index 269c24b..329a0c5 100644
>    	return 0;
>    }
>   --
> -2.13.6
> +2.16.4
>   
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-16 12:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 16:24 [PATCH] example-app: Fix a compile warning in patched example Henning Schild
2018-08-16 12:25 ` Maxim Yu. Osipov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox