From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7074908419729129472 X-Received: by 2002:a05:6512:12c7:b0:448:6cb8:f194 with SMTP id p7-20020a05651212c700b004486cb8f194mr2240627lfg.144.1647507634434; Thu, 17 Mar 2022 02:00:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3f16:b0:449:f5bf:6f6a with SMTP id y22-20020a0565123f1600b00449f5bf6f6als1075922lfa.2.gmail; Thu, 17 Mar 2022 02:00:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHxpPAYLAuQ3qfu/hj4OAeoOU1/EBqV+kubhYgi3845Z46uhUhYSmuNo5zQA8X/7bdDu7r X-Received: by 2002:a05:6512:3d28:b0:448:79b8:3f3c with SMTP id d40-20020a0565123d2800b0044879b83f3cmr2267697lfv.357.1647507633384; Thu, 17 Mar 2022 02:00:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647507633; cv=none; d=google.com; s=arc-20160816; b=KiDo1qMm1rP8Y834Tj2Xw5EAvisnqeD60AoAePvvXkH0vVocWszzlLbq9dX0ZfRO6f 55UMBUqUGQrBS7ggitFZZ/qlLarDrUTk1eNjeGisbIB67Wzcvs2KMq7ZPukrY2mJgHnK Zsu4mjUM1fIn+b8PPI4h3Nv+6A7zmWWiw8KQPaiSUM+PA96/pHyLbdVdO3ym0osGajUI NO80LNOYiGFNzBB4O5Y9JXb1iHQO+OArHKtFXsPc2U31rcihA4BO1zoWiVA5z7FpyRaN UMSoc856LOtNYA/+arkZakgA3bUOReelhy8Pu1eVdgcuOOSc8eW7oVcUmgfoOAicx4SP fOdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=dHO+EbXyiIrU4hWRaJzy3Vp0Gc8gAz9U8UbJuKsFvgc=; b=NWVd2/NjKOnhYDlUld7r05gcv9gHLQcvljosIyA5P5xeENY4qA5NTmKxpCUqY4+xF/ gbEHxfJPpcsJV4qaseMivjvAolldwX0vkHaLsgiUKW8RdXE+PmFeVjNMMFWSqhWnoYb/ OHIsIhdXGlhMSmCQEXv7cinfvxNHoypEYA6AD5Cfr+iVnFucmPi28vW/BFXxrpvaxPu2 PC9aXwmWch7c2tDndBaupko15LI/+un1CewSrc4WUYyXkLIuCvnl/owd5BtV1nq8S6hD y3m0+BvOphH7p/3vcWkHdd/SBqI1kFih7+Awb0FBdBmm6RH1QiGf1BIzZfrSu5r6nlvc VbdA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@klincov.com header.s=protonmail2 header.b="hHFC/SCb"; spf=pass (google.com: domain of wadim@klincov.com designates 185.70.43.17 as permitted sender) smtp.mailfrom=wadim@klincov.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=klincov.com Return-Path: Received: from mail-4317.proton.ch (mail-4317.proton.ch. [185.70.43.17]) by gmr-mx.google.com with ESMTPS id i25-20020a0565123e1900b00448391a7e7bsi235512lfv.6.2022.03.17.02.00.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 02:00:33 -0700 (PDT) Received-SPF: pass (google.com: domain of wadim@klincov.com designates 185.70.43.17 as permitted sender) client-ip=185.70.43.17; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@klincov.com header.s=protonmail2 header.b="hHFC/SCb"; spf=pass (google.com: domain of wadim@klincov.com designates 185.70.43.17 as permitted sender) smtp.mailfrom=wadim@klincov.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=klincov.com Date: Thu, 17 Mar 2022 09:00:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klincov.com; s=protonmail2; t=1647507631; bh=dHO+EbXyiIrU4hWRaJzy3Vp0Gc8gAz9U8UbJuKsFvgc=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=hHFC/SCbV2tRHw9utEVxsjgFVN1PWlGDBaXecDD4MJT55dy83cEgUVGG6IsKWz0Tv LWIecVRDIYNrZWcqoNsAnjPEABsXJ/uJAlY7dQOHjVZuVzizIKZLOarBLmKSrNkNuK 22xV/5JhtY+8fH3cFEIUrwkw67VIGxlowTUSsmbR3UWwoyGgnPfs863QO2OTHqzKta wNhwg/VgdDdmTbnKZSY8+pi0ZW2AMm93tkUvTsdB7T/0Yb58LE3K+YM0GHgXtihOIs SoTlCBMYjKHUnoSuCK33amHfYc5uzKH9uMCIys/+BwUHSH5wMQ8sc1HqeEwH94ongX BV/i7cMXFnC2g== To: Henning Schild From: Wadim Klincov Cc: isar-users@googlegroups.com Reply-To: Wadim Klincov Subject: Re: [PATCH] Add missing WicError import Message-ID: <6a336c19-665d-af03-6a3d-05278cf8be00@klincov.com> In-Reply-To: <20220316121333.3d6b3367@md1za8fc.ad001.siemens.net> References: <20220314105543.100423-1-wadim@klincov.com> <20220316092405.2044eb0f@md1za8fc.ad001.siemens.net> <05873484-d92b-59ca-e61b-faf1359a8c1c@klincov.com> <20220316121333.3d6b3367@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: lWm9458sO0uT On 3/16/22 12:13, Henning Schild wrote: > Am Wed, 16 Mar 2022 09:12:48 +0000 > schrieb Wadim Klincov : > >> On 3/16/22 09:24, Henning Schild wrote: >>> Am Mon, 14 Mar 2022 10:55:53 +0000 >>> schrieb Wadim Klincov : >>> >>>> This patch adds the missing import of `WicError`, making any >>>> potential errors when building wic images easier to understand. >>>> >>>> Signed-off-by: Wadim Klincov >>>> --- >>>> meta/scripts/lib/wic/plugins/isarpluginbase.py | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/meta/scripts/lib/wic/plugins/isarpluginbase.py >>>> b/meta/scripts/lib/wic/plugins/isarpluginbase.py index >>>> 185e2ea..68af220 100644 --- >>>> a/meta/scripts/lib/wic/plugins/isarpluginbase.py +++ >>>> b/meta/scripts/lib/wic/plugins/isarpluginbase.py @@ -8,6 +8,8 @@ >>>> >>>> import os >>>> >>>> +from wic import WicError >>>> + >>> >>> This is already done in all the plugins we have in tree. The file >>> you are touching here is "what we need to fork", and we do not need >>> that. Or does the import in the existing plugins also not work? >>> >>> In case you need that in your custom plugin, just include the import >>> into your own plugin. Maybe you do not even need that "base" lib for >>> your custom plugin. Since it is ... what we need to fork. Not what >>> we might need for our own plugins. >>> >> >> Thanks for your reply! >> >> Do you mean `isarpluginbase.py` is something I, as a user, should fork >> and change to my liking? Right now using `BootimgEFIPlugin` (or a >> slightly modified version for better resolution) works great and it >> wasn't clear that it's not something which should be used. > > Ideally nobody should fork anything. Isar had to fork some plugins from > OE, to keep those forks small and maintainable the pluginbase code was > written to keep the isar-version as close as possible to OE. > > You hopefully do not have to fork again ... Please contribute your > changes to the EFI plugin back here, or ideally into OE directly. > > In case you are writing your complete own isar-/layer-specific wic > plugin, you might not want to use "pluginbase". Since its main goal is > to cater for the OE plugins that isar re-uses in a modified way. > Great, then I just misunderstood, thanks a lot for the clarification! >> The issue on my side happens when `BootimgEFIPlugin` calls >> `isar_get_filenames` and the kernel is not available for whatever >> reason. In this case `isar_get_filenames` tries to raise `WicError`, >> but since it's not imported directly in `isarpluginbase.py` a bitbake >> error is thrown instead. It's still clear that the kernel is not >> available, it's just not very readable. > > Yes i think your patch is valid. No matter what you might be doing in > terms of forking or writing your own plugins. > > regards, > Henning > >>> regards, >>> Henning >>> >>>> def isar_populate_boot_cmd(rootfs_dir, hdddir): >>>> # copy all files from rootfs/boot into boot partition >>>> # no not copy symlinks (ubuntu places them here) because >>>> targetfs is fat -- >>>> 2.35.1 >>>> >>>> >>> >> Wadim >> >