Re: [PATCH 25/26] dpkg-base: Move do_deploy_deb before do_build

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Jan,

On 26/08/2019 08.26, [ext] Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> There is not good reason to move anything beyond the final do_build task
> in a recipe.

This is not exactly what this patch does though, so you might want to 
update the description.

What you do here is add do_deploy_deb as a dependency to do_build, 
meaning now deploying a debian package is part of the default build 
target. The main difference is in the definition of when is a recipe 
considered to be 'build': Either after the debian package was created 
inside the work directory or when the debian package is added to a 
repository. I would argue that there are reasons for both perspectives.

It is possible to consider 'do_depoy*' in packages more like 'make 
install', and as such not part of the default target.

regards,
Claudius

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta/classes/dpkg-base.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
> index 50df06d..d4541a4 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -131,7 +131,7 @@ do_deploy_deb() {
>                ${S}/../*.deb
>   }
>   
> -addtask deploy_deb after do_dpkg_build
> +addtask deploy_deb after do_dpkg_build before do_build
>   do_deploy_deb[lockfiles] = "${REPO_ISAR_DIR}/isar.lock"
>   do_deploy_deb[depends] = "isar-apt:do_cache_config"
>   do_deploy_deb[dirs] = "${S}"
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de