From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6729358150130991104 X-Received: by 2002:a19:ed11:: with SMTP id y17mr1659124lfy.141.1566977564669; Wed, 28 Aug 2019 00:32:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4a9a:: with SMTP id l26ls182484lfp.2.gmail; Wed, 28 Aug 2019 00:32:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/0LUXqXtMgjlwsU/1EUGn2k3xt4c5X4xn3Fq7NO5hIkDaZLn+jizVBtjYjrnrE3uSTAip X-Received: by 2002:a19:6041:: with SMTP id p1mr1676944lfk.6.1566977564242; Wed, 28 Aug 2019 00:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566977564; cv=none; d=google.com; s=arc-20160816; b=iN34sDQXuYVaqs4nER0/aoEGyIuFxS+8AxJT9KSsRCQhl531AwnwwIKlSA28jjkIQ2 4aZpoc1uGV6WE0frzlXHWd/EbaBZe/8uEBAQkK2nct/+eOF/sB2OsiVPIVTCyN5yU/Lc jg2+Qwul8mtC2e/EULuKgWnkpDA1vzp4V2ZVBWGFLSxdn9gjJni+vMKFzmw5J5k47fQ/ Ewampoh4Z4c8rIEMB5Puq+AA2FgcnPrc8/BYXBljhg0gEdefy9MQDguuMp4MNAcatHjh LQT3L2Tg//9VspXGRALPnGSsK9Vpci10hn9AQZR3158z+l3HsM08PrOm12WBfaH2eImR QunA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=sbqhD5rnPbyVksvoNj3bzvZ+U14pohczKSpuM3Ry+tk=; b=zsqgQrrE6M4I2FQjUBqDiUEMF2uNivbKB+vpV7sI9vy6kPiFcBDVI9JcXtgF1gKpHv 5jiFx9zEPi1ACVDP/ICV5RlrLtEPYAoEx1qVu49m2tuhaHhk4OjE8NN/cDBiU+vUt/QH 01yMP2RX08bZbhyV2nkQOyGkA2GCqrWBalH96eTCt0xKe4JV9TM/+2JIhEX/1OOCZk4O BLdviCBxFiyXogLK0sqqdTHqR6N+QVd5xVdTbVtaGMBn7lJVT0DGv0/cxv6ySgaJdZZu Qmv5iY8wnbQlmyo3pOJ+1QBeGlPTKAES+MV5bFIf+ZS1ncuxu/kHBchtzAxtcXlkN2oa Vz1w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id s14si72535ljg.4.2019.08.28.00.32.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Aug 2019 00:32:44 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x7S7WhbQ007690 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 28 Aug 2019 09:32:43 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7S7WhW5020635; Wed, 28 Aug 2019 09:32:43 +0200 Subject: Re: [PATCH 25/26] dpkg-base: Move do_deploy_deb before do_build To: "[ext] Jan Kiszka" , isar-users References: <22a14a31cfcef329d3d554ca838ccd68f08698a8.1566800787.git.jan.kiszka@siemens.com> From: Claudius Heine Message-ID: <6ae9caca-fb70-2b33-1a1c-964fa14fc7a8@siemens.com> Date: Wed, 28 Aug 2019 09:32:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <22a14a31cfcef329d3d554ca838ccd68f08698a8.1566800787.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: PYrrD7fhIk3U Hi Jan, On 26/08/2019 08.26, [ext] Jan Kiszka wrote: > From: Jan Kiszka > > There is not good reason to move anything beyond the final do_build task > in a recipe. This is not exactly what this patch does though, so you might want to update the description. What you do here is add do_deploy_deb as a dependency to do_build, meaning now deploying a debian package is part of the default build target. The main difference is in the definition of when is a recipe considered to be 'build': Either after the debian package was created inside the work directory or when the debian package is added to a repository. I would argue that there are reasons for both perspectives. It is possible to consider 'do_depoy*' in packages more like 'make install', and as such not part of the default target. regards, Claudius > > Signed-off-by: Jan Kiszka > --- > meta/classes/dpkg-base.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 50df06d..d4541a4 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -131,7 +131,7 @@ do_deploy_deb() { > ${S}/../*.deb > } > > -addtask deploy_deb after do_dpkg_build > +addtask deploy_deb after do_dpkg_build before do_build > do_deploy_deb[lockfiles] = "${REPO_ISAR_DIR}/isar.lock" > do_deploy_deb[depends] = "isar-apt:do_cache_config" > do_deploy_deb[dirs] = "${S}" > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de