Re: [PATCH 0/6] pre-processing pipeline and transient package replacement

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

On 4/24/19 9:11 AM, Claudius Heine wrote:
> Hi Maxim,
> 
> On 22/04/2019 16.09, Maxim Yu. Osipov wrote:
>> The patch set doesn't apply against current 'next' (it would be more 
>> convenient to mention that this patchset depends on your previous 
>> series [PATCH v2 0/8] Cleanup rootfs creation).
> 
> I did in v1 of that patchset:
> 
>  > this patchset contains some patches that where developed while
>  > implementing the preprocessing image pipeline. They are universally
>  > useful, but do prepare for the next steps.
> 
> But you are correct that I did not repeat myself in this one.
> 
> Maybe we should start looking into how to improve this process wise.
> 
> Would it help to post a git url for each patchset?
> 
> Maybe it might be possible to merge bigger patchset partially, so each 
> commit that looks good, instead of rejecting always whole patchsets?

> 
> The reason why I split patchsets up is that I hope that those will be 
> merged faster and thus lowering the work to constantly rebase everything 
> on the current next. So for example if patch 5 of 8 makes a problem, 
> just merge 1-4 and let the dev resent the fixed patchset containing just 
> patch 5 to 8. If that would be done then I would have no need to try 
> split patchsets up myself.

I agree that sometimes rejecting the whole patch set is not wise - but 
it's up to patch series author to decide how to split patch sets.

Our policy states:

https://github.com/ilbers/isar/blob/master/CONTRIBUTING.md:

 > 3. Every patch should implement only one logical modification. The 
patch granularity is up to the developer. In general, smaller patches 
with clear description are easier to review and accept.
 >
 > 4. Please provide patches that logically belong together in a series. 
And vice-versa, please do not submit unrelated patches as series.
 >
 > Every series should have a cover letter with brief information about:
 >
 > What this series does.
 >
 > How it was tested.
 >
 > Diffstat (git format-patch --cover-letter does this for you).
 >

Definitely, I'll test the whole series and I'll delegate responsibility 
of fixing problems (if found during testing) in patch set to the author.

Maxim.


> Claudius
> 
>>
>> Maxim.
>>
>> On 4/18/19 1:25 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> Hi,
>>>
>>> here is the tested, documented and slightly modified version of the 
>>> previous
>>> RFC patch set.
>>>
>>> The CI has shown that the RFC patchset was not rebuildable. This
>>> was patched by consolidating the  `do_rootfs_prepare`, 
>>> `do_roofs_configure`
>>> and `do_rootfs_install` into just one task `do_rootfs_install` that 
>>> now calls
>>> the functions of both previous tasks as well as the `rootfs_prepare` 
>>> function
>>> that previously was its own task `do_rootfs_prepare`.
>>>
>>> Otherwise I added documentation and more verbose commit messages.
>>>
>>> regards,
>>> Claudius
>>>
>>> Claudius Heine (6):
>>>    split up isar-bootstrap helper and implement pre-process pipeline
>>>    meta: remove transient package support
>>>    meta/classes: add image-locales-extension class
>>>    meta/classes: add image-account-extension class
>>>    doc: update description of image customization
>>>    doc: some fixes
>>>
>>>   doc/user_manual.md                            |  52 +++-
>>>   meta/classes/image-account-extension.bbclass  | 253 ++++++++++++++++++
>>>   meta/classes/image-locales-extension.bbclass  |  97 +++++++
>>>   meta/classes/image.bbclass                    |  30 +--
>>>   meta/classes/isar-bootstrap-helper.bbclass    | 143 ----------
>>>   meta/classes/rootfs.bbclass                   | 176 +++++++++++-
>>>   .../isar-bootstrap/isar-bootstrap.inc         |   5 +
>>>   .../buildchroot/buildchroot-host.bb           |  16 +-
>>>   .../buildchroot/buildchroot-target.bb         |   2 -
>>>   .../buildchroot/buildchroot.inc               |  26 +-
>>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb  |  47 ++--
>>>   .../isar-cfg-localepurge/files/postinst       |  15 --
>>>   .../isar-cfg-localepurge.bb                   |  70 -----
>>>   .../isar-cfg-rootpw/files/postinst.tmpl       |  19 --
>>>   .../isar-cfg-rootpw/isar-cfg-rootpw.bb        |  19 --
>>>   15 files changed, 624 insertions(+), 346 deletions(-)
>>>   create mode 100644 meta/classes/image-account-extension.bbclass
>>>   create mode 100644 meta/classes/image-locales-extension.bbclass
>>>   delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass
>>>   delete mode 100644 
>>> meta/recipes-support/isar-cfg-localepurge/files/postinst
>>>   delete mode 100644 
>>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>>>   delete mode 100644 
>>> meta/recipes-support/isar-cfg-rootpw/files/postinst.tmpl
>>>   delete mode 100644 
>>> meta/recipes-support/isar-cfg-rootpw/isar-cfg-rootpw.bb
>>>
>>
>>
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov