From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6680759771290664960 X-Received: by 2002:a2e:2c01:: with SMTP id s1mr1962531ljs.69.1556093917170; Wed, 24 Apr 2019 01:18:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:59dc:: with SMTP id x28ls1474287lfn.9.gmail; Wed, 24 Apr 2019 01:18:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFvM62TfzqIvXgi0vvaZq/UqxS13jxcCNd5VgYRCr7SA8YWeXReaRLYg77asyXG2IJW7s8 X-Received: by 2002:a19:1949:: with SMTP id 70mr8592167lfz.103.1556093916638; Wed, 24 Apr 2019 01:18:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556093916; cv=none; d=google.com; s=arc-20160816; b=qj+ssg1SfhI7zPU2igmM0FfNYuudqqSzh0fuyQctEuR1BMQXWOZJHkYayvmsvW47rQ nvzGgxBVERCjKKIvbEgorLwkB29Y+g16WScRTk8/2PGTIgO3Lzm9B0EjH4chf9101TSc 3I49WWtqMXWwLoUCvzvL8HJwSPyMqQH3Igj9E10xsS9hiA/Ko9yYXt7RmxDc/3WuoClo MfZ+tc+XOyMP+MvZAVh+EQ1HwqWEGIS7XQJE2EAp/2K+pGlLI9yIBBnpgwqk7QFmj2li 3YOO2zu5U02NyaZR5odwju0SN0bikCwjOofyjy1Q5J0JdQdPTjmrA9KaHLR/GlcDnsPW 85vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=c0Sjzekq9FfuSeYFF7GVdrIIqnwo2+2VXacKNkAXGH4=; b=IVYDE3EKdvEqs4WpEQnldbjG3botbKq8yUeWB+TC9vzJhVxPWL0/v6ypDFRn48Gs/Z 7MsmPulLyzeAELBxf+bqBZlNAI5Goi6/jL11Pjoes51wjkAvvYxz13BK/VSzjo39rbmm RtMLn9RGVc6VHpZCza7+ETFNaBT5DjIykoS39BOVfxi332E1GoFIhNX5JYAlzPcpgcwe fy+uy0zG46bN9ZyoWy6K6V/fFzBeSGAfpdm1GKA3d4hx1bP/IQaZ0jMHOtnlpn/8UgI7 Z5g5Ga48sVBuDLlIIJZa7XA+3yYo6Irai7IuI+I5Cvrd5/xyDzXKItGqBn86/sSKHv7B QbfA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id o16si919271lji.0.2019.04.24.01.18.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 01:18:36 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x3O8IWAl003984 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2019 10:18:32 +0200 Subject: Re: [PATCH 0/6] pre-processing pipeline and transient package replacement To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190418112545.1201-1-claudius.heine.ext@siemens.com> <1732702c-ab31-eca1-e889-43ee78e67428@ilbers.de> <3899d35f-f79d-b459-caf0-ba04e87d18b6@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <6b08e2b3-7b62-a312-e94a-239562191ac2@ilbers.de> Date: Wed, 24 Apr 2019 11:18:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3899d35f-f79d-b459-caf0-ba04e87d18b6@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Mtsnx8MWggUw On 4/24/19 9:11 AM, Claudius Heine wrote: > Hi Maxim, > > On 22/04/2019 16.09, Maxim Yu. Osipov wrote: >> The patch set doesn't apply against current 'next' (it would be more >> convenient to mention that this patchset depends on your previous >> series [PATCH v2 0/8] Cleanup rootfs creation). > > I did in v1 of that patchset: > > > this patchset contains some patches that where developed while > > implementing the preprocessing image pipeline. They are universally > > useful, but do prepare for the next steps. > > But you are correct that I did not repeat myself in this one. > > Maybe we should start looking into how to improve this process wise. > > Would it help to post a git url for each patchset? > > Maybe it might be possible to merge bigger patchset partially, so each > commit that looks good, instead of rejecting always whole patchsets? > > The reason why I split patchsets up is that I hope that those will be > merged faster and thus lowering the work to constantly rebase everything > on the current next. So for example if patch 5 of 8 makes a problem, > just merge 1-4 and let the dev resent the fixed patchset containing just > patch 5 to 8. If that would be done then I would have no need to try > split patchsets up myself. I agree that sometimes rejecting the whole patch set is not wise - but it's up to patch series author to decide how to split patch sets. Our policy states: https://github.com/ilbers/isar/blob/master/CONTRIBUTING.md: > 3. Every patch should implement only one logical modification. The patch granularity is up to the developer. In general, smaller patches with clear description are easier to review and accept. > > 4. Please provide patches that logically belong together in a series. And vice-versa, please do not submit unrelated patches as series. > > Every series should have a cover letter with brief information about: > > What this series does. > > How it was tested. > > Diffstat (git format-patch --cover-letter does this for you). > Definitely, I'll test the whole series and I'll delegate responsibility of fixing problems (if found during testing) in patch set to the author. Maxim. > Claudius > >> >> Maxim. >> >> On 4/18/19 1:25 PM, claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> Hi, >>> >>> here is the tested, documented and slightly modified version of the >>> previous >>> RFC patch set. >>> >>> The CI has shown that the RFC patchset was not rebuildable. This >>> was patched by consolidating the  `do_rootfs_prepare`, >>> `do_roofs_configure` >>> and `do_rootfs_install` into just one task `do_rootfs_install` that >>> now calls >>> the functions of both previous tasks as well as the `rootfs_prepare` >>> function >>> that previously was its own task `do_rootfs_prepare`. >>> >>> Otherwise I added documentation and more verbose commit messages. >>> >>> regards, >>> Claudius >>> >>> Claudius Heine (6): >>>    split up isar-bootstrap helper and implement pre-process pipeline >>>    meta: remove transient package support >>>    meta/classes: add image-locales-extension class >>>    meta/classes: add image-account-extension class >>>    doc: update description of image customization >>>    doc: some fixes >>> >>>   doc/user_manual.md                            |  52 +++- >>>   meta/classes/image-account-extension.bbclass  | 253 ++++++++++++++++++ >>>   meta/classes/image-locales-extension.bbclass  |  97 +++++++ >>>   meta/classes/image.bbclass                    |  30 +-- >>>   meta/classes/isar-bootstrap-helper.bbclass    | 143 ---------- >>>   meta/classes/rootfs.bbclass                   | 176 +++++++++++- >>>   .../isar-bootstrap/isar-bootstrap.inc         |   5 + >>>   .../buildchroot/buildchroot-host.bb           |  16 +- >>>   .../buildchroot/buildchroot-target.bb         |   2 - >>>   .../buildchroot/buildchroot.inc               |  26 +- >>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb  |  47 ++-- >>>   .../isar-cfg-localepurge/files/postinst       |  15 -- >>>   .../isar-cfg-localepurge.bb                   |  70 ----- >>>   .../isar-cfg-rootpw/files/postinst.tmpl       |  19 -- >>>   .../isar-cfg-rootpw/isar-cfg-rootpw.bb        |  19 -- >>>   15 files changed, 624 insertions(+), 346 deletions(-) >>>   create mode 100644 meta/classes/image-account-extension.bbclass >>>   create mode 100644 meta/classes/image-locales-extension.bbclass >>>   delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass >>>   delete mode 100644 >>> meta/recipes-support/isar-cfg-localepurge/files/postinst >>>   delete mode 100644 >>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb >>>   delete mode 100644 >>> meta/recipes-support/isar-cfg-rootpw/files/postinst.tmpl >>>   delete mode 100644 >>> meta/recipes-support/isar-cfg-rootpw/isar-cfg-rootpw.bb >>> >> >> > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov