From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7327988128800571392 X-Received: by 2002:a05:6512:752:b0:50e:30a8:4c8e with SMTP id c18-20020a056512075200b0050e30a84c8emr1341965lfs.43.1706782009470; Thu, 01 Feb 2024 02:06:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:200c:b0:510:1773:d124 with SMTP id a12-20020a056512200c00b005101773d124ls366390lfb.2.-pod-prod-07-eu; Thu, 01 Feb 2024 02:06:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkuBIQjM2uuh1C40JGWtC8p1ORjCfrv3eJO0KDLVAVE7AMAwwhv+kVBbdhWCG343NUmJ7+ X-Received: by 2002:ac2:4a6b:0:b0:50e:630d:7364 with SMTP id q11-20020ac24a6b000000b0050e630d7364mr1444552lfp.28.1706782007038; Thu, 01 Feb 2024 02:06:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706782007; cv=none; d=google.com; s=arc-20160816; b=VL3kfjpr/MI9D8jHrONMdsFXMQBlqR0DNiJOTqZGfFIg71Y7nXMyda1AbW1qaI8Rq7 xj95xybqj/BZfKQr7D542y/mA8BYN4y43RazwIVkm4eJjUYjfG+OT06Lu7VKoDR+geeJ OebRjlcYnolfMSB9Zx/V4Ahuv3VKVC+pOwbshUD9ZW+uwEELR6IT7JaFw3dpz6oesvm3 PrliCemF0TekzU6CyR+u1LL4jEm8qHDG5we9/aignFmNW9NUKt4jps/zwOaufdnkhDLs 9E+YUD90CLdEbTlqBad78RrJ0qTR+2gxnMovsgoPtWH9rq9SnkB4+nSd9eUccmPaQcYN tKBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=RFTw8edgiMLZGhLbV5dg85Fo1ivKPlVcuCOkk5Q/Yi0=; fh=Z+a+9tsXndnqOhrRNZMgiSjIjfsAxlrlsYbIGxpNXv0=; b=x5+6FaohhX/+NPXH+XtvDEzoCvVivRW2N166e16mIL15pzSx8JrAs+XAKdh9Fz5h3X Vx+daLL0n2D7N+djNz5wdV7fZTsvggvBDRXFbb25gqhj6SaOZ9dFrGOiM68RB6ObKrhW +I00FfbTNiqnpVtBAyYv2nhKAgl2tlqD7mCUvL+lNokYAxTbaR7Lyee+LgAPxYnDwLzE dQyuqAKUrRHp/QBk0GgeUP1PGzQKu1f5rR6GHLWn+82GPamVfRsdZdwnv5/vH0IfgKJZ tlmvgezpNDQ8DxZYF6HKT17ORQPwfmlsQPvxA0e4lV2OlMwFkc7GYhLQEUBMfOvG75aj vL+w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de X-Forwarded-Encrypted: i=0; AJvYcCWbgn5Fdm3o5zr17p141qTAmQMuqT5xidvaavh2oUzXurMjNOjp7wy+OmQeSisMYUwSEyI4YN+fBqs8qEXYoZ5skS80oyy1yAPerFU= Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id u6-20020ac258c6000000b0050e7c496b6esi482707lfo.13.2024.02.01.02.06.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Feb 2024 02:06:46 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 411A6iFs017752 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Feb 2024 11:06:45 +0100 Message-ID: <6b360e25686efe1ed78149b0a656a0c8b518ce48.camel@ilbers.de> Subject: Re: [PATCH] wic/plugins/bootimg-efi-isar: Use initrd from source params From: Uladzimir Bely To: "MOESSBAUER, Felix" , "quirin.gylstorff@siemens.com" , "isar-users@googlegroups.com" Date: Thu, 01 Feb 2024 13:06:13 +0300 In-Reply-To: References: <20240125105628.2041417-1-Quirin.Gylstorff@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: XlDMsnnJYR5I On Thu, 2024-01-25 at 12:06 +0000, 'MOESSBAUER, Felix' via isar-users wrote: > On Thu, 2024-01-25 at 11:55 +0100, 'Quirin Gylstorff' via isar-users > wrote: > > From: Quirin Gylstorff > >=20 > > This fixes the issue that you can add a initrd with the source > > params > > but it will still boot the initial initrd. > >=20 > > Signed-off-by: Quirin Gylstorff > > --- > > =C2=A0meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 5 +++++ > > =C2=A01 file changed, 5 insertions(+) > >=20 > > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi- > > isar.py > > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > index b934d0c7..27d40756 100644 > > --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > @@ -185,7 +185,12 @@ class BootimgEFIPlugin(SourcePlugin): > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 title =3D source_params.get('title') > > =C2=A0 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tem= p_initrd =3D None > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if = initrd: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 temp_initrd =3D initrd >=20 > Why not simply temp_initrd =3D initrd ? >=20 > Anyways, the logic itself is fine. >=20 > Felix >=20 The comment is not yet addresses, since the patch itself passes CI and can be merged. What would be better for us to do - merge it "as is", wait for v2, or include changes proposed by Felix without waiting of v2? > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 kernel, initrd =3D > > isar_get_filenames(get_bitbake_var("IMAGE_ROOTFS")) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if = temp_initrd: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 initrd =3D temp_initrd > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 boot_conf =3D "" > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 boot_conf +=3D "title %s\n" % (title if title else > > "boot") > > --=20 > > 2.43.0 > >=20 >=20 > --=20 > Siemens AG, Technology > Linux Expert Center >=20 >=20