From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963333394071552 X-Received: by 2002:a7b:c771:: with SMTP id x17mr8626432wmk.131.1630490526150; Wed, 01 Sep 2021 03:02:06 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:5120:: with SMTP id o32ls3236995wms.0.canary-gmail; Wed, 01 Sep 2021 03:02:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+HMvVeLN1PGyRqCEKvINxjSRuAEzFaIayWGt2oXiPv86OE0z2cvcVVS+E0tIxLN1A29C3 X-Received: by 2002:a7b:c052:: with SMTP id u18mr8879093wmc.105.1630490525084; Wed, 01 Sep 2021 03:02:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630490525; cv=none; d=google.com; s=arc-20160816; b=bD5KuLkJERVk0iKy99kVbvhmhFu1wSzKMi/ojz0a2EL94CUuWWm4w0/uTQRBTCNAWp 5C+B5GOeH/R53hRhuU39ByrJKae449P13zuHIJBJbJWsXhZw3mjb8+Zjak/z37s3Xd8t zlbpfoHb3OvfHnb0q5aj41mkcCyFoB0k1rI2JRhjitBxfOyTpvxtmNqNc+VKZ8FhJ4xK kZAxqq0jwgzBg3gUqUAwtIozAHa17puFYTxjVfhLemVB0LbtGeR+uu3LPlSrv8H2K58d WYsnRT5MImnYru3tbCa4Ljanj6epZBIYMEb7/mUEgMENixIWFgT8wtMtOiFDHP4ibCBZ n1lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Ouul5bTFO3Njn5rHCtu6yQ0ekAUWAGDB7nBfdwAeyM8=; b=AOtKE9p+U16I+lXJbq4rT3avaLn0g9333vKXVv+9iSF9KhVIevDCD+52fj6O0S7b3A S3dKOomV6u2IpTgb0p0vmNK0yNBQh6AAl2wEEhbhghR7xwPA2ivNnDnBi5idgoGOK+UT oPmdRJ3WSDR1A8L4JsSc6ttpeLAC4L0Ni/lxdXLQ3oVY+Y+a1yIMwgfmU0YOnzLGWkQO MD+wTCTdsH4sSXEOP6zJzY3QZzMuowJzS5Vzihhev8Lz0D16dflf+mEMm6YsIdoc/Ce6 y4Cyer7pncuW7Nb8ZUQlJHBkQqHdIhtDw7yBcLlH29Lkj64UY2VI64dpINdUWgy7oIjx matg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id s68si321848wme.1.2021.09.01.03.02.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Sep 2021 03:02:05 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 181A247f014538 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 1 Sep 2021 12:02:04 +0200 Received: from [167.87.73.68] ([167.87.73.68]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 181A2495000887; Wed, 1 Sep 2021 12:02:04 +0200 Subject: Re: [PATCH v3 08/14] bootimg-efi-isar: Fix serial console setup for grub To: Henning Schild Cc: isar-users References: <20210901111109.61ea6299@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <6bd4d057-97c6-2cbb-ecb9-f8bafbbb34b2@siemens.com> Date: Wed, 1 Sep 2021 12:02:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210901111109.61ea6299@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 3AafCJ97BcnS On 01.09.21 11:11, Henning Schild wrote: > I am currently looking at re-forking that efi plugin to get it down to > minimal isar specific changes. This patch looks more like upstream > worthy instead of isar specific. > > But in fact on a recent (bullseye) amd64 grub comes up on serial > without those lines. Any clue which DISTRO/DISTRO_ARCH needed that? > 2019 - likely stretch, likely x86. > I am tempted to leave it out in the re-fork. > Just test it, at least also on buster, then decide. Jan > Henning > > Am Wed, 16 Jan 2019 06:32:21 +0100 > schrieb "[ext] Jan Kiszka" : > >> From: Jan Kiszka >> >> We were lacking terminal_input/output to make the serial console truly >> work. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py >> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index >> 1ca200f..c6a6a02 100644 --- >> a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ >> b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -65,8 >> +65,10 @@ class BootimgEFIPlugin(SourcePlugin): # Create grub >> configuration using parameters from wks file bootloader = >> creator.ks.bootloader >> - grubefi_conf = "" >> - grubefi_conf += "serial --unit=0 --speed=115200 --word=8 >> --parity=no --stop=1\n" >> + grubefi_conf = "serial --unit=0 --speed=115200 --word=8 >> --parity=no --stop=1\n" >> + grubefi_conf += "terminal_input --append serial\n" >> + grubefi_conf += "terminal_output --append serial\n" >> + grubefi_conf += "\n" >> grubefi_conf += "default=boot\n" >> grubefi_conf += "timeout=%s\n" % bootloader.timeout >> for part in creator.parts: > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux