Re: [PATCH 1/7] dpkg-raw: Respect file permissions defined by recipe

[Jan Kiszka <jan.kiszka@siemens.com>]

On 09.01.19 23:37, Baurzhan Ismagulov wrote:
> On Mon, Jan 07, 2019 at 02:28:47PM +0100, Jan Kiszka wrote:
>>>> dh_fixperms overwrites the permissions do_install defined carefully.
>>>> Skip this step to avoid that.
> ...
>>>> --- a/meta/classes/dpkg-raw.bbclass
>>>> +++ b/meta/classes/dpkg-raw.bbclass
>>>> @@ -56,9 +56,11 @@ EOF
>>>>    deb_create_rules() {
>>>>    	cat << EOF > ${S}/debian/rules
>>>>    #!/usr/bin/make -f
>>>> +
>>>> +override_dh_fixperms:
>>>> +
>>>>    %:
>>>>    	dh \$@
>>>> -
>>>
>>> I think it is not a good idea to do that in general. While you might
>>> have found an example where dh_fixperms caused problems, there are
>>> probably many where it helps. Say people use "cp" to fill ${D} or
>>> "echo" to fill ${D}/bin/
>>
>> I'm open for better suggestions.
> 
> dh_fixperms -X from a variable / file?
> 
> override_dh_fixperms in a conditional makefile include, if exists?

Something like this?

diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
index 10fb1b9..fa584ee 100644
--- a/meta/classes/dpkg-raw.bbclass
+++ b/meta/classes/dpkg-raw.bbclass
@@ -53,11 +53,14 @@ Description: ${DESCRIPTION}
 EOF
 }
 
+FIXPERM_EXCLUSIONS = "${@' '.join(['-X ' + x for x in d.getVar('PRESERVE_PERMS', False).split()])}"
+
 deb_create_rules() {
 	cat << EOF > ${S}/debian/rules
 #!/usr/bin/make -f
 
 override_dh_fixperms:
+	dh_fixperms ${EXCLUSIONS}
 
 %:
 	dh \$@


Then the user would have to specify the files to be excluded with full
paths:

PRESERVE_PERMS = "/root/.ssh"
PRESERVE_PERMS += "/etc/network/interfaces.d/wifi"

> 
> That said, I think the right way would be to create proper source packages
> downstream.

Cannot follow that idea yet: What would be the interface?

> 
> FWIW, meta-eid has a PoC for dh_making a package from bitbake, but one could
> start with manually debianized packages first.
> 
> With kind regards,
> Baurzhan.
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux