Re: [PATCH v3 5/9] Move buildchroot mounts into dpkg-base class

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-14 10:09, Alexander Smirnov wrote:
> On 02/14/2018 11:52 AM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This avoids the unfortunate setup_mounts task which is either not
>> executed on rebuilds or causes excessive package rebuilds. We just need
>> ensure prior to switching into the buildchroot that all mount points are
>> populated. The mounts may race with parallel build, so lock-protect the
>> check if they are needed and their execution.
>>
>> Note that the more beautiful syntax using ( flock -n 9; ... ) 9>lockfile
>> as described in the flock man page does not work in bitbake shell
>> functions.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Changes in v3:
>>   - use flock instead of unreliable check pattern
>>
>>   meta/classes/dpkg-base.bbclass                   | 11 ++++++++-
>>   meta/recipes-devtools/buildchroot/buildchroot.bb | 30
>> +++---------------------
>>   2 files changed, 13 insertions(+), 28 deletions(-)
>>
>> diff --git a/meta/classes/dpkg-base.bbclass
>> b/meta/classes/dpkg-base.bbclass
>> index a45fbce..895ff26 100644
>> --- a/meta/classes/dpkg-base.bbclass
>> +++ b/meta/classes/dpkg-base.bbclass
>> @@ -2,7 +2,7 @@
>>   # Copyright (C) 2017 Siemens AG
>>     # Add dependency from buildchroot creation
>> -do_build[depends] = "buildchroot:do_setup_mounts"
>> +do_build[depends] = "buildchroot:do_build"
>>     # Add dependency between Isar recipes
>>   DEPENDS ?= ""
>> @@ -20,11 +20,20 @@ dpkg_runbuild() {
>>       die "This should never be called, overwrite it in your derived
>> class"
>>   }
>>   +MOUNT_LOCKFILE = "${TMPDIR}/buildchroot-mount.lock"
> 
> With this name lockfile will be shared for all multiconfigs. I realize
> that it's small, but unnecessary serialization of parallel parts.
> 
> Would it be ok?
> 
> MOUNT_LOCKFILE =
> "${TMPDIR}/buildchroot-mount-${DISTRO}-${DISTRO_ARCH}.lock"
> 
> or
> 
> MOUNT_LOCKFILE =
> "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot/mount.lock"
> 
> or
> 
> MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}/mount.lock"
> 

Yes, good point! Feel free to pick what ever is preferred when merging,
unless there is a reason I need to resend the whole thing anyway.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux