From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6521574339082452992 X-Received: by 10.28.129.195 with SMTP id c186mr464808wmd.10.1518599793107; Wed, 14 Feb 2018 01:16:33 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.169.243 with SMTP id b106ls5172064wrd.13.gmail; Wed, 14 Feb 2018 01:16:32 -0800 (PST) X-Google-Smtp-Source: AH8x226V0xoC408GB8Vadv1U9ba7weyCUCfafpLrvYfsMIYj/luAtdjYAGejtBrNmPUiNnFUxTbQ X-Received: by 10.223.184.131 with SMTP id i3mr429410wrf.29.1518599792484; Wed, 14 Feb 2018 01:16:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518599792; cv=none; d=google.com; s=arc-20160816; b=bECoJxDAnf85o0G8WjetLdGOKAnS/fldKtI8ziYTEE+bl713MQbUFJgFeF+fMIcV39 P6xBiCGLmBp1iBpbcwCPO+SUetdzXJGE1VAEmVGUkA7dHgt61hMja+dqVRWosFso4Os2 wnjMYndaoaYhXiEXMY3HOaYfukMGiQiMRXmpwLGHPbrU+ohU4u43We0B/8i0QPebovsa 4H8qepM0rSBpQV6kwOsDCMRijzh9GeBE2Xz9W9iZUMlyRpr1B2RE1qANC51ehEa3povI Dp0RiavPHXX7rQwWCcphRSuBnndQ1UvS8/AWDkfPXzhhaoKcAs9al6l9qsPB26gi38WX O/3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=o/rR9gkG/1NJBcZoAaZNDSAtb0IIIbORy4IWLwGYPOg=; b=BVcTwPJbyz5VAf9feNIuHpfxTH9KhR2/3AD4TMtjAyF2KGYPoD5QHqV4CvjGFi9aJI zKvLhlTU5jdvFCdCX5ScnWyx1RidxWEQfvEnhR6OZgaO8PGx7V2pSPTR/42t4kLrotHq 5WgW/8IhbohFMF9knlhQjf/fpEcyW8id8Q6QuOMAwOd+vS6hhfLhF/4PYjsgEYJqkmjp erf3gZSyh0tCOQgu9gQ0plOjLr4/oiQjO7jsalZEO2PxvhjwwS7kTm/w+cS8s1eyVywA UjppynKmqRSHVv6gRcLtVn6kCdU44hydq+8E7Suo+dCgz1+nQ92UJbvqCYhm1sIvyJ4I VYpQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id f8si510340wmc.2.2018.02.14.01.16.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 01:16:32 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w1E9GVps019526 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Feb 2018 10:16:32 +0100 Received: from [167.87.36.169] ([167.87.36.169]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w1E9GVNu024161; Wed, 14 Feb 2018 10:16:31 +0100 Subject: Re: [PATCH v3 5/9] Move buildchroot mounts into dpkg-base class To: Alexander Smirnov , isar-users References: <697b09bb60a515430f655989e859263922148264.1518552327.git.jan.kiszka@siemens.com> <0ce19aaa-263d-7d13-18ea-5a665f59852d@siemens.com> From: Jan Kiszka Message-ID: <6ca7a9c3-935f-038e-3860-27147bc03406@siemens.com> Date: Wed, 14 Feb 2018 10:16:31 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: KbMY02uAleWz On 2018-02-14 10:09, Alexander Smirnov wrote: > On 02/14/2018 11:52 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This avoids the unfortunate setup_mounts task which is either not >> executed on rebuilds or causes excessive package rebuilds. We just need >> ensure prior to switching into the buildchroot that all mount points are >> populated. The mounts may race with parallel build, so lock-protect the >> check if they are needed and their execution. >> >> Note that the more beautiful syntax using ( flock -n 9; ... ) 9>lockfile >> as described in the flock man page does not work in bitbake shell >> functions. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v3: >>   - use flock instead of unreliable check pattern >> >>   meta/classes/dpkg-base.bbclass                   | 11 ++++++++- >>   meta/recipes-devtools/buildchroot/buildchroot.bb | 30 >> +++--------------------- >>   2 files changed, 13 insertions(+), 28 deletions(-) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass >> index a45fbce..895ff26 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -2,7 +2,7 @@ >>   # Copyright (C) 2017 Siemens AG >>     # Add dependency from buildchroot creation >> -do_build[depends] = "buildchroot:do_setup_mounts" >> +do_build[depends] = "buildchroot:do_build" >>     # Add dependency between Isar recipes >>   DEPENDS ?= "" >> @@ -20,11 +20,20 @@ dpkg_runbuild() { >>       die "This should never be called, overwrite it in your derived >> class" >>   } >>   +MOUNT_LOCKFILE = "${TMPDIR}/buildchroot-mount.lock" > > With this name lockfile will be shared for all multiconfigs. I realize > that it's small, but unnecessary serialization of parallel parts. > > Would it be ok? > > MOUNT_LOCKFILE = > "${TMPDIR}/buildchroot-mount-${DISTRO}-${DISTRO_ARCH}.lock" > > or > > MOUNT_LOCKFILE = > "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot/mount.lock" > > or > > MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}/mount.lock" > Yes, good point! Feel free to pick what ever is preferred when merging, unless there is a reason I need to resend the whole thing anyway. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux