From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7345378448314990592 X-Forwarded-Encrypted: i=3; AJvYcCUXKGv1+yBEVp0YSztotUEHXuFzC5pVZDAm09C7ZzDfVxYk0K15F88g4VEx5ckoY2zZgdVc3BIBOgGKughofYjk+PeeUA8wroscoh4= X-Received: by 2002:a92:c269:0:b0:365:1dbb:a30a with SMTP id h9-20020a92c269000000b003651dbba30amr3229916ild.3.1710231066631; Tue, 12 Mar 2024 01:11:06 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6e02:2185:b0:365:c70a:a9ff with SMTP id j5-20020a056e02218500b00365c70aa9ffls2662189ila.0.-pod-prod-01-us; Tue, 12 Mar 2024 01:11:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUPt2qcdO3EBeWtKl1A2ARv52/B3WOjSK1EXIH67VdptcLRF74Nb+3IhpxcHsrSSYeMAQUUWRjnqc9WHCCnENUx2R8I3Hd4ZbSAQlM= X-Google-Smtp-Source: AGHT+IGB7zByi5NjTj4jaD8E4nBFkj5Gkf1nHcl/wwrhoCXaTB0U2Vd6WLinFo6U9EtTIVGcuW/I X-Received: by 2002:a05:6e02:1d03:b0:365:1749:cae5 with SMTP id i3-20020a056e021d0300b003651749cae5mr3145983ila.19.1710231065809; Tue, 12 Mar 2024 01:11:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710231065; cv=pass; d=google.com; s=arc-20160816; b=DeBCtnYLE84jzRxgj5gSq3UaShp9R+GXMf8qhliqIhA+d0VpO3rFZjVEZrZz3+kwNg /HnUX+2ihP0uPv6cF5YsTmFCx+835WCVrXSmnusyqoL8BrHjZsTmv3CVvrYaAP2srqlm QRa4IUt1SHQn667qSuf4xbWdZIOro9p+0DfD4fp1yvodzw8eYEywpgpZt758XRlqJoeV zAzoImoiXaILF/M7ewbdmRZ0p1rDnF5uok/EJTroAeUcWuOFujP+CN0reArNsAVF/cv4 WX6i5qc6Q84ZzsDZybQfNzbvI+tJq3wCKHuTIi58DGvrlaDW3lqQwlJpTr9FpSP5yMIY AaKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=Z+tC9TeSUnjysmoERm7VQed31C012uZ7gI0szgO86XU=; fh=1x/T85rXr8yhgzXWAa7zssXnuyt2jGlhJYPIGFWr6UE=; b=c4hdhRk1bTkdjyKqjGBVdRCh0w21UcsApESLFcUOG4pgdY+m0+iCLkk5vOUckaoTMV VxBrNHibs7DNNJiuivZNkqMKKOicK0zYENMXgu3AeyxMXI19kzJ1LNLm7vUDHc2mppGG cmOC+wHJDnuKEWZMLRXrMbXLEkSeraFhBTh67qX+dZdb8/lW6XcCPB+F23w/UNKK/yfl AFhyPb3CrPO7gPkJWgb2xksWrCer51z3QovHl1paVZ0YJMx543thaBb9yH5NTZB/DdhA sD9BDthN7czSegFXBGprU7L34n4XHLDRpQhGO/MK8JBtIOY6P64KvvxE6rVo8jRC7RAe 2rHA==; dara=google.com ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ldwONmrz; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2612::600 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20600.outbound.protection.outlook.com. [2a01:111:f403:2612::600]) by gmr-mx.google.com with ESMTPS id c4-20020a92cf04000000b00365843633c1si545314ilo.0.2024.03.12.01.11.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2024 01:11:05 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2612::600 as permitted sender) client-ip=2a01:111:f403:2612::600; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ldwONmrz; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2612::600 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0LY+7q8wmRgrmBHbyZv8l68Tw1wn2YQmlwzryozm4sZXaADhi/h1ZCytCny1oXfz1qlIuGdGQ5Uqyistno2MVXVsXLmAThI1ELMgoojkBpFtmkYRqNWpknwil5PDTE0QleVjSaBSaAdSJ4QsJpSH1Oqryy0rj7bGoVl16WaGvWATS5ObiEa9KZg3EYDJMAltOjDsFRsvmZmBgo9OPR4unuxtrlM6XbackhsntB//DcmVpVA+1DVFU8M1ru/B/VgnboeYt48hr2PeBBmEu35BsQGrkzIlMnHWxFiEWc/1f0kY/KZGry1OzS9YW5dSGZ7QgNAXTDbVUBz29P748lEXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z+tC9TeSUnjysmoERm7VQed31C012uZ7gI0szgO86XU=; b=JY3ZQ/AmJXBuvZuEArBhTTjNKEB4PufM8QjGjNNPDVBtYy7zoAHAUIL2tE3kqHzttb3OFmSMbun8h/pgDIrjG1Bj/RJwnzNGDOvOpXGm/mJSA7Tnkbr8veHd9lnpszQV6tsC8xZxx/XLc7LlspE/ADYetkfbIcn6gfTVy/NeR6ZU7ZcuD46VFLfSOV8pi4mCvlVg+xM1ni1t0oeVebFHETOLaHdSKgljjyS6wAWpkRishO1KDBVxEQ9O2/wHjYdjil3mQ2YmhtVlElUgNQOwQQ2F5Y2F+sZCIbYsJHOCUJoq6tVAlENgnoAN9jLHXdM857sX48FHPETspUPYU8mnww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+tC9TeSUnjysmoERm7VQed31C012uZ7gI0szgO86XU=; b=ldwONmrz76dXLZpesA5hvBolPrMEpOcUWkr5EeCa2WVWBALn5AyMBBEp1/UZ6FTOJ1S4624NW4egVWA/gGrM4y46QSMeNlNb+VOaRLNiSj8k8X6BHczCeYXd5W79Yoyh7pLVJ2eyxVZCRykpcgdJFdUIFg7QvZ8MvB4AXcUZbg8j5ZPUwOycBT52RVPuDWLV0DP6ZHdASPQ+LV+rK9nZGd6b+jb/p/D/5pYm84eKCl9Fy2isaQ//VGqZ+U7lN+wsJIxCqLhzN/JfvWkX2nB3u4/h2lbBC2Jd5Up/QqxoSh/H9711/K4kM1PVs/l8bsOJzx4lorWZFa4QUqWaFKRBZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AS8PR10MB7279.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:615::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Tue, 12 Mar 2024 08:11:03 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe%3]) with mapi id 15.20.7362.035; Tue, 12 Mar 2024 08:11:03 +0000 Message-ID: <6d0596bc-dd71-4521-af1a-4cb77a7c63d1@siemens.com> Date: Tue, 12 Mar 2024 09:11:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] image: limit search for *.core to regular files Content-Language: en-US To: Cedric Hombourger , isar-users@googlegroups.com References: <20240312073935.331457-1-cedric.hombourger@siemens.com> From: Jan Kiszka In-Reply-To: <20240312073935.331457-1-cedric.hombourger@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::14) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AS8PR10MB7279:EE_ X-MS-Office365-Filtering-Correlation-Id: 3386e746-51da-4af3-2a18-08dc426bf586 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OGKzAz6Ro8xeDsNIB/QwWF9MB+N43o20DdcztJ5vYj+rd+DXNYj22A1VRGVbklPnxV+tlfBbaY9YJ6qY0gHCeLRfa23M060pCGofnP5o+YRcceoiMV6VxQGX7hZIe8FtWMD+A1zn6R+4g69n9VR5tlNAy01E1UV7VKQw7wvVbI3TWyFdu/NRVMv8YwXAgjHFGvQRqHRb4f/sUNcAKoD0UvxL1ALF8YehxVXkfYimACKVBfMu8Fyrj1qxk5Li4AwjevSIuNGdYiNBCn8cJj0XJUmkES8aM7GQSO15dAdUEBBqcgx5A5KdvKWWWbuEWGP+SUEWipOH9R6S8TAFm6LplbYykny5ZinQbMwpv41ZU40E4JiYhTBk8xoF6P8xIkuPLE9wGxhBjQwrPDZZw6zWSBK+bioljcTOzr50ieR0gAHrLBKKdmy3i4B+Wiji2WomySnpD8eoK/5aj4NFJ+90Xvpdx7jFayEhC5bwk9+TY94mF/Pw+ar0cXQhDl+Ar1gV2x2WBeLpRQHU2H030+grllq5SywrtkdLm50eiObgWXPuCSiJaPZJCpW1A3f75bJLHC07IP7JwXiC717fVxntWMWmj3pBJxkJrPT6km2e1Tt8hcv9UUfgd/awAem0FRPIb4epoq2cNsQqT4lG49cKvsFX+QPPlE6vh2OeBRYMUCk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWVoVnVtOGtURVlQZE9sUWVSY29YcWhnSG9wOFNHU0t4dDNVQzlad1V6dUtv?= =?utf-8?B?d1dzWENFM0svUjRvT0FSZ0M3bmZhSWZpVEwzR2JyaDlOY0RLOENzVU1pWWZl?= =?utf-8?B?L3ZuMFhRN1VIc1FWR1k1MFhaVlNjUjZ1M1RlSmo1NnFSYm4vbHhnUDVscmQ3?= =?utf-8?B?cS9IaGZUL2lKN0JpdkRlanc5a21TWFJmYk5TQjB6ZjhvRDQyTVNTTVU2OTI2?= =?utf-8?B?OVkvckFEQnUzOVZmM1czMGJJWkZRUVZ2TFIrVjBOa0FhUGhyNXJjWEkycVJ4?= =?utf-8?B?Ukc3YnJBeTVtdXdCeldnVlNRZHFnTHJ1Vld4MjFxVitZVFJFTE0yN2ZmM2FP?= =?utf-8?B?Smd3RmhtZnNWRnF6WHlaMkduaEJjSkI1RUo3RVJvMnVhWjZBczFMY3cyTXQ2?= =?utf-8?B?WUhjVmx2TnI0VEhCRGFoZzRKRTY3ellKeklPcUVua1lEQjBlbDZ3c25HZ1Qv?= =?utf-8?B?MXhGVzVmaGsvSHVRMGxrVWVYUUl1S01tOEtrSUVhdWRKWEFiMnJSN2IrUnVj?= =?utf-8?B?alVUS0ltR3FRMTM4cktSOTVQNDdVYmdZV1hrS2cxczNHR21EU1YzM09nNjZh?= =?utf-8?B?aVZkTXJqU0Mrb2x3aDZGM3VJNEl3bnd6dzJhOEtJeE9QS3E5VEFiVlpOcjV2?= =?utf-8?B?QkJkaUF4VTNFekNKUEJocHRZeUwraWx2bXlGM0xRNStwYURTNmp2RGp6Y0R0?= =?utf-8?B?TTVURitwN2dxUlFGbE40SHFPMFE1ZW1DSU4zVURPNXgwRjNXOGNKV1AwTUtQ?= =?utf-8?B?VGNsZXpqUUxNTHQveVdDZUZPdVhVdEFoeGNLZEFlam5WMlIyU3BTanNqTDIr?= =?utf-8?B?ejZvZ01nR0ZPYU9BQWR1ZzJKQ2NYR2U5Vi9yTC9VUHFXT09ScW1QV0VtQngz?= =?utf-8?B?SFVlN0xtRnJCZHVtTEIrSVlIQ3YxdVhEQ0V3T0VpQTlFZFlCQjhkS2czTlUw?= =?utf-8?B?TG00TjNOZFhQa3ZKVkVtMk1jSFhTWTA4STV4dHpvZ0QwNlhhdmE0QXVFL3Fu?= =?utf-8?B?YmVZVk10SjhZaGdFanJBSFA2b01PTjdWak5IZURtaVMwejZCaXhSTmg1WjVU?= =?utf-8?B?RDE4OU9nUDNVemhDTDZUdlRabWptOWdqTzNBTERqdFZ2VENTcHZsQmZaSW9h?= =?utf-8?B?eWpJVk1KSlBzdGxwUENrTHJQMzdtS2padkttT0dEd3BIdmNVNkNYdlpjVnBO?= =?utf-8?B?UExOT2M3WlB6Z1E0a0VTZmpMVm10bjBKVUFCYVhRZ3dKRE9TczlyRHdBRFNJ?= =?utf-8?B?ZGRHUmVHLy9pRDI3RHNTWm5SakQyVWVkSlRvay9EVmZURUJSNHlPeHpmNGlU?= =?utf-8?B?TGRDOVU4UjBOY0h0NENNcEFDQUczUXl3aUFUYXI4SlFTWHA1cmR6eFNYd1cy?= =?utf-8?B?Vit5dTRnSGxpM3pzT0hjdG5tVnhrK210MHcwNXdZVSsxMXQ2NS9QcS9leXBl?= =?utf-8?B?Tm0rUkY0b2tKVjlZRTBOK1gyZHBqZ0NVM0JDb0FMSW1lM0JrTVYvMWF6aHVZ?= =?utf-8?B?N2phSDlyM1hOVldGaXFIcEwvQ2hmK21icWdIU1F5THpUTys3elpUL05QeWoz?= =?utf-8?B?YkNPbEFqb0dUcTY4VjBNMTM2RCs4QnAxa0pGKys1eVhlVVpsSEEreXVhZFFk?= =?utf-8?B?eUQvcCtrVkVOQzRWaGZnQy9yNWVTZ2lWTjdwUHVUREtRL3JvUWp5VkxIOE40?= =?utf-8?B?VWRlcmhvTnh1U3hWYUpwbGUveXJNenBCTlR4VEYxREVKR01BcXZzZEk4eUZ5?= =?utf-8?B?R3hTaWV4OHltQUo0aTQ4UjF0eEkyUmljZjRBU2ZWdUNIVlhLREhmY1FOK2Za?= =?utf-8?B?c2kxdnY5aFQwWUJQTG84eGJzUUF2dXF5RytOOUlEQWJ5R0xYV1NDWmpUZDc3?= =?utf-8?B?UlhxNldnZHE3MWZFZFpIb2ZDV1IyNFdLdklNZVU4Z3JSdW4wZXRKU0NGa0l2?= =?utf-8?B?eFdXUHdLSGo3L1dwa0M2aG5XaW5VWkVXK1NzcmRQSGpHbU52T3IyUk9EeWxl?= =?utf-8?B?QUYwaVJqaG1ncjl5SWJrbDcwdHhOQUpRR1N3bVozOGlET010VnQwNnR3WXE4?= =?utf-8?B?MDhBb1AvQmlhaWVnL0JZWDJ4TVlROWF2ekVQVGNFdWdIUmJoWFp5ZXZMcEI3?= =?utf-8?Q?D5fKiefII5Mdh0jMJdGkhCc0B?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3386e746-51da-4af3-2a18-08dc426bf586 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 08:11:02.9436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XHUWf4vDUy2X4UcAfzPBsHdepsL4/KjROqj4/sCljaHApbs1jso9niQ5E9YD8aDyFtZ6AmVORuCkZH0sqo7qPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7279 X-TUID: gxC0cL7Ls0nZ On 12.03.24 08:39, 'Cedric Hombourger' via isar-users wrote: > Code to search and delete core dumps in the build tree assumes that > the build host has a kernel.core_pattern setting which would result > in core dumps having a .core file suffix: this is not guaranteed. One > may also argue that the build should have failed if a process executed > under qemu-user got to crash (and we should check why qemu has crashed > and fix it). My vote would be to kill that code but for now, make it > less wrong by restricting the search to regular files suffixed with > .core (this would at least stop isar from moving directories such as > "org.eclipse.equinox.p2.core" out of the image). > > Signed-off-by: Cedric Hombourger > --- > meta/classes/image.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 73f1d52c..793c21a2 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -457,7 +457,7 @@ EOSUDO > > # Sometimes qemu-user-static generates coredumps in chroot, move them > # to work temporary directory and inform user about it. > - for f in $(sudo find ${ROOTFSDIR} -name *.core); do > + for f in $(sudo find ${ROOTFSDIR} -type f -name *.core); do > sudo mv "${f}" "${WORKDIR}/temp/" > bbwarn "found core dump in rootfs, check it in ${WORKDIR}/temp/${f##*/}" > done Yeah, too much heuristics in play now. We could add a list of valid "core" files on top, but maybe we should rather demand core file generation being disabled during the build and enforcing that. Jan -- Siemens AG, Technology Linux Expert Center