public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH v4 4/4] installer: Fix DEPLOY_DIR_IMAGE path for target image
Date: Wed, 21 Jan 2026 19:29:13 +0100	[thread overview]
Message-ID: <6d3d3b78-d29c-43c6-ac83-dbdc72b1539f@siemens.com> (raw)
In-Reply-To: <20260121153028.869575-5-amikan@ilbers.de>

On 21.01.26 16:30, Anton Mikanovich wrote:
> As it was changed for fixing DTB deployment conflicts.
> 

Than fix the patch that is changing it, or you are creating a friction
point for bisection.

Jan

> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta-isar/classes-recipe/installer-add-rootfs.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> index 2fa551bd..b79c2357 100644
> --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass
> @@ -13,7 +13,9 @@ INSTALLER_TARGET_IMAGES ??= "${INSTALLER_TARGET_IMAGE}"
>  INSTALLER_TARGET_MC ??= "installer-target"
>  INSTALLER_TARGET_DISTRO ??= "${DISTRO}"
>  INSTALLER_TARGET_MACHINE ??= "${MACHINE}"
> -INSTALLER_TARGET_DEPLOY_DIR_IMAGE ??= "${DEPLOY_DIR}/images/${INSTALLER_TARGET_MACHINE}"
> +INSTALLER_TARGET_KERNEL_NAME ??= "${KERNEL_NAME}"
> +INSTALLER_TARGET_DEPLOY_DIR_POSTFIX ??= "${@ ('-'+d.getVar('INSTALLER_TARGET_KERNEL_NAME')) if d.getVar('INSTALLER_TARGET_KERNEL_NAME') else ''}"
> +INSTALLER_TARGET_DEPLOY_DIR_IMAGE ??= "${DEPLOY_DIR}/images/${INSTALLER_TARGET_MACHINE}-${INSTALLER_TARGET_DISTRO}${INSTALLER_TARGET_DEPLOY_DIR_POSTFIX}"
>  
>  IMAGE_DATA_FILE ??= "${INSTALLER_TARGET_IMAGE}-${INSTALLER_TARGET_DISTRO}-${INSTALLER_TARGET_MACHINE}"
>  IMAGE_DATA_POSTFIX ??= "wic.zst"


-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/6d3d3b78-d29c-43c6-ac83-dbdc72b1539f%40siemens.com.

  reply	other threads:[~2026-01-21 18:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 15:30 [PATCH v4 0/4] Deploy DTBs with separate recipe Anton Mikanovich
2026-01-21 15:30 ` [PATCH v4 1/4] meta: Fix do_copy_boot_files error for different distros of same machine Anton Mikanovich
2026-01-21 15:30 ` [PATCH v4 2/4] testsuite: Add test to check dtb deployment Anton Mikanovich
2026-01-21 15:30 ` [PATCH v4 3/4] meta: Move DTB deployment to a separate dtb-files recipe Anton Mikanovich
2026-01-21 18:27   ` 'Jan Kiszka' via isar-users
2026-01-23 12:40     ` Anton Mikanovich
2026-01-23 14:24       ` 'Jan Kiszka' via isar-users
2026-01-21 15:30 ` [PATCH v4 4/4] installer: Fix DEPLOY_DIR_IMAGE path for target image Anton Mikanovich
2026-01-21 18:29   ` 'Jan Kiszka' via isar-users [this message]
2026-01-23 12:44     ` Anton Mikanovich
2026-01-23 14:26       ` 'Jan Kiszka' via isar-users
2026-01-22 16:53 ` [PATCH v4 0/4] Deploy DTBs with separate recipe Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d3d3b78-d29c-43c6-ac83-dbdc72b1539f@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox