From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Zhibin Dong <zhibin.dong@siemens.com>,
"Moessbauer, Felix (T CED SES-DE)" <felix.moessbauer@siemens.com>
Subject: [PATCH] image: Restrict coredumps to *.core files again
Date: Thu, 27 Jun 2024 19:04:41 +0200 [thread overview]
Message-ID: <6d425cce-dc62-4221-a87d-c15598911e84@siemens.com> (raw)
From: Jan Kiszka <jan.kiszka@siemens.com>
Looking at every file's mime-type in a rootfs is simply way too costly
and also not needed in practice.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
To make my point more concrete. Please speak up if you think that
coredumps with different endings do play a role. But make sure that case
is strong:
- 7.5 min. do_rootfs_finalize for meta-iot2050 so far
- 0.5 min. with this change
meta/classes/image.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 0a80273f..c29d9e26 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -436,7 +436,7 @@ EOSUDO
# Sometimes qemu-user-static generates coredumps in chroot, move them
# to work temporary directory and inform user about it.
- for f in $(sudo find ${ROOTFSDIR} -type f -exec file --mime-type {} \; | grep 'application/x-coredump' | cut -d: -f1); do
+ for f in $(sudo find ${ROOTFSDIR} -type f -name *.core -exec file --mime-type {} \; | grep 'application/x-coredump' | cut -d: -f1); do
sudo mv "${f}" "${WORKDIR}/temp/"
bbwarn "found core dump in rootfs, check it in ${WORKDIR}/temp/${f##*/}"
done
--
2.43.0
next reply other threads:[~2024-06-27 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 17:04 Jan Kiszka [this message]
2024-06-28 1:52 ` Dong, Zhi Bin
2024-07-01 3:15 ` Uladzimir Bely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d425cce-dc62-4221-a87d-c15598911e84@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=zhibin.dong@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox