public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>,
	isar-users@googlegroups.com
Subject: Re: [RFC PATCH 2/2] meta/u-boot: Include libssl-dev only when building tools
Date: Mon, 15 Nov 2021 17:46:34 +0100	[thread overview]
Message-ID: <6d5763b1-97a5-390c-91b9-1e0a89b1da4f@siemens.com> (raw)
In-Reply-To: <20211115160642.765371-3-Vijaikumar_Kanagarajan@mentor.com>

On 15.11.21 17:06, Vijai Kumar K wrote:
> libssl-dev of the host architecture is needed only when you
> cross compile u-boot-tools.

Did you mean "host" in the Gnu/Debian sense, i.e. the target (in Isar
sense)? Or "build" - but that would mean ":native"?

> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
>  meta/recipes-bsp/u-boot/u-boot-custom.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> index bc92552..0887757 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> @@ -25,7 +25,8 @@ python() {
>  }
>  
>  DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native"
> -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}"
> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if (d.getVar('ISAR_CROSS_COMPILE') == '1' and \
> +			bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d)) else ''}"
>  
>  
>  TEMPLATE_FILES = "debian/control.tmpl"
> 

Code makes sense - I assume to tested with a very recent U-Boot and all
profiles on.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

  reply	other threads:[~2021-11-15 16:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 16:06 [RFC PATCH 0/2] U-boot refactor Vijai Kumar K
2021-11-15 16:06 ` [RFC PATCH 1/2] u-boot: Switch to use DEB_BUILD_PROFILES Vijai Kumar K
2021-11-15 16:44   ` Jan Kiszka
2021-11-16  8:42     ` vijai kumar
2021-11-16 15:02   ` Gylstorff Quirin
2021-11-17  5:52     ` vijai kumar
2021-11-15 16:06 ` [RFC PATCH 2/2] meta/u-boot: Include libssl-dev only when building tools Vijai Kumar K
2021-11-15 16:46   ` Jan Kiszka [this message]
2021-11-16  8:44     ` vijai kumar
2021-11-15 16:10 ` [RFC PATCH 0/2] U-boot refactor vijai kumar
2021-11-16  9:51 ` [PATCH v2 " Vijai Kumar K
2021-11-16  9:51   ` [PATCH v2 1/2] u-boot: Switch to use DEB_BUILD_PROFILES Vijai Kumar K
2021-11-16 15:40     ` Jan Kiszka
2021-11-17  5:56       ` vijai kumar
2021-11-16  9:51   ` [PATCH v2 2/2] meta/u-boot: Include libssl-dev only when building tools Vijai Kumar K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d5763b1-97a5-390c-91b9-1e0a89b1da4f@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Vijaikumar_Kanagarajan@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox