public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Henning Schild <henning.schild@siemens.com>,
	Anton Mikanovich <amikan@ilbers.de>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH v6 5/7] vm-img: set vmware machine type to 64bit in our template
Date: Tue, 24 May 2022 21:05:31 +0200	[thread overview]
Message-ID: <6e9bc560-1d4b-37f7-ed3d-ecc7f1c301a4@siemens.com> (raw)
In-Reply-To: <20220519232051.6da91237@md1za8fc.ad001.siemens.net>

On 19.05.22 23:20, Henning Schild wrote:
> Am Fri, 17 Dec 2021 17:48:33 +0300
> schrieb Anton Mikanovich <amikan@ilbers.de>:
> 
>> From: Henning Schild <henning.schild@siemens.com>
>>
>> Tell vmware that it is dealing with a 64bit guest. Before that change
>> an efi image could not be booted because the 32bit uefi firmware
>> would not like a 64bit bootloader.
> 
> In fact the machine config has DISTRO_ARCH ?= so people could
> potentially go 32 bit after all.
> 
>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>> ---
>>  meta/classes/vm-img/vm-img-vmware.ovf.tmpl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/vm-img/vm-img-vmware.ovf.tmpl
>> b/meta/classes/vm-img/vm-img-vmware.ovf.tmpl index 5280f33..2883ce0
>> 100644 --- a/meta/classes/vm-img/vm-img-vmware.ovf.tmpl
>> +++ b/meta/classes/vm-img/vm-img-vmware.ovf.tmpl
>> @@ -16,7 +16,7 @@
>>    <VirtualSystem ovf:id="vm">
>>      <Info>A virtual machine</Info>
>>      <Name>${OVA_NAME}</Name>
>> -    <OperatingSystemSection ovf:id="1" vmw:osType="otherGuest">
>> +    <OperatingSystemSection ovf:id="102" vmw:osType="otherGuest64">
> 
> We could try and derive the value from DISTRO_ARCH.
> 
> But on the other hand we allow people to provide their own template in
> case the default does not match.
> 
> This is a pitfall but not a big deal, just hoping that not too many
> people end up building 32bit vmware images.
> 
> Not sure i will send a patch, probably not ... just saying for now.
> 

We should ship the better default, and that is clearly 64-bit today.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

  reply	other threads:[~2022-05-24 19:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 14:48 [PATCH v6 0/7] vm-img improvements and fixes Anton Mikanovich
2021-12-17 14:48 ` [PATCH v6 1/7] vm-img: move template out of package into SRC_URI file Anton Mikanovich
2021-12-17 16:35   ` Henning Schild
2021-12-28  6:37     ` Anton Mikanovich
2021-12-17 14:48 ` [PATCH v6 2/7] vm-img: use two different ovf templates for vmware/virtualbox Anton Mikanovich
2021-12-17 14:48 ` [PATCH v6 3/7] vm-img: shorten code by using variables we have Anton Mikanovich
2021-12-17 14:48 ` [PATCH v6 4/7] vm-img: drop not used variables Anton Mikanovich
2021-12-17 14:48 ` [PATCH v6 5/7] vm-img: set vmware machine type to 64bit in our template Anton Mikanovich
2022-05-19 21:20   ` Henning Schild
2022-05-24 19:05     ` Jan Kiszka [this message]
2022-05-24 22:28       ` Henning Schild
2021-12-17 14:48 ` [PATCH v6 6/7] vm-img: make use of isars template class for most of the tmpl variables Anton Mikanovich
2021-12-17 14:48 ` [PATCH v6 7/7] meta-isar: switch virtualbox test from buster to bullseye Anton Mikanovich
2021-12-27 13:00 ` [PATCH v6 0/7] vm-img improvements and fixes Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e9bc560-1d4b-37f7-ed3d-ecc7f1c301a4@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox